[go: up one dir, main page]

Page MenuHomePhabricator

Spike for Reading List bugs and stability
Open, MediumPublicBUG REPORT

Description

After a brief look at all of these bugs, I think we should tackle them in this manner:

Possible Redirect Issues

Thanks to a couple of more reproducible bugs, I'm bucketing these issues together as bugs that are likely related to redirected articles. They should be investigated and fixed at the same time by the same engineer.

Problem: Users that have unresponsive save icons, a few duplicate saved articles, blank spaces or missing thumbnails in the Saved tab.
Background Reading: Become more familiar with how saving articles for offline works in the app (happy and error paths), as well as how redirected articles work in MediaWiki. What happens if there is a reference to an old article name in the app? What if the user has already saved an article under the old name?
Other prep work: We're unblocked on some of this due to being able to reproduce bugs, but it would still help to also obtain user data export files from anyone that reported these bugs.

Most reproducible:
T300050
T285992

Other similar bugs
T282803
T313501
T314690
T299012

Possible Syncing or Migration issues

For these, I think something odd is either happening with migration (because a lot of users seem to complain that it happens after an update) or the syncing of reading lists. There are no good reproducible steps at this point though. These should be investigated and fixed at the same time by the same engineer.

Problem: Users with disappearing reading lists, or a huge amount of duplicate saved articles.
Background Reading: Become more familiar with how saving articles for offline works in the app (happy and error paths). Also understand fully how reading list syncing works (when does the system know to automatically delete saved articles?), and how it works against Android's different default list name. Also revisit the mobile-html migration code. If possible, re-test it by building an old version of the app (before 6.6.0), save several articles and reading lists, then update to the latest version.
Other prep work: Try to get user data export files from users with disappearing lists and the duplicate Yellowstone user.

T301306
T292469
T281614
T301743
T302601

One offs

These issues either feel less common or less mysterious. They are one-off problems that should be tackled at the end once the bigger issues above are resolved. They can be tackled separately by any engineer.

T311326
T315686
T277599
T265776
T275898

Event Timeline

Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptOct 18 2022, 7:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tsevener renamed this task from [placeholder] Spike for Reading List bugs and stability to Spike for Reading List bugs and stability.Oct 27 2022, 2:47 PM
Tsevener updated the task description. (Show Details)
Tsevener updated the task description. (Show Details)
LGoto triaged this task as Medium priority.Oct 31 2022, 6:35 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
LGoto added a project: ios-app-v7.0.1.
Aklapper changed the subtype of this task from "Spike" to "Bug Report".Feb 17 2023, 8:26 AM

Wondering if this should be split into two spikes based on how the description as been split?

Here are my evolving disappearing reading list hunches.

In the last exported library I explored, I noticed they had saved article files still on device, but their database (i.e. what Saved articles tab displays) was cleaned out. This is why sometimes users have an empty Saved Articles screen, but the callout in Settings > Article storage and syncing still mentions a large amount of data (“Erasing your saved articles will free up about {nnn} MB of space”).

I don't know how they got into this state, but it may be possible to work backwards and restore this (i.e. loop through all their saved article files, figure out the article title, and add them back into the database). That last user complaint said they had low storage, so maybe something about low storage is causing our Core Data database to be dumped upon update.

I also think we have lots of pop ups related to saved articles that may be confusing to the user. We do not allow a user to save articles only to the cloud - they must also use up device space on their app to persist articles in order to benefit from the Saved articles feature. Maybe users are deleting their local articles but not realizing that they won't be able to restore once they delete their local articles. It's also possible that there are fleeting issues with authentication which could cause a prompt asking the user if they want to delete their saved articles. Here is a prompt I receive in the app after changing my password on Desktop and relaunching my app:

Screenshot 2024-02-20 at 2.23.25 PM.jpeg (2×1 px, 684 KB)

Ideas:

See if QA can reproduce losing reading lists by testing on a device with lots of saved articles, low/no storage and updating. If they can repro, go from there. If not, here are some things we could try:

  1. Build in that restoration step, add a button in Settings. Work backwards from our persisted files and add them back into the database.
  2. If user is low on storage, give them a warning and say that saving new articles are disabled until they get more storage or delete some old saved articles.
  3. Audit our popups and confirm they are appearing at the appropriate time, and communicate the ramifications clearly.
  4. Maybe have a "recently deleted" saved articles folder before actually deleting, so that a user can restore if they accidentally pushed the wrong button in those popups.