[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T255792

Quibble runs core:unit tests twice!
Open, Stalled, HighPublic
Actions

Description

During a full run of Quibble, I noticed PHPUnit alerts twice about the slow test Argon2PasswordTest:testPartialConfig. Turns out it run twice, once as part of the core:unit suite and another time as part of the default phpunit.php suite. The commands Quibble runs are:

core:unit
phpunit --colors=always --testsuite=core:unit,extensions:unit,skins:unit '--exclude-group' 'Broken,ParserFuzz,Stub'

The suite is defined as:

/phpunit.xml.dist
<phpunit>
    <testsuites>
        <testsuite name="core:unit">
            <directory>tests/phpunit/unit</directory>
        </testsuite>
</phpunit>

The second command is:

1
php tests/phpunit/phpunit.php --exclude-group Broken,ParserFuzz,Stub,Database,Standalone --log-junit /workspace/log/junit-dbless.xml

Which I guess crawls everything and thus also discover tests under tests/phpunit/unit. I guess we should exclude them?

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT255792 Quibble runs core:unit tests twice!
 OpenNoneT328919 Upgrade to PHPUnit 10
 OpenNoneT328922 Drop PHP 8.0 support from MediaWiki
 StalledKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 ResolvedtstarlingT292552 Rename articles and users to update our case mapping to PHP 7.4 and Unicode 11
 ResolvedJdforrester-WMFT316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
 ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
 ResolvedtstarlingT314212 str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
 ResolvedReedyT311448 Echo PHP 8.1 support
 ResolvedBUG REPORTtstarlingT289925 FILTER_SANITIZE_STRING is deprecated in PHP 8.1
 ResolvedtstarlingT320726 Fix RandomImageGenerator as used in tests to work on PHP 8.1 without errors or warnings
 ResolvedDaimonaT311451 Re-enable PHP 8.1 CI on css-sanitizer
 ResolvedDaimonaT311452 Taint Check Plugin release
 ResolvedNoneT307506 Address PHP 8.1 job failures on various PHP libs
 ResolvedJdforrester-WMFT311450 Re-enable PHP 8.1 CI on RemexHTML
 ResolvedBUG REPORTNoneT308406 RemexHtml should support PHP 8.1
 ResolvedtstarlingT307630 mediawiki/libs/RemexHtml phan issues under 8.1
 ResolvedJdforrester-WMFT311463 Re-enable PHP 8.1 CI on Zest
 ResolvedssastryT307632 mediawiki/libs/Zest phan issues under 8.1
 ResolvedkostajhT321600 GrowthExperiments PHP 8.1 support
 ResolvedkostajhT321691 StructuredDiscussions support for PHP 8.1
 ResolvedthiemowmdeT321692 FileImporter support for PHP 8.1
 ResolvedtstarlingT322098 GeoData support for PHP 8.1
 ResolvedtstarlingT322099 TwoColConflict support for PHP 8.1
 ResolvedBUG REPORTLucas_Werkmeister_WMDET319219 Wikibase gives deprecated warnings on php 8.1
 ResolvedhooT301249 Handle deprecation of Serializable interface in Wikibase
 ResolvedhooT305785 Wikibase Snak hashes (and thus "mainsnak", "references" and "qualifiers" hashes) depend on legacy PHP serialization
 ResolvedJdforrester-WMFT322233 PageViewInfo support for PHP 8.1
 ResolvedthiemowmdeT322408 CirrusSearch support for PHP 8.1
 ResolvedkostajhT322838 PageTriage PHP 8.1 support
 ResolvedUmherirrenderT323056 STVTallierTest::testFinishTally() fails under PHP 8.0 and later
 ResolvedPRODUCTION ERROR• brookeT289189 getid3: PHP Warning: Division by zero
 ResolvedTheresNoTimeT332356 function strftime() is deprecated in php8.1 used by Calendar extension
 ResolvedtstarlingT322278 MediaWiki core should pass Phan on PHP 8.1
 OpenJdforrester-WMFT320818 Configure CI to test the Wikimedia production gate code against PHP 8.1 as well as PHP 7.4
 ResolvedlarissagauliaT321709 PHP 8.1 Upgrade Performance <-> SRE Service Ops coordination
 ResolvedJMeybohmT345561 Upgrade the MediaWiki servers to ICU 67
 ResolvedMoritzMuehlenhoffT350767 Rebuild PHP 7.4 packages for Bullseye
 OpendduvallT370934 Build and publish multiple MediaWiki production images for a given set of PHP versions
 OpenNoneT373752 Build php-uuid package, and add to WMF production and CI
 ResolvedJdforrester-WMFT359868 Drop PHP 7.4 and 8.0 support from MediaWiki 1.42; require PHP 8.1+
 OpenNoneT363639 web-auth/webauthn-lib must be upgraded to 4+ for PHP 8 support
 ResolvedLucas_Werkmeister_WMDET328741 Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
 ResolvedDaimonaT342110 Upgrade to PHPUnit 9.6
 ResolvedDaimonaT342259 Move MediaWikiIntegrationTestCase setup and teardown away from run()
 ResolvedDaimonaT342301 Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking
 OpenNoneT332865 PHPUnit data providers should be simple static functions that return plain data
 OpenNoneT337130 Make PHPUnit dataProvider LexemeFieldTest::getTestData static (WikibaseLexemeCirrusSearch extension)
 OpenNoneT337135 Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
 OpenNoneT337144 Make PHPUnit dataProvider static in AbuseFilter tests
 OpenNoneT337155 Make PHPUnit dataProvider static in ReadingLists tests
 OpenNoneT337156 Make PHPUnit dataProvider static in IPInfo tests
 ResolvedtstarlingT337157 Make PHPUnit dataProvider static in LoginNotify tests
 OpenNoneT337158 Make PHPUnit dataProvider static in Flow tests
 ResolvedDreamy_JazzT337159 Make PHPUnit dataProvider static in CheckUser tests
 ResolvedDreamy_JazzT346044 Remove CheckUserUnionQueryBuilder
 ResolvedPhysikerweltT337160 Make PHPUnit dataProvider static in Math tests
 ResolvedTgrT337161 Make PHPUnit dataProvider static in OAuth tests
 OpenNoneT337162 Make PHPUnit dataProvider static in ProofreadPage tests
 OpenNoneT337163 Make PHPUnit dataProvider static in CirrusSearch tests
 ResolvedNoneT337164 Make PHPUnit dataProvider static in FileImporter tests
 OpenNoneT337165 Make PHPUnit dataProvider static in GrowthExperiments tests
 OpenNoneT337166 Make PHPUnit dataProvider static in CampaignEvents tests
 OpenNoneT371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
 OpenNoneT337154 Make PHPUnit dataProvider static in Wikibase tests
 ResolvedLucas_Werkmeister_WMDET337153 Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
 OpenNoneT337151 Make PHPUnit dataProvider static in WikibaseLexeme tests
 OpenNoneT337152 Make PHPUnit dataProvider static in WikibaseMediaInfo tests
 ResolvedthiemowmdeT337150 Make PHPUnit dataProvider static in Wikidata.org tests
 OpenNoneT337148 Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
 OpenNoneT345481 Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing
 OpenNoneT358394 Stop using PHPUnit's TestSuite in Scribunto
 OpenDannyS712T363064 MediaWiki.Commenting.MissingCovers.MissingCovers does not support PHPUnit 10.x attributes
 OpenNoneT363641 IPUtils: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 ResolvedlarissagauliaT363650 Minify: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 OpenNoneT362858 equivset: Expecting E_ERROR and E_USER_ERROR is deprecated

Event Timeline

hashar created this task.Jun 18 2020, 4:40 PM
Jdforrester-WMF subscribed.Jun 18 2020, 5:35 PM

Oops.

Jdforrester-WMF triaged this task as High priority.Jun 18 2020, 5:35 PM
hashar added a comment.Jun 19 2020, 8:34 AM

It is not the end of the world though core:unit takes just a few seconds to execute ;-]

kostajh added a comment.Nov 24 2021, 2:08 PM

Is this still a problem, or a problem worth doing something about?

kostajh moved this task from Backlog to Watching on the User-kostajh board.Nov 24 2021, 2:08 PM
Daimona subscribed.Sep 5 2023, 1:24 AM
In T255792#7526593, @kostajh wrote:

Is this still a problem, or a problem worth doing something about?

This is still a problem. As for the second question: I don't think it's worth doing anything about this now, because PHPUnit 9 does not provide a CLI options to exclude a certain testsuite, and any other way we could come up with to exclude unit tests would be either a huge hack or a huge change to be implemented in all tests. OTOH, PHPUnit 10 does provide that option! It's --exclude-testsuite, see https://github.com/sebastianbergmann/phpunit/pull/4657. Once we upgrade, it should be really simple to add this option to the integration suite invocation. The only thing that makes this non-trivial is, I think, the fact that we'll probably have to write some BC logic so that the option is only passed if the repo uses PHPUnit >= 10.

Daimona added a subtask: T328919: Upgrade to PHPUnit 10.Sep 5 2023, 1:24 AM
Novem_Linguae subscribed.Sep 7 2023, 10:38 AM

BC logic

BC = beta cluster?

kostajh added a comment.Sep 7 2023, 10:47 AM
In T255792#9148823, @Novem_Linguae wrote:

BC logic

BC = beta cluster?

I beileve it's backwards-compatibility, in this context.

Daimona added a comment.Sep 7 2023, 11:44 AM
In T255792#9148847, @kostajh wrote:
In T255792#9148823, @Novem_Linguae wrote:

BC logic

BC = beta cluster?

I beileve it's backwards-compatibility, in this context.

Yes, sorry, it is backwards compatibility indeed.

Daimona changed the task status from Open to Stalled.Sep 7 2023, 4:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits