The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:
static and adjust the usages (More infos at T332865).
Initial work was done in 0d89717c1f999529bdcc5f5cf313f7b1fbdb7284
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T255792 Quibble runs core:unit tests twice! | |||
| Open | None | T328919 Upgrade to PHPUnit 10 | |||
| Open | None | T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min | |||
| Open | None | T332865 PHPUnit data providers should be simple static functions that return plain data | |||
| Open | None | T371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions | |||
| Resolved | Lucas_Werkmeister_WMDE | T337153 Make PHPUnit dataProvider static in WikibaseQualityConstraints tests |
Apparently half this work was already done, but unfortunately I only found that out after I made very similar changes myself, because it wasn’t linked to this task.
Change 923539 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Make most data providers static
Change 923540 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Make DefaultConfig::getDefaultConfig() static
Change 923541 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] TimeValueComparerTest: Make data provider static
Change 923542 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] RangeCheckerHelperTest: Make data provider static
Change 923543 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] ContemporaryCheckerTest: Make data provider static
Change 923541 abandoned by Lucas Werkmeister (WMDE):
[mediawiki/extensions/WikibaseQualityConstraints@master] TimeValueComparerTest: Make data provider static
Reason:
The important part of this change was already done in I8302e26edc; the static types will just have to wait for another time.
Change 923542 abandoned by Lucas Werkmeister (WMDE):
[mediawiki/extensions/WikibaseQualityConstraints@master] RangeCheckerHelperTest: Make data provider static
Reason:
The important part of this change was already done in I8302e26edc; the static types will just have to wait for another time.
Change 923540 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Make DefaultConfig::getDefaultConfig() static
Change 923539 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] WikibaseQualityConstraintsHooksTest: Make data provider static
Change 923543 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] ContemporaryCheckerTest: Make data provider static