[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T346044

Remove CheckUserUnionQueryBuilder
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

After investigation in T328997: Enable read new support in Special:CheckUser's 'Get users' mode it has been determined that using UNION queries is too expensive and three separate queries would be better for performance when a large number of results are selected.

Acceptance criteria
  • Remove the CheckUserUnionQueryBuilder and related code that is only used by the query builder

Details

SubjectRepoBranchLines +/-
Remove CheckUserUnionSelectQueryBuilder and associated methodsmediawiki/extensions/CheckUsermaster+0 -2 K
Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUsermediawiki/extensions/CheckUsermaster+5 -29
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFeatureDreamy_JazzT311375 Instead of not showing any results on too many results show the results to the truncation point with a pager that allows generation of more results
 ResolvedFeatureDreamy_JazzT313446 Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder
 OpenNoneT364943 InvestigateBlock does not allow many custom options
Restricted Task
Restricted Task
 StalledNoneT255792 Quibble runs core:unit tests twice!
 OpenNoneT328919 Upgrade to PHPUnit 10
 ResolvedSecurityDreamy_JazzT268147 CVE-2024-40611: Special:CheckUser shows deleted edits to non-admins
 ResolvedSecurityZabeT311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
 ResolvedSecurityDreamy_JazzT316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
 ResolvedSecurityDreamy_JazzT318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
 ResolvedSecurityDreamy_JazzT316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
Restricted Task
 ResolvedBUG REPORTDreamy_JazzT326866 CVE-2024-40596: Special:Investigate can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326867 CVE-2024-40598: CheckUser API can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326865 CVE-2024-40597: Special:CheckUser can expose suppressed information for log events
 ResolvedDreamy_JazzT253796 Make CheckUser record the log_id of logged actions
 OpenNoneT139810 RFC: Overhaul the CheckUser extension
 ResolvedDreamy_JazzT132892 CheckUser UI revamp
 ResolvedDreamy_JazzT69811 CheckUsers "Get users" design needs improvements
 ResolvedFeatureDreamy_JazzT24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
 DuplicateNoneT145340 Split CheckUser mass-block interface to separate special page
 ResolvedFeatureDreamy_JazzT316441 Enforce minimum length of the tag on the client side for the checkuser block form
 ResolvedFeatureDreamy_JazzT321427 Allow HTMLForm text based elements to specify a minimum length
 ResolvedFeatureDreamy_JazzT321439 Allow TextInputWidget to specify the "minlength" attribute
 ResolvedFeatureDreamy_JazzT316444 The CheckUser block form should explain why users were not blocked or tagged
 ResolvedFeatureDreamy_JazzT314700 Restore the bottom paging links on 'Get users'
 ResolvedBUG REPORTDreamy_JazzT314217 Checkuserblock form is broken when paging links are shown on 'Get users'
 DeclinedFeatureNoneT313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
 ResolvedFeatureDreamy_JazzT18306 Allow user to specify block settings from CU form
 ResolvedGlaisherT41213 Block interface after "Get users" check should allow talk page/send email blocking
 ResolvedFeatureDreamy_JazzT329493 Replace Special:CheckUser's 'get users' block form with a usage of Special:InvestigateBlock
 ResolvedDreamy_JazzT339914 Remove CheckUserEnableSpecialInvestigate config
 ResolvedFeatureDreamy_JazzT318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
 ResolvedDreamy_JazzT362569 Test SpecialInvestigateBlock
 ResolvedDreamy_JazzT366265 Limit the number of blocks that can be performed in a single use of Special:InvestigateBlock to wgCheckUserMaxBlocks
 DeclinedNoneT27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
 ResolvedFeatureDreamy_JazzT318459 Make a clearer visual distinction between the UA and IP list in 'get users'
 ResolvedGlaisherT49505 CheckUser results (userlinks) cannot be customized
 ResolvedNiharikaT24119 Enhance Blocking and tagging from checkuser interface: add new page
 ResolvedNoneT14808 Blocking and tagging from checkuser interface
 ResolvedFeatureDreamy_JazzT16699 More versatile searching in CheckUser log
 DeclinedNoneT15789 Restore the global CheckUser log
 ResolvedFeatureDreamy_JazzT309924 Add check links for both the target and performer in Special:CheckUserLog
 ResolvedFeatureDreamy_JazzT309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
 DuplicateNoneT140345 Userlinks in CheckUser should be customizable
 ResolvedDreamy_JazzT21964 Provide a link to the user on account creation
 DuplicateNoneT144099 Make CheckUser unit-testable
 ResolvedDreamy_JazzT309815 Use OOUI in Special:CheckUser
 ResolvedDreamy_JazzT310019 The Special:CheckUser block form should use OOUI
 ResolvedDreamy_JazzT266586 Use OOUI in SpecialCheckUserLog
Restricted Task
 OpenFeatureNoneT26231 Allow CheckUsers to filter checks for account creations only
 ResolvedDreamy_JazzT139809 Bad output of AbuseFilter blocks in CU get edits
 ResolvedBUG REPORTDreamy_JazzT41013 Incomplete i18n for log entries in CheckUser
 ResolvedBUG REPORTDreamy_JazzT268156 Partial blocks from namespaces are displayed odd
 OpenNoneT311354 Make CheckUser results easier to parse by userscripts
 OpenFeatureNoneT311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
 DeclinedFeatureNoneT54849 Checkuser option "get users" should point out when user password is changed
 OpenFeatureNoneT315488 Show failed login attempts in the results list for the user
Restricted Task
 ResolvedDreamy_JazzT145265 Store check user data action text in structured format
 ResolvedkostajhT257893 [EPIC] Support User-Agent Client Hints header in CheckUser
 OpenNoneT341094 Create client hint mapping rows for CheckUser-worthy events
 ResolvedNoneT248926 Performance review of checkuser database queries [NOT READY]
 ResolvedtstarlingT342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
 OpenNoneT225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
 OpenNoneT332865 PHPUnit data providers should be simple static functions that return plain data
 ResolvedDreamy_JazzT337159 Make PHPUnit dataProvider static in CheckUser tests
 OpenNoneT301992 Insert CheckUser row events during certain 2FA actions
 ResolvedTchandersT326393 IP Address Reveal on Log page
 DeclinedBUG REPORTNoneT28843 CheckUser results do not appear cleanly for AbuseFilter modifications
 OpenNoneT366719 Update AccountInfo InfoLookup::getUserInfo to read data from cu_log_event and cu_private_event
 OpenNoneT366739 Update ArticleFeedbackv5 rebuildCheckUser.php maintenance script for CheckUser extension database changes
 ResolvedDreamy_JazzT371099 No longer use removed cuc_actiontext column in analytics/refinery
 ResolvedFeatureDreamy_JazzT324907 Create separate tables for log events in CheckUser
 ResolvedDreamy_JazzT346044 Remove CheckUserUnionQueryBuilder

Event Timeline

Dreamy_Jazz created this task.Sep 11 2023, 2:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2023, 2:45 PM
Dreamy_Jazz claimed this task.Sep 11 2023, 2:47 PM
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.
Dreamy_Jazz edited projects, added Anti-Harassment; removed Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Sep 11 2023, 2:49 PM
Dreamy_Jazz added a parent task: T324907: Create separate tables for log events in CheckUser.
Dreamy_Jazz added a parent task: T337159: Make PHPUnit dataProvider static in CheckUser tests.Sep 12 2023, 1:14 PM
Dreamy_Jazz mentioned this in T337159: Make PHPUnit dataProvider static in CheckUser tests.
gerritbot added a comment.Sep 21 2023, 5:38 PM

Change 959253 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser

https://gerrit.wikimedia.org/r/959253

gerritbot added a project: Patch-For-Review.Sep 21 2023, 5:38 PM
dom_walden mentioned this in T328995: Enable read new support in Special:CheckUser's 'Get edits' mode.Sep 28 2023, 2:25 PM
gerritbot added a comment.Nov 17 2023, 11:47 AM

Change 959253 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilderFactory from SpecialCheckUser

https://gerrit.wikimedia.org/r/959253

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 17 2023, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 17 2023, 12:10 PM
gerritbot added a comment.Nov 17 2023, 1:06 PM

Change 975263 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilder and associated methods

https://gerrit.wikimedia.org/r/975263

gerritbot added a project: Patch-For-Review.Nov 17 2023, 1:06 PM
Dreamy_Jazz edited projects, added Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)); removed Anti-Harassment.Nov 17 2023, 1:08 PM
Dreamy_Jazz set the point value for this task to 1.Nov 20 2023, 4:21 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.
Tchanders moved this task from Needs review to Done on the Trust and Safety Product Sprint (Sprint Shamisen (20th Nov - 1st Dec. 2023)) board.Nov 27 2023, 4:06 PM
gerritbot added a comment.Nov 27 2023, 5:14 PM

Change 975263 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove CheckUserUnionSelectQueryBuilder and associated methods

https://gerrit.wikimedia.org/r/975263

Maintenance_bot removed a project: Patch-For-Review.Nov 27 2023, 5:30 PM
Dreamy_Jazz closed this task as Resolved.Nov 27 2023, 5:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits