Maniphest T337163

Make PHPUnit dataProvider static in CirrusSearch tests
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	May 20 2023, 11:13 PM

Tags

Referenced Files

None

Subscribers

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

QueryStringRegexParserIntegrationTest with provideRefImplQueries
PhraseSuggestFallbackMethodTest with provideTest
FetchPhaseConfigBuilderTest with provideNewHighlightFieldWithFactory
HighlightedFieldBuilderTest with provideTestFactories
QueueingRemediatorTest with provideTestJobIsSent

static and adjust the usages (More infos at T332865).

Initial work was done in c2c3b845cfe91f937ff569e1a617961b9db33450

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Stalled		None	T255792 Quibble runs core:unit tests twice!
		Open		None	T328919 Upgrade to PHPUnit 10
		Open		None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
		Open		None	T332865 PHPUnit data providers should be simple static functions that return plain data
		Open		None	T337163 Make PHPUnit dataProvider static in CirrusSearch tests

Event Timeline

Umherirrender created this task.May 20 2023, 11:13 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 20 2023, 11:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.May 20 2023, 11:13 PM

Gehel moved this task from needs triage to watching / waiting on the Discovery-Search board.May 22 2023, 12:54 PM

Umherirrender updated the task description. (Show Details)May 30 2023, 7:32 PM

Umherirrender unsubscribed.Jul 12 2023, 8:42 PM