[S] Adapt the "Edit summary" existing view and add new pre-populated summary options for Image Recs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	HNordeenWMF
	Mar 1 2024, 10:21 PM

Description

Create the Save Changes (Edit Summary) screen according to figma reference

Requirements:

'Publish' is deemphasized until edit summary is added. (This pattern should apply everywhere).
Add tapable pre-populated edit summaries "Added image" and "Added image and caption" which autofill into field (Parity with Android edit summary)
Incorporate the guidance in T354219 and apply to all edit summary screens

Testing Notes

Please test in TestFlight Wikipedia app 7.5.0 (3509).

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
Resolved	None	T355270 [Sub Epic] Image Recommendations - Add an Image on iOS
Resolved	None	T355271 [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions
Resolved	HNordeenWMF	T358923 [S] Adapt the "Edit summary" existing view and add new pre-populated summary options for Image Recs

Event Timeline

HNordeenWMF created this task.Mar 1 2024, 10:21 PM

HNordeenWMF mentioned this in T355271: [Engineering Epic] iOS - Image Recommendations - Add an Image main flow and actions.Mar 2 2024, 12:02 AM

Mazevedo added a comment.Mar 4 2024, 5:44 PM

This comment was removed by Mazevedo.

Seddon moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS Release FY2023-24 (Archive) board.Mar 5 2024, 2:40 PM

JTannerWMF triaged this task as Medium priority.Mar 5 2024, 3:56 PM

JTannerWMF updated the task description. (Show Details)

Tsevener renamed this task from [M/L] Adapt the "Edit summary" existing view and add new pre-populated summary options for Image Recs to Adapt the "Edit summary" existing view and add new pre-populated summary options for Image Recs.Mar 5 2024, 4:55 PM

JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Mar 5 2024, 7:14 PM

Blocked until T354219 mocks are done.

HNordeenWMF mentioned this in T354219: [L] Improve Edit Summary on iOS .Mar 8 2024, 12:08 AM

Seddon moved this task from Engineering Backlog to iOS Release FY2023-24 on the Wikipedia-iOS-App-Backlog board.Mar 8 2024, 10:45 AM

Seddon edited projects, added Wikipedia-iOS-App-Backlog (iOS Release FY2023-24); removed Wikipedia-iOS-App-Backlog.

Seddon moved this task from Tasks from Product Backlog to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 8 2024, 11:02 AM

HNordeenWMF mentioned this in T359854: [SPIKE] Explore suggesting relevant edit summary chips for action(s) taken.Mar 11 2024, 3:20 PM

HNordeenWMF updated the task description. (Show Details)Mar 12 2024, 1:22 AM

Tsevener claimed this task.Mar 21 2024, 8:49 PM

Tsevener removed Tsevener as the assignee of this task.

Tsevener moved this task from Blocked or Waiting to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener moved this task from Doing to Blocked or Waiting on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener moved this task from Blocked or Waiting to Needs Engineering Sync on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Mar 25 2024, 3:40 PM

@HNordeenWMF @OTichonova I want to confirm this requirement:

'Publish' is disabled until edit summary is added. (This pattern should apply everywhere).

By disabled do you mean the user cannot tap it, or just that it's de-emphasized with the gray color (as T354219 suggests)?

Hi @Tsevener, I think this has been updated to de-emphasized rather than disabled.
So 'Publish' would be gray500 in the de-emphasized state.

@HNordeenWMF

thanks, yes it should read deemphasized! Updated it in the task as well.

Tsevener renamed this task from Adapt the "Edit summary" existing view and add new pre-populated summary options for Image Recs to [S] Adapt the "Edit summary" existing view and add new pre-populated summary options for Image Recs.Mar 25 2024, 6:51 PM

Tsevener moved this task from Needs Engineering Sync to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Eng Note: For this view, I want us to try preventing the "Publish" button from actually posting an edit to the backend, only for the Experimental build. This is so that design review can occur against EN Image Recommendations without actually making edits.

Tsevener claimed this task.Apr 4 2024, 3:35 PM

Tsevener moved this task from Ready for Development to Doing on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Jarrod_Baniqued unsubscribed.Apr 4 2024, 3:43 PM

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4809

Experimental build is #108 for design review.

Note: Test Wiki does not have image recommendations, so I am hiding the actual posting of edits in this experimental build so that design can play with it on other Wikis without updating live data.

Tsevener removed Tsevener as the assignee of this task.Apr 5 2024, 2:32 PM

Tsevener moved this task from Doing to Needs Design Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.

Tsevener mentioned this in T360574: [M] Image Recommendations - Send feedback when rejecting or accepting images..Apr 16 2024, 2:20 PM

Tsevener mentioned this in T358920: [M] Article preview for Image Recs.

Hi @Tsevener!
A couple small things.

Can we get rid of the line between the two toggles?
Could the text in the confirmation toast be gray 700 rather than blue 600?
To Glauco's feedback (from here T354219). Could we make the margins on these screens (in the editing flow also) 16points?

{F47258737}

{F47258756}

I just realized the relationship between this ticket and T354219. I left additional comments in T354219.

OTichonova moved this task from Needs Design Review to Ready for Development on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Apr 18 2024, 1:21 AM

Waiting on T354219 getting merged for final design review.

@OTichonova Please design review in Experimental build #116. Thanks!

OTichonova moved this task from Needs Design Review to Needs Code Review on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Apr 20 2024, 2:35 AM

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4809

Mazevedo moved this task from Needs Code Review to Waiting for Build on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Apr 23 2024, 6:21 PM

~~Can be tested in Staging build 7.4.11 (77).~~

Please test in TestFlight Wikipedia app 7.5.0 (3509).

Tsevener moved this task from Waiting for Build to Needs QA on the Wikipedia-iOS-App-Backlog (iOS Release FY2023-24) board.Apr 23 2024, 10:02 PM

Tsevener updated the task description. (Show Details)Apr 26 2024, 3:22 PM

Looks good on 7.5.0 (3525)

Woo! I love the pre-suggested edit summaries

HNordeenWMF closed this task as Unknown Status.May 7 2024, 3:48 PM

HNordeenWMF claimed this task.

HNordeenWMF changed the task status from Unknown Status to Resolved.May 7 2024, 10:19 PM

	Restricted File
	Apr 18 2024, 1:30 AM

	Restricted File
	Apr 18 2024, 1:30 AM

[S] Adapt the "Edit summary" existing view and add new pre-populated summary options for Image RecsClosed, ResolvedPublicActions