@JTannerWMF what is the "other" referring to here?

If someone selects other, provide some guidance from the edit summary policy and the reverting guidance

Couple of comments regarding the task. 

1)


6. Suggestions

This section that is described under ‘Annotations’ will not be included at this stage. 
Adding this component to the flow would be a fairly large engineering lift. To include this element more time would need to be dedicated to:


•  Create a new solution to use for the pre-defined answers as we do not have a component that lets us do that in the app currently. 

• Create a spike

• Dedicated time would be needed to make this experience reusable and create a component out of it that could be reused in future designs (like in the @ mention in talk pages improvements).



2)


2. Optimize the Watchlist screen. Please add Empty edit summary copy/info from Revision history to the Watchlist for consistency


I wanted to note that iOS doesn’t have the ‘Empty edit summary’ copy in the ‘Revision History’ or in the ‘Watchlist’ cards currently. 
I have added designs for both in the section above. 


Hi @JTannerWMF 


5. Edit summary

Keyboard is active when users arrive on this screen to reduce steps.

On iOS the keyboard would cover the ‘Terms of Use’ text. I see that on Android the text is at the bottom of the ‘Preview’ page. Since the ‘Preview’ page is pretty busy I was curious if we could keep the text on the ‘Edit summary’ page (this would be consistent with mobile web) and not have the keyboard active right away?

Hey @OTichonova I can't see the mocks for Watchlist or Revision History, its restricted T354219#9616386. Sure lets make the keyboard inactive but if we still have an issue with folks clicking through we should revisit this.

@HNordeenWMF can you break off a task for the suggestions. Also, Other was intended for Watchlist for reason for reverting. This task has been generalized but at the least the learn more covers edit summary policy.

Hi @JTannerWMF, hopefully all mocks should be visible now.
Sounds good about the keyboard.

Subtask for suggested edit summaries started: T359854

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4794

@OTichonova Experimental build #100 kicked off for design review.

A piece of additional work that may be useful: if the user decides to watch an article as they edit it, when they publish the change and return to the article view we should refresh the article view's overflow menu to reflect its watched status.

staykids closed https://github.com/wikimedia/wikipedia-ios/pull/4794

Hi @Tsevener, this is my first design review so let me know if things pointed here have been addressed previously and/or if I should tag someone else here.

I only see a few issues:

1. Margin: I did notice that the margin on the experimental instance is considerably wider than the figma file. In the Figma design, margin is set to 16px but in the built it is set to 48px. I believe this should be fixed (unless it is a device size thing)
2. Toggle separation: Another difference between the design and the test instance is the line dividing the toggles. The test instance adds a separation that is not on the Figma file. I believe this needs to be fixed by removing the line separator.
3. Alert component: This one I am not so convinced it is an error. I noticed the test instance and the design file have different components to alert the edits have been published. The design file has a floating alert without a close icon while the experimental instance has a similar one, but it is "anchored at the bottom" with a close icon.

@GLima-WMF

Alert component: This one I am not so convinced it is an error. I noticed the test instance and the design file have different components to alert the edits have been published. The design file has a floating alert without a close icon while the experimental instance has a similar one, but it is "anchored at the bottom" with a close icon.

Yeah, that is a major difference for sure. Unfortunately the Figma uses a new design component that Engineering hasn't moved over to yet. The hope for us to one day build a new Toast component that matches this design (see T350398 for that work). Until then we're going to have that difference due to us using a legacy component.

Your other two items of feedback look doable - I'll update when it's ready for another look. Thanks!

@GLima-WMF New Experimental build #107 is available for design review. This contains margin and div fixes.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4806

@OTichonova yeah, these should still be build #107. Sorry there was a bit of a mixup with these. The design review updates for this ticket are only accessible via the old editor flow in build #107 (i.e. not in image recs yet). Once these changes look good, they will be merged and will propagate into T358923. I can make another design review build for T358923 once this one is merged.

Ah okay sorry, I didn't read the ticket carefully. This looks good!
Couple things ->

1. Could the color of the confirmation toast text be gray 700 in default rather than blue 600 so it doesn't look like a link?

2. The cc text at the bottom of the page still has the old margin, could we update it to have the new margin?

@OTichonova Updates can be design reviewed in Experimental build #115.

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4806

Please test in TestFlight Wikipedia app 7.5.0 (3509).

@Tsevener the minor edit link is leading to : https://meta.wikimedia.org/wiki/Help:Minor_edit, which displays as a CTA to redirect
to this page: https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Minor_edit
Could we swap to the Mediawiki page?

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4834

@HNordeenWMF Will do - I'll leave this in QA since it's such a minor change. No use in holding up testing other parts of this ticket.

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4834

Working on 7.5.0 (3550)

hi @SNowick_WMF. This requires your signoff before release to ensure the new additions are instrumented. Could you please take a look at these changes and let us know if any instrumentation changes are needed?

Changes:

• Change Publish button gray color if edit summary textfield is empty
• Moves edit summary "Learn more" button down to match Figma
• Shows watchlist toggle, turns ON if article is already on user's watchlist
• Adjusts font sizes on edit summary view
• Adds "Empty edit summary" copy to article history and watchlist cells if there is no edit summary

Old Screen:

New screen

@HNordeenWMF The only change that needs to be instrumented is the added Watchlist toggle, we can add a watchlist_added boolean to the action_data for the action = save_attempt where active_interface = article_edit_summary. I made a note in the Instrumentation Doc where this should be added. Not sure where this falls into priorities but would be a nice to have in place so we can get event counts.

thank you @SNowick_WMF !
@Tsevener would you be able to add these instrumentation changes tomorrow?

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4840

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4840

@HNordeenWMF This is done and merged. It will be in the next build we kick off.

woo, thank you @Tsevener ! This will be tested in the main Data validation task T362723

Validating we are seeing watchlist_added: values in action_data in ios_edit_interaction data.