[go: up one dir, main page]

Page MenuHomePhabricator

Phonos audio generation should always happen in the job queue
Closed, ResolvedPublic

Description

Phonos can generate the audio files for the <phonos> tags either immediately during wikitext parsing, or later in a job.

The job queue path was implemented in order to allow adding a rate limit to the generation, which may use a rate-limited API (T318086). However, its current implementation has no way to surface errors occurring during audio generation to the user, therefore it's only used when the parse itself was triggered from a job. This causes problems (T325464), as there is no supported way to detect that a parse is happening inside a job (because the results are not supposed to be different).

This work should be done via the job queue unconditionally, after figuring out a way for that mode to surface the errors. That seems normal for me for a parser extension, and e.g. thumbnailing images or timed media transcoding works in a similar way, where the parser doesn't wait for thumbnails/transcodes to be ready. Life would be much simpler if we could do that here.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Nikerabbit reopened this task as Open.
Nikerabbit claimed this task.
Nikerabbit added a project: Language-Team.
Nikerabbit moved this task from Backlog to Other teams/Watching on the Language-Team board.

Whoops, did not mean to resolve, just to add it to our watchlist.

Change 982443 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Phonos@master] [WIP] Always generate audio files in a job

https://gerrit.wikimedia.org/r/982443

Change 982443 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Always generate audio files in a job

https://gerrit.wikimedia.org/r/982443

matmarex claimed this task.