[go: up one dir, main page]

Page MenuHomePhabricator

CheckUser results do not appear cleanly for AbuseFilter modifications
Closed, DeclinedPublicBUG REPORT

Description

Details

Reference
bz26843

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
DeclinedBUG REPORTNone
ResolvedFeatureDreamy_Jazz

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:17 PM
bzimport added a project: AbuseFilter.
bzimport set Reference to bz26843.
bzimport added a subscriber: Unknown Object (MLST).

modifyActionText() in AB doesn't respect null $skin values as LogPage does.

That said, it would be nice to improve CU tables for log events as I did to RC.

For people who don't have access to that private list, could a public summary of the bug be posted?

From the email from January 2011 (Message-ID: <AANLkTi=hJgGEfsP+iHkeUzVoTvq5NVj0JiodS+pMih5p@mail.gmail.com>)

An user modifies an abusefilter. When checking for edits for that user (in
this case, myself at testwiki) The "get account edits" output in the
CheckUser form looks this way:

  • (53) . . 19:38 . . Dferg (talk | contribs | block) modificó

https://secure.wikimedia.org/wikipedia/test/wiki/Special:AbuseFilter/53 (
https://secure.wikimedia.org/wikipedia/test/wiki/Special:AbuseFilter/history/53/diff/prev/608
)

          IP: [removed]
* (53) . . 19:38 . . Dferg (talk | contribs | block) modificó

https://secure.wikimedia.org/wikipedia/test/wiki/Special:AbuseFilter/53 (
https://secure.wikimedia.org/wikipedia/test/wiki/Special:AbuseFilter/history/53/diff/prev/607
)

IP: [removed]
  • Look that there are a language mixture (en-es in "modificó") I did the

change with the preferences in ES. Then I changed them to EN and the output
didn't changed.

  • The abuse filter that I modifyied where the 53@testwiki.
  • The output for that query should be - IMHO:

13 January 2011

  • (Logs) . . 19:38 . . Dferg (talk | contribs | block) modified

Special:AbuseFilter/53 (details)

IP & UA data here as usual.

As happens in the abusefilter
loghttps://secure.wikimedia.org/wikipedia/test/wiki/Special:Log/abusefilter.
With the correct links and words, of course.

Thanks.
Those are probably outdated right now, this is what I currently see on my testwiki with latest versions of AF+CU:

(<log-name-1>) . . 12:24 . . Admin (Talk | contribs | block) Admin modified Special:AbuseFilter/1 (Special:AbuseFilter/history/1/diff/prev/3).

Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 5 2022, 2:33 PM
Aklapper removed a subscriber: wikibugs-l-list.

These logs no longer appear in Special:RecentChanges and therefore CheckUser interfaces because the log is hidden behind the abusefilter-view permission. If it is intended to send the logs to CheckUser, then AbuseFilter would need to do so manually such as is done in AbuseLogger.

If the logs are sent to CheckUser or the $wgLogRestrictions config is modified to remove the entry for abusefilter then the issue described in this task (the lack of translation) will be fixed by T324907: Create separate tables for log events in CheckUser.

I'm going to decline this task insofar as that I don't think we need to send edit / create actions to CheckUser (because the right is granted to users which are trusted and therefore the chance of running CU on them seems small). The rest of the issues described in this task have been fixed by T324907.