Sorry for the back and forth. An externalLink icon already exists in Codex and this list of icons. Do we want to introduce a brand new icon (different from the existing externalLink ) or update externalLink icon's SVG image?

Thanks! I'll update the SVG image for externalLink icon if I understand that correctly. The current icon image flips/mirrors so I will not change that.

@bmartinezcalvo My understanding is to remove the existing externalLink icon in Codex and replace it with the new icon (both ltr & rtl SVG images). This way the icons in Codex and Figma match. Does that sound right?

Ensure the Menu and components that have a Menu behave as expected.

• Check these components: Menu, Lookup, Select, MenuButton, Combobox, and TypeaheadSearch.

I forgot to link the release commit patch (now merged) to this task.
The release commit: https://gerrit.wikimedia.org/r/c/oojs/ui/+/1073805

The Menu's scrolling behavior was not working because the maybeScrollIntoView() function had an early return, preventing the scroll from occurring. The early return prevented scrolling when certain conditions like visibleItemLimit or highlightedMenuItemIndex were missing. Refer to: https://gerrit.wikimedia.org/r/plugins/gitiles/design/codex/+/refs/heads/main/packages/codex/src/components/menu/Menu.vue#758

In T363515#10137969, @AnneT wrote:

Ok, if the other components already have the blue border and red background, it seems like we should make the Radio match. Thanks @bmartinezcalvo!

@lwatson I found a way to achieve this for the checked-error-focus state of the radio:

&:checked {
    &:focus:not( &:active ) + .cdx-radio__icon {
        border-width: @border-width-base;

        &::before {
            border-color: @border-color-destructive;
            border-width: 4px; // There's no token for this; we'd need a component-level one
            top: @spacing-12;
            right: @spacing-12;
            bottom: @spacing-12;
            left: @spacing-12;
        }
    }
}

Please try this out and make sure it doesn't interfere with any of the other states!

@AnneT Awesome, we have so many options. Thanks a lot!

In T372433#10138883, @PatchDemoBot wrote:

Test wiki created on Patch demo by LWatson-WMF using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/58940e229e/wiki/Main Page

In T371998#10138155, @gerritbot wrote:

Change #1072254 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] docs: reorder MenuItem's config demo props

https://gerrit.wikimedia.org/r/1072254

@bmartinezcalvo Another option: Anne suggested the checked-error-focus state as a red-colored version of the checked-default-focus state. (Preview: https://1024536--wikimedia-codex.netlify.app/components/demos/radio.html#configurable)

Hey @Nunya, thanks for flagging that! The patch in review includes updates to the Codex docs based on the changes we need to make to MenuItem, so I can see how that could have caused some confusion.

Hey @Nunya have you had a chance to work on this? If not I'll pick this up tomorrow

In T363515#10110557, @bmartinezcalvo wrote:

@lwatson the error states in both Radio and Combobox and Lookup demos look good. So I'm moving the task to Code Review.

My only observation is that, when selecting a value in either Combobox or Lookup configurable demos, the error should disappear. But I don't think this is a blocker for merging the patch.

@CCiufo-WMF When we pull this task into a sprint, the open patch is ready for code review. I've completed the acceptance criteria.

@Volker_E Hey, I noticed you have an open patch for Radio so I'll work on Combobox and Lookup if that's okay with you.

I removed this item from the acceptance criteria because ChipInput does not have CSS-only examples.

Thanks for filing this bug and working on a solution. @Dogu patch helped me discover that the problem originated in Codex. This patch resolves the Codex bug by setting the font-size and font-family to inherit. You can expect these changes in today's Codex release.

ok, great - let me know when it's ready for review!

Thanks @Dogu, these are the steps I took before: I downloaded your patch with git review -d 1054002, logged in as "Admin", and noticed the Codex class names but not the Codex styles.

Hey @Dogu (or anyone) is there a special configuration to add to the LocalSettings.php to display the Codex styles?