[go: up one dir, main page]

Page MenuHomePhabricator

cmassaro (Cory Massaro)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 5 2021, 4:31 PM (194 w, 4 d)
Availability
Available
LDAP User
Cory Massaro
MediaWiki User
CMassaro (WMF) [ Global Accounts ]

Recent Activity

Tue, Sep 24

cmassaro claimed T375493: Add More Tests for Built-In Wikidata Item Equivalence.
Tue, Sep 24, 12:15 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator
cmassaro created T375493: Add More Tests for Built-In Wikidata Item Equivalence.
Tue, Sep 24, 12:15 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator

Mon, Sep 23

cmassaro added a project to T375439: Future-Proof MSW Tests against Regressions due to MSW Version: Abstract Wikipedia Fix-It tasks.
Mon, Sep 23, 8:20 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro created T375439: Future-Proof MSW Tests against Regressions due to MSW Version.
Mon, Sep 23, 8:20 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team

Fri, Sep 20

cmassaro added a comment to T373992: The generic Type of a Typed list is not always evaluated in Expected results?.

I see. There are a few things going on here.

Fri, Sep 20, 4:05 PM · Abstract Wikipedia team
cmassaro added a comment to T373992: The generic Type of a Typed list is not always evaluated in Expected results?.

Hmm. I think the problem here is the use of Z17464, which is defined for references. The fully-resolved types that are returned are Z4/Types, not Z9/References. It seems to be that there should be a Type equality function for this case. Am I missing something?

Fri, Sep 20, 3:11 PM · Abstract Wikipedia team

Tue, Sep 17

cmassaro created T374985: Aggressively Rate-Limit Calls to Wikidata.
Tue, Sep 17, 4:47 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-orchestrator

Mon, Sep 16

cmassaro claimed T373992: The generic Type of a Typed list is not always evaluated in Expected results?.
Mon, Sep 16, 12:45 PM · Abstract Wikipedia team

Fri, Sep 6

cmassaro claimed T374257: Tests in test/features/v1/orchestrateTest.js Should Do Something.
Fri, Sep 6, 3:37 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro created T374257: Tests in test/features/v1/orchestrateTest.js Should Do Something.
Fri, Sep 6, 3:37 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator

Thu, Sep 5

cmassaro added a comment to T369552: Analyze Performance Numbers and Discuss an Appropriate Spike.

New Numbers:

Thu, Sep 5, 1:00 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda, function-schemata, function-evaluator, function-orchestrator

Aug 27 2024

cmassaro placed T368320: Renderers cannot render non-concrete values, e.g. values created through compositions or other function calls up for grabs.
Aug 27 2024, 3:32 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda Front-end
cmassaro moved T372938: Change evaluationDuration to Include Time Spent Queuing from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Aug 27 2024, 3:31 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro moved T372938: Change evaluationDuration to Include Time Spent Queuing from To triage to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Aug 27 2024, 3:31 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator

Aug 22 2024

cmassaro created T373110: Test Environment Variable Defaults and Configurability.
Aug 22 2024, 1:38 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a comment to T372938: Change evaluationDuration to Include Time Spent Queuing.

We do have other means of measuring this more granular time spans, but we don't expose them in the UI. It would be useful to exclude wait times when determining the fastest implementation.

Aug 22 2024, 1:35 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro added a comment to T372938: Change evaluationDuration to Include Time Spent Queuing.

We won't see them yet, no. Conceptually, there are three different interesting time spans in the evaluator:

Aug 22 2024, 1:35 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator

Aug 21 2024

cmassaro added a project to T373030: Create Abstraction for the Orchestrator in Order to Clean up Timeouts: Abstract Wikipedia Fix-It tasks.
Aug 21 2024, 3:21 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro updated the task description for T373030: Create Abstraction for the Orchestrator in Order to Clean up Timeouts.
Aug 21 2024, 3:08 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro created T373030: Create Abstraction for the Orchestrator in Order to Clean up Timeouts.
Aug 21 2024, 3:03 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team

Aug 20 2024

cmassaro claimed T372938: Change evaluationDuration to Include Time Spent Queuing.
Aug 20 2024, 8:19 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro created T372938: Change evaluationDuration to Include Time Spent Queuing.
Aug 20 2024, 8:18 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-evaluator
cmassaro claimed T372756: javascript - enabled wasmedge exceeds gas limit test is flaky.
Aug 20 2024, 2:16 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team

Aug 19 2024

cmassaro updated subscribers of T369552: Analyze Performance Numbers and Discuss an Appropriate Spike.

Thanks to @DMartin-WMF for the numbers:

Aug 19 2024, 7:18 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro created T372765: Increase Resources for function-evaluator CI.
Aug 19 2024, 1:24 PM · Abstract Wikipedia team (25Q2 (Oct–Dec)), function-evaluator
cmassaro added a parent task for T372721: Test What Happens When wasmedge Limits Are Very Low: T372756: javascript - enabled wasmedge exceeds gas limit test is flaky.
Aug 19 2024, 12:25 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro added a subtask for T372756: javascript - enabled wasmedge exceeds gas limit test is flaky: T372721: Test What Happens When wasmedge Limits Are Very Low.
Aug 19 2024, 12:25 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro created T372756: javascript - enabled wasmedge exceeds gas limit test is flaky.
Aug 19 2024, 12:25 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team
cmassaro placed T369173: Details of function calls sometimes in code up for grabs.
Aug 19 2024, 12:25 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-schemata, function-orchestrator, Wikifunctions
cmassaro created T372721: Test What Happens When wasmedge Limits Are Very Low.
Aug 19 2024, 2:09 AM · Abstract Wikipedia Fix-It tasks, function-evaluator, Abstract Wikipedia team

Aug 16 2024

cmassaro created T372665: Ensure that Executor.immaHeadOut Is Called Unconditionally.
Aug 16 2024, 6:56 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator

Aug 5 2024

cmassaro added a parent task for T371837: Performance Spike: Create a Pool of "Hot" Executor Processes to Eliminate wasmedge Startup Costs: T367933: [25Q1] Performance improvements.
Aug 5 2024, 4:57 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, function-evaluator
cmassaro added a subtask for T367933: [25Q1] Performance improvements: T371837: Performance Spike: Create a Pool of "Hot" Executor Processes to Eliminate wasmedge Startup Costs.
Aug 5 2024, 4:57 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro created T371837: Performance Spike: Create a Pool of "Hot" Executor Processes to Eliminate wasmedge Startup Costs.
Aug 5 2024, 4:55 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, function-evaluator
cmassaro renamed T371835: Test That function-schemata's Mutex Implementation Works in QuickJS from Test That Mutex Works in QuickJS to Test That function-schemata's Mutex Implementation Works in QuickJS.
Aug 5 2024, 4:44 PM · function-schemata, function-evaluator, Abstract Wikipedia team
cmassaro added a subtask for T361361: Protect Stream Access with a Mutex and Unique ID in Executors: T371835: Test That function-schemata's Mutex Implementation Works in QuickJS.
Aug 5 2024, 4:44 PM · Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, function-evaluator
cmassaro added a parent task for T371835: Test That function-schemata's Mutex Implementation Works in QuickJS: T361361: Protect Stream Access with a Mutex and Unique ID in Executors.
Aug 5 2024, 4:44 PM · function-schemata, function-evaluator, Abstract Wikipedia team
cmassaro created T371836: Consider Using Atomics to Improve Mutexes in Node.
Aug 5 2024, 4:41 PM · Abstract Wikipedia Fix-It tasks, function-schemata, function-evaluator, Abstract Wikipedia team
cmassaro created T371835: Test That function-schemata's Mutex Implementation Works in QuickJS.
Aug 5 2024, 4:39 PM · function-schemata, function-evaluator, Abstract Wikipedia team

Aug 1 2024

cmassaro added a comment to T371572: Test ALL Workflows with Potentially Naughty Escape Sequences.

The above MR demonstrates that the evaluator can handle these escape sequences, and that they are interpreted correctly when injected into code with eval/exec (if they were not interpreted correctly, the regex matches would not have been correct).

Aug 1 2024, 4:29 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a comment to T371561: bug: cannot save python implementation with regex.

@Harej : Just to be clear that it's the same issue, what happens if you double-escape all the Unicode sequences (e.g., \\u200e)?

Aug 1 2024, 12:28 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))

Jul 31 2024

cmassaro removed a subtask for T371572: Test ALL Workflows with Potentially Naughty Escape Sequences: Unknown Object (Task).
Jul 31 2024, 11:51 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a subtask for T371572: Test ALL Workflows with Potentially Naughty Escape Sequences: Unknown Object (Task).
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a subtask for T371572: Test ALL Workflows with Potentially Naughty Escape Sequences: T371561: bug: cannot save python implementation with regex.
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a parent task for T371561: bug: cannot save python implementation with regex: T371572: Test ALL Workflows with Potentially Naughty Escape Sequences.
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro created T371572: Test ALL Workflows with Potentially Naughty Escape Sequences.
Jul 31 2024, 11:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, WikiLambda Front-end, WikiLambda, function-schemata, function-evaluator, function-orchestrator
cmassaro added a comment to T371561: bug: cannot save python implementation with regex.

I also see that this works if you double-escape, so the regex can be r'\\d'. This is still not great, but it should work for now.

Jul 31 2024, 11:40 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro added a comment to T371561: bug: cannot save python implementation with regex.

I've tracked this down to includes/ZObjectContent.php. It is true that the \d escape sequence is illegal inside a JSON string, so FormatJson rightly complains about it.

Jul 31 2024, 11:28 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro added a comment to T371561: bug: cannot save python implementation with regex.

Hm. So, I have been able to repro. The \ds are the culprit.

Jul 31 2024, 11:11 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro added a comment to T371484: using built-in http.client in python implementations does not work.

I would be happy to continue this discussion in some venue in order to determine what the need is; if that venue is here, I'm fine with this task remaining open. To be clear, though, this isn't a bug: the system is working as intended.

Jul 31 2024, 11:01 PM · Abstract Wikipedia team
cmassaro moved T359439: Consider Re-Enabling Base WASMedge Image Stages from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 31 2024, 4:11 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro moved T359439: Consider Re-Enabling Base WASMedge Image Stages from Incoming to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 31 2024, 4:08 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro added a comment to T343593: Unexpected "wrong content type" error when running test case despite identical expected and actual outputs.

I believe this is due to a mismatch in how different parts of the system treat these strings. Some parts of the system treat any capital letter followed by digits (/[A-Z][1-9][0-9]*/) as Z9/Reference and any other string as Z6/String; other parts of the system are stricter, and only treat strings matching /[QZ][1-9][0-9]*/ (or possibly only /Z[1-9][0-9]*/) as Z9/References. None of these regexes is correct: it should be /[A-JL-Z][1-9][0-9]*/, since things like K1 can't ever be Z9/References.

Jul 31 2024, 3:27 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, Wikifunctions
cmassaro added a comment to T371484: using built-in http.client in python implementations does not work.

I'd like to add a little more context here.

Jul 31 2024, 3:20 PM · Abstract Wikipedia team
cmassaro moved T348352: setMetadataValue Should Not Silently Ignore Degenerate ZObjects from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 31 2024, 1:40 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-schemata
cmassaro moved T348352: setMetadataValue Should Not Silently Ignore Degenerate ZObjects from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 31 2024, 1:39 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-schemata
cmassaro added a comment to T348352: setMetadataValue Should Not Silently Ignore Degenerate ZObjects.

Looking back at this, I don't think this is the right place to catch degenerate objects. Let's close as Rejected.

Jul 31 2024, 1:38 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-schemata

Jul 30 2024

cmassaro added a comment to T277914: Provide a more expansive test suite for the built-in functions in the orchestrator.

We have this weird corner case in the backend. {Z1K1: 'Z9', Z9K1: 'Z41'} should be treated as a Boolean, but if often is not; often, what the backend expects is

Jul 30 2024, 1:47 PM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro moved T355632: Investigate Better Ways to Kill/Timeout Subprocesses from No current plans / External to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 30 2024, 2:11 AM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro added a comment to T355632: Investigate Better Ways to Kill/Timeout Subprocesses.

Close as duplicate of T365515?

Jul 30 2024, 2:10 AM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro moved T355632: Investigate Better Ways to Kill/Timeout Subprocesses from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 30 2024, 2:10 AM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro added a comment to T368312: Debug function fails with "end of JSON input".

This seems to be working now!

Jul 30 2024, 1:59 AM · function-evaluator, Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro moved T368312: Debug function fails with "end of JSON input" from Bugs to investigate to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 30 2024, 1:59 AM · function-evaluator, Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro moved T328431: Encapsulate Shared Functionality between ZWrapper.create and ZWrapper.copy from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 30 2024, 1:59 AM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro moved T321103: Avoid Duplicating Serialization Work When Serializing a ZMap from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 30 2024, 1:59 AM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro moved T321103: Avoid Duplicating Serialization Work When Serializing a ZMap from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 30 2024, 1:59 AM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro moved T328431: Encapsulate Shared Functionality between ZWrapper.create and ZWrapper.copy from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 30 2024, 1:59 AM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator

Jul 29 2024

cmassaro moved T296679: Write Test Ensuring Z14s Are Resolved (but Not Compositions) from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 29 2024, 9:30 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro moved T296679: Write Test Ensuring Z14s Are Resolved (but Not Compositions) from Incoming to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 29 2024, 9:28 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro added a comment to T296679: Write Test Ensuring Z14s Are Resolved (but Not Compositions).

This test doesn't handle the Z18 case, but our scoping rules make that kind of hard :-/

Jul 29 2024, 9:23 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro created T371328: Allow Type Converters to Call Each Other.
Jul 29 2024, 8:53 PM · function-evaluator, function-orchestrator, Abstract Wikipedia team
cmassaro claimed T296679: Write Test Ensuring Z14s Are Resolved (but Not Compositions).
Jul 29 2024, 4:30 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro moved T347984: Create WASM-ed Python Executor in Its Own Subdirectory from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 29 2024, 4:03 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro moved T347984: Create WASM-ed Python Executor in Its Own Subdirectory from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 29 2024, 4:02 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro added a comment to T347984: Create WASM-ed Python Executor in Its Own Subdirectory.

I recommend closing as declined; this isn't necessary.

Jul 29 2024, 4:02 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro claimed T347984: Create WASM-ed Python Executor in Its Own Subdirectory.
Jul 29 2024, 4:01 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro added a comment to T304091: Eliminate Redundant Tests.

I think this is now fixed. We audited these during the big orchestrator test refactor.

Jul 29 2024, 4:01 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro moved T304091: Eliminate Redundant Tests from Incoming to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 29 2024, 4:00 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro moved T304091: Eliminate Redundant Tests from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.
Jul 29 2024, 4:00 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro claimed T304091: Eliminate Redundant Tests.
Jul 29 2024, 4:00 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro claimed T363714: javascript - debug Test Is Flaky.
Jul 29 2024, 3:53 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro claimed T321103: Avoid Duplicating Serialization Work When Serializing a ZMap.
Jul 29 2024, 3:10 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-evaluator
cmassaro claimed T328431: Encapsulate Shared Functionality between ZWrapper.create and ZWrapper.copy.
Jul 29 2024, 2:49 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Abstract Wikipedia Fix-It tasks, function-orchestrator
cmassaro claimed T367120: findTypeIdentity Function Is Broken.
Jul 29 2024, 2:18 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), Patch-For-Review, Abstract Wikipedia Fix-It tasks, function-schemata
cmassaro added a comment to T368320: Renderers cannot render non-concrete values, e.g. values created through compositions or other function calls.

It seems to me that in this case (showing the implementation composition), the string renderer shouldn't even come into play, unless the values are complete (there are no argument references).
Should we stop such cases from collapsing into the string renderer component and just stop that function call from running altogether?

Jul 29 2024, 2:10 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda Front-end
cmassaro added a comment to T368320: Renderers cannot render non-concrete values, e.g. values created through compositions or other function calls.

Alternatively: we might consider having parser/renderer functions operate over Z99s. Then the parser/renderer functions themselves can handle Z7, Z9, and/or Z18 literals however they want, since these "nonterminal" types will be represented faithfully inside the Z99.

Jul 29 2024, 2:09 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda Front-end

Jul 25 2024

cmassaro updated subscribers of T368320: Renderers cannot render non-concrete values, e.g. values created through compositions or other function calls.

Thanks @gengh for pointing me to the call being sent to the orchestrator.

Jul 25 2024, 3:44 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda Front-end
cmassaro claimed T368320: Renderers cannot render non-concrete values, e.g. values created through compositions or other function calls.
Jul 25 2024, 3:43 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), WikiLambda Front-end
cmassaro moved T358543: List equality throwing a Z564/Invalid executor response for test using Z872/Filter from Bugs to investigate to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 25 2024, 3:08 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator, function-evaluator, Wikifunctions
cmassaro added a comment to T358543: List equality throwing a Z564/Invalid executor response for test using Z872/Filter.

This is now passing on both of the linked tests. The error in the task description points to an executor error, and the empty string after it means that the executor just didn't return anything. Could have been something ephemeral like resource exhaustion or a timeout. Marking as "needs sign-off" for now.

Jul 25 2024, 3:08 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator, function-evaluator, Wikifunctions
cmassaro claimed T358543: List equality throwing a Z564/Invalid executor response for test using Z872/Filter.
Jul 25 2024, 3:04 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator, function-evaluator, Wikifunctions

Jul 24 2024

cmassaro added a project to T370773: Allow Timestamp to Be Overridden in LoggerWrapper: Abstract Wikipedia Fix-It tasks.
Jul 24 2024, 4:44 PM · Abstract Wikipedia Fix-It tasks, function-schemata, function-evaluator, Abstract Wikipedia team
cmassaro created T370894: Discuss with Releng: Don't Copy Build Artifacts between Blubber Steps.
Jul 24 2024, 3:27 PM · Abstract Wikipedia Fix-It tasks, function-evaluator, function-orchestrator, Abstract Wikipedia team

Jul 23 2024

cmassaro created T370773: Allow Timestamp to Be Overridden in LoggerWrapper.
Jul 23 2024, 1:54 PM · Abstract Wikipedia Fix-It tasks, function-schemata, function-evaluator, Abstract Wikipedia team

Jul 18 2024

cmassaro moved T369956: Add logging data when db fetch in orchestrator from Ready, Features to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 18 2024, 7:47 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro created T370472: Testing: MediaWikiStub.getZId Should Not Throw Error.
Jul 18 2024, 7:43 PM · Abstract Wikipedia Fix-It tasks, function-orchestrator, Abstract Wikipedia team
cmassaro moved T369653: Strings Get Too Long When Creating ZObjectKeys from In Progress to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 18 2024, 5:49 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-schemata, function-orchestrator
cmassaro claimed T369956: Add logging data when db fetch in orchestrator.
Jul 18 2024, 4:24 PM · Abstract Wikipedia team (25Q1 (Jul–Sep))
cmassaro moved T369653: Strings Get Too Long When Creating ZObjectKeys from Bugs to investigate to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 18 2024, 1:37 PM · Patch-For-Review, Abstract Wikipedia team (25Q1 (Jul–Sep)), function-schemata, function-orchestrator
cmassaro moved T369762: Implementations seem to be chosen at random from Bugs to investigate to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
Jul 18 2024, 1:37 PM · Abstract Wikipedia team (25Q1 (Jul–Sep)), function-orchestrator