Maniphest T375493

Add More Tests for Built-In Wikidata Item Equivalence
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Tue, Sep 24, 12:14 PM

Tags

Referenced Files

None

Subscribers

Description

Description

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

there should be tests with wrong-typed items;
there should be tests with corner cases (like a Wikidata item reference vs. an expanded Wikidata item)

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade orchestrator from 2024-08-13-135124 to 2024-09-24-145528	operations/deployment-charts	master	+5 -3

Customize query in gerrit

Event Timeline

cmassaro claimed this task.Tue, Sep 24, 12:14 PM

cmassaro created this task.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/235

Add tests for Wikidata item equality with type issues.

gengh merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/235

Add tests for Wikidata item equality with type issues.

Maintenance_bot removed a project: Patch-For-Review.Tue, Sep 24, 3:31 PM

Change #1075554 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-08-13-135124 to 2024-09-24-145528

https://gerrit.wikimedia.org/r/1075554

gerritbot added a project: Patch-For-Review.Wed, Sep 25, 12:52 PM

Jdforrester-WMF triaged this task as Medium priority.Wed, Sep 25, 4:51 PM

Jdforrester-WMF moved this task from To triage to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Wed, Sep 25, 4:53 PM

Change #1075554 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-08-13-135124 to 2024-09-24-145528

https://gerrit.wikimedia.org/r/1075554

Maintenance_bot removed a project: Patch-For-Review.Wed, Sep 25, 9:32 PM

Jdforrester-WMF closed this task as Resolved.Wed, Sep 25, 9:37 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.