I have created a separate ticket to write tests on T345747

https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/43

QA notes
Because of this change https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/28,

The documentation describes behavior as an array of behavior tags for an IP Address.

This is similar to T341605 which was declined because as per documentation we should only get a boolean for anonymous column.
see comment on this patch

@GMikesell-WMF as per the documentation here , anonymous should actually be a boolean, so we should not be expecting the data we got. I have created a ticket to update the column to a boolean T341880.
and I am going to proceed with closing this ticket.

LGTM! thanks

@dom_walden I didn't realise this can include false, I can move this back to in progress and create a separate patch. thank you.

This should be covered by this merge request https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/27
The schema has been updated to accept null on this merge request.
I will move this to along with T339359

As stated this happens when tunnels.type is not set, we could update the schema and make type and anonymous columns nullable.
Is it expected that some entries won't contain this data in production data? @STran

UserGroupManager::addUserToGroup is only called on the user set by this variable wgMassMessageAccountUsername. this can only be done by an admin and it is u likely that an admin can set this to a temporary username.

I think it valid that this ticket is also declined as per T326921#8534054
As Prevent LDAP Authentication from setting preferences for temporary accounts
was declined on the same grounds.

The call here is made by the script that is used to generate sample notifications
Class: documentation: GenerateSampleNotifications
A maintenance script that generates sample notifications for testing purposes.

Looks good to me. thanks

All calls on this seem to only be coming from tests(see code search link above).

@GMikesell-WMF This looks like may be the expected behaviour, I think for we will need to tick Apply block to logged-in users from this IP address for the block to affect temporary users as well?

PR found here https://github.com/wikimedia/mw-node-qunit/pull/31