tempUserBanner.js throws TypeError: mw.message(...).parseDom is not a function
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Tchanders
	Aug 15 2023, 2:25 PM

Description

Steps to reproduce:

Set config $wgAutoCreateTempUser['enabled'] = true; (and leave the other properties of that config as default)
Set config $wgResourceLoaderDebug = true;
Open developer tools in the browser
Log out
Edit an article
Observe that an error is encountered: TypeError: mw.message(...).parseDom is not a function

The mediawiki.tempUserBanner module should depend on the mediawiki.jqueryMsg module.

(Note that this doesn't actually impede temporary account creation.)

Details

	Subject	Repo	Branch	Lines +/-
	Specify dependency for mediawiki.tempUserBanner module	mediawiki/core	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned Here: rEIPI00ff9ffff127: Localisation updates from https://translatewiki.net.

Event Timeline

• Tchanders created this task.Aug 15 2023, 2:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 15 2023, 2:25 PM

Change 949055 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Specify dependency for mediawiki.tempUserBanner module

https://gerrit.wikimedia.org/r/949055

gerritbot added a project: Patch-For-Review.Aug 15 2023, 2:28 PM

• Tchanders added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).Aug 15 2023, 2:28 PM

• Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 18 2023, 11:41 AM

Change 949055 merged by jenkins-bot:

[mediawiki/core@master] Specify dependency for mediawiki.tempUserBanner module

https://gerrit.wikimedia.org/r/949055

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2023, 12:10 PM

@Tchanders I'm not sure why I'm getting those other errors with Chrome unlike the other browsers but it did remove the TypeError: mw.message(...).parseDom is not a function. I will move this to Done and let me know if I should create a ticket for Chrome if that's an issue. Thanks for your work!

Status: ✅ PASS
Environment: Local
OS: macOS Ventura
Browser: Chrome 115, Firefox 116, Safari 16.6
Device: MBP
Emulated Device:Windows 11 Edge from BrowserStack
Test Link:
http://localhost:8080/wiki/Dog

Patch tested on: 00ff9ffff127ef02f2055d7df98189a6012cc46d

Old Patch	Chrome 115	Firefox 116	Safari 16.6

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 8:02 PM

Pppery closed this task as Resolved.May 10 2024, 1:00 AM

tempUserBanner.js throws TypeError: mw.message(...).parseDom is not a functionClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

tempUserBanner.js throws TypeError: mw.message(...).parseDom is not a function
Closed, ResolvedPublic
Actions