[go: up one dir, main page]

Page MenuHomePhabricator

Check if message form is from an object type in Logger param
Closed, ResolvedPublic

Description

What/Why:
Once we deploy some new changes to function-schemata, we need to confirm whether or not we can see message param that are newly formatted in the orchestrator, the same way we can see them coming through from the evaluator.

The orchestrator logs log this way: logger.log( 'error', 'hey an error', {} ), but the evaluator logs, logger.log ( 'error', { message: 'hello an error' } ). The latter we do see in Logstash, as msg, message, and normalized_message, although they are only the incoming request ones, but the orchestrator logs, we do not. The way orchestrator forms the logs, we see the message in the dropdown under msg, but not as message at a high level OR normalized_message (which just gives us something completely dubious: %{message}).

How: observe [[ https://logstash.wikimedia.org/app/dashboards#/view/c1a91950-1b5c-11ee-ac22-318c372b3db7?_g=h@3141a11&_a=h@5154758 | our Logstash ]]once change is deployed.

sigh

If change is successful, adjust LoggerWrapper and/or tests; so that we are not putting assertions on string type param at all anymore.
I guess this decision is dependent on whether or not we want msg and message to show different info. We could have msg show more details than message, but that could be a fix-it task or nice-to-have and not necessarily within scope.

Event Timeline

ecarg updated the task description. (Show Details)
ecarg changed the task status from Open to In Progress.Jul 17 2024, 4:30 PM

Since putting the log messages into an object { message: 'asdfsadf' } is now confirmed to come through properly in LogStash, this task has been resolved