[go: up one dir, main page]

Page MenuHomePhabricator

TextArea: Add base and state styles
Closed, ResolvedPublic

Description

This task covers adding styles for the TextArea component for its base state and all other states.

Acceptance criteria

Styles are added and match the design spec for the following states:

  • Default
  • Hover
  • Focus
  • Filled (with input)
  • Disabled
  • Read-only
  • Error (a new prop called status will be required for this, see TextInput.vue)
  • Error focus (same as regular focus)
  • Error filled

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Restricted Application triaged this task as High priority. · View Herald TranscriptApr 11 2023, 3:46 PM

Change 908353 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] TextArea: Add base and state styles

https://gerrit.wikimedia.org/r/908353

Change 908353 merged by jenkins-bot:

[design/codex@main] TextArea: Add base and state styles

https://gerrit.wikimedia.org/r/908353

Change 911931 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] TextArea: Add error state styles

https://gerrit.wikimedia.org/r/911931

Change 911932 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v0.9.0 to v0.9.1

https://gerrit.wikimedia.org/r/911932

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/9a9f20a61d/w

Change 911932 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.9.0 to v0.9.1

https://gerrit.wikimedia.org/r/911932

Change 911931 merged by jenkins-bot:

[design/codex@main] TextArea: Add error state styles

https://gerrit.wikimedia.org/r/911931

AnneT updated the task description. (Show Details)

Since there's no configurable demo set up for TextArea yet, I think we can skip design review for now. Once the TextArea demos are built and we're getting ready to take TextArea out of WIP, we can make sure it goes through design review. Nice work, @lwatson!

Change 918598 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8333e57f25/w

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8333e57f25/w/

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9a9f20a61d/w/

Change 918598 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.9.1 to v0.10.0

https://gerrit.wikimedia.org/r/918598