[go: up one dir, main page]

Page MenuHomePhabricator

Upgrade Vue.js development version in web team extensions / skins
Closed, ResolvedPublic

Description

MediaWiki core is using Vue 3.2.23
We should update our development code to mirror this

https://codesearch.wmcloud.org/search/?q=%22vue%22%3A%20%222.&i=nope&files=package.json&excludeFiles=&repos=

Note: This should have no impact on production code, as far as I can tell, we only use this for TypeScript and Storybook. We'll need to fix any issues relating to the Vue 2 to Vue 3 compatibility layer where needed.

TODO

  • Vector
  • QuickSurveys

Notes

NearbyPages will be done as part of T302135.

Event Timeline

Jdlrobson triaged this task as Medium priority.Feb 11 2022, 5:17 PM
Jdlrobson renamed this task from Upgrade Vue.js version in web team extensions / skins to Upgrade Vue.js development version in web team extensions / skins.Feb 17 2022, 8:43 PM
Jdlrobson updated the task description. (Show Details)

Change 769524 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] QuickSurveys uses Codex instead of WVUI

https://gerrit.wikimedia.org/r/769524

Change 769813 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/NearbyPages@master] Upgrade Nearby to use Codex and Vue 3

https://gerrit.wikimedia.org/r/769813

Change 758961 had a related patch set uploaded (by Jdlrobson; author: Catrope):

[mediawiki/skins/Vector@master] [WIP] Proof of concept for Codex TypeaheadSearch instead of WVUI

https://gerrit.wikimedia.org/r/758961

@egardner @Catrope I've come to the conclusion that it's going to be too painful to convert WVUI to Vue 3, so I think switching WVUI+Vue 2 for Codex and Vue 3 at the same time is inevitable.

I've written the above 2 patches for QuickSurveys, Nearby and have modified the Vector patch you started against the latest version of Codex (I understand this is blocked on security review and the library is unstable).

What is the deployment plan and timeframe here for getting WVUI out of production.

@egardner @Catrope I've come to the conclusion that it's going to be too painful to convert WVUI to Vue 3, so I think switching WVUI+Vue 2 for Codex and Vue 3 at the same time is inevitable.

I looked into upgrading WVUI to Vue 3 last week and came to the same conclusion. The fact that the Vue 2 repo still makes extensive use of Typescript seems to really complicate things.

What is the deployment plan and timeframe here for getting WVUI out of production.

Deprecating WVUI is part of what we are calling the Codex "Beta" milestone: T302025. Right now we are doing an alpha test with Abstract Wikipedia (since their product is not live in production yet). This will give us the opportunity to get some "real world" feedback based on the needs of a WMF product team without actually shipping any code in production. Shipping Codex in production will also require the completion of a security review (T302772).

I think we'll be ready for the Beta stage of our roll-out (beginning with Typeahead and WVUI replacement) next quarter. @STHart may be able to give a better sense of when exactly this work can start.

@Jdlrobson after discussing with @Catrope it seems that we are close to being able to build QuickSurveys in Codex, since there are components available for Button, Checkbox, Icon, and TextInput. I created a subtask for a design spike to confirm requirements.

Change 758961 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Search: Use Codex and Vue 3 instead of WVUI and Vue 2.

https://gerrit.wikimedia.org/r/758961

Change 769524 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] QuickSurveys uses Codex instead of WVUI

https://gerrit.wikimedia.org/r/769524

Jdlrobson claimed this task.

I'm closing this task out as Nearby is not in production yet and we already have a dedicated task for T302135 (which we'll be doing in quarter 2).