[go: up one dir, main page]

Page MenuHomePhabricator

egardner (Eric Gardner)
Senior Software Engineer, Design Systems Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2019, 7:02 PM (296 w, 2 d)
Availability
Available
LDAP User
Eric Gardner
MediaWiki User
EGardner (WMF) [ Global Accounts ]

Recent Activity

Fri, Sep 27

egardner placed T375939: CodexPHP: Publish and list documentation up for grabs.
Fri, Sep 27, 9:08 PM · Epic, Design-System-Team, Codex
egardner updated the task description for T375939: CodexPHP: Publish and list documentation.
Fri, Sep 27, 9:07 PM · Epic, Design-System-Team, Codex
egardner created T375939: CodexPHP: Publish and list documentation.
Fri, Sep 27, 9:07 PM · Epic, Design-System-Team, Codex
egardner changed the status of T373940: Codex PHP: Create and configure a new repo, a subtask of T373708: [EPIC] Create a PHP library for Codex markup generation, from Open to In Progress.
Fri, Sep 27, 9:02 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner changed the status of T373940: Codex PHP: Create and configure a new repo from Open to In Progress.
Fri, Sep 27, 9:02 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner added a subtask for T373708: [EPIC] Create a PHP library for Codex markup generation: T375453: [Spike] Investigate fluent builder pattern for Codex PHP.
Fri, Sep 27, 9:02 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner added a parent task for T375453: [Spike] Investigate fluent builder pattern for Codex PHP: T373708: [EPIC] Create a PHP library for Codex markup generation.
Fri, Sep 27, 9:02 PM · Spike, Codex, Design-System-Team
egardner moved T373940: Codex PHP: Create and configure a new repo from In Progress to Code Review on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Fri, Sep 27, 6:28 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner closed T373939: Codex PHP: Review initial contribution, a subtask of T373708: [EPIC] Create a PHP library for Codex markup generation, as Resolved.
Fri, Sep 27, 6:28 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner closed T373939: Codex PHP: Review initial contribution as Resolved.
Fri, Sep 27, 6:28 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner updated the task description for T373939: Codex PHP: Review initial contribution.
Fri, Sep 27, 6:28 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner added a comment to T375453: [Spike] Investigate fluent builder pattern for Codex PHP.

We're going to proceed with the current approach (builders that return immutable widgets which can be further passed around, combined with a dedicated getHtml() method) and see how it works.

Fri, Sep 27, 6:24 PM · Spike, Codex, Design-System-Team

Thu, Sep 26

egardner moved T375698: LookupMultiselect: Introduce a WIP component from Code Review to Pending Release on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Thu, Sep 26, 9:44 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), Codex
egardner updated the task description for T375826: [Spike/Timebox] DST support for web app scaffolding & initial setup.
Thu, Sep 26, 9:42 PM · Codex, Design-System-Team, Scap, Epic, Release-Engineering-Team (Priority Backlog 📥)
egardner updated the task description for T375826: [Spike/Timebox] DST support for web app scaffolding & initial setup.
Thu, Sep 26, 9:41 PM · Codex, Design-System-Team, Scap, Epic, Release-Engineering-Team (Priority Backlog 📥)
egardner updated the task description for T375826: [Spike/Timebox] DST support for web app scaffolding & initial setup.
Thu, Sep 26, 9:41 PM · Codex, Design-System-Team, Scap, Epic, Release-Engineering-Team (Priority Backlog 📥)
egardner created T375826: [Spike/Timebox] DST support for web app scaffolding & initial setup.
Thu, Sep 26, 9:38 PM · Codex, Design-System-Team, Scap, Epic, Release-Engineering-Team (Priority Backlog 📥)
egardner added a comment to T375782: scap web interface: Create SpiderPig web UI.

A couple of initial thoughts/recommendations:

Thu, Sep 26, 5:55 PM · Design-System-Team (Design-System-Product-Roadmap), Codex, Scap, Epic, Release-Engineering-Team (Priority Backlog 📥)

Wed, Sep 25

egardner moved T374876: Multiblocks: provide feedback and code review from In Progress to Code Review on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Wed, Sep 25, 9:50 PM · User-ItamarWMDE, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), Codex

Tue, Sep 24

egardner added a comment to T334986: [Proposal] Create a new "codex-mw" package for shared MediaWiki-specific components.

I think for the DST side I can say that, if we went in this direction, we'd want to have at least one or two non-DST engineers involved as maintainers to make it clear that this was a shared responsibility. Ideally folks from a few different teams (including DST) would have a hand in this codebase.

Tue, Sep 24, 3:57 PM · Front-end-Standards-Group, Design-System-Team

Mon, Sep 23

egardner added a comment to T375181: Codex icons stopped getting inverted with Chrome Auto Dark Mode.

Thank you. Is there any CSS trick I can apply until then?

Mon, Sep 23, 9:54 PM · Design-System-Team, Browser-Support-Google-Chrome, Codex, Desktop Improvements (Vector 2022)
egardner added a comment to T373989: Link-based buttons get a border radius even when unwanted.

I've moved this to blocked because there is some uncertainty of whether this should be applied at the skin level or within Codex itself.

Mon, Sep 23, 9:22 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Codex, OOUI, VisualEditor, FY2023-24-WE 2.1 Typography and palette customizations, Regression
egardner claimed T374876: Multiblocks: provide feedback and code review.
Mon, Sep 23, 9:21 PM · User-ItamarWMDE, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), Codex
egardner moved T373989: Link-based buttons get a border radius even when unwanted from Code Review to Blocked ⛔ on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Mon, Sep 23, 9:16 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Codex, OOUI, VisualEditor, FY2023-24-WE 2.1 Typography and palette customizations, Regression
Restricted Application added a project to T374876: Multiblocks: provide feedback and code review: User-ItamarWMDE.

Hey @MusikAnimal – could you provide a little more context and information about what sort of input you are looking for from us? I can do a quick pass to look at your usage of Vue.js and Codex to look for coding conventions, best practices, etc. but if you are looking for anything more specific let us know.

A quick review to ensure we're not doing anything dumb with Vue/Codex would be great!

Mon, Sep 23, 9:15 PM · User-ItamarWMDE, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), Codex
egardner moved T374876: Multiblocks: provide feedback and code review from Committed to In Progress on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Mon, Sep 23, 9:15 PM · User-ItamarWMDE, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), Codex
egardner updated subscribers of T374876: Multiblocks: provide feedback and code review.

Hey @MusikAnimal – could you provide a little more context and information about what sort of input you are looking for from us? I can do a quick pass to look at your usage of Vue.js and Codex to look for coding conventions, best practices, etc. but if you are looking for anything more specific let us know.

Mon, Sep 23, 8:14 PM · User-ItamarWMDE, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), Codex
egardner renamed T373940: Codex PHP: Create and configure a new repo from Codex PHP: Enable PHP CI tasks in the Codex repo to Codex PHP: Create and configure a new repo.
Mon, Sep 23, 7:20 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner moved T373940: Codex PHP: Create and configure a new repo from Committed to In Progress on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Mon, Sep 23, 7:20 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner added a comment to T373708: [EPIC] Create a PHP library for Codex markup generation.

@Dogu would it make sense to have a build method to return the constructed object as well as a render method which 1) constructs the object and 2) returns the final HTML in a single method? Then we could provide a simple approach for convenience as well as a possibility to do more involved things (pass around a constructed component with all data before rendering) where necessary?

Mon, Sep 23, 7:14 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner added a comment to T373708: [EPIC] Create a PHP library for Codex markup generation.

I agree with @LucasWerkmeister, so after the discussion, I started a refactoring process again. I can finish this refactoring within this week and discuss it again. Anyway, refactoring doesn't change the API; on the contrary, it allows us to create more API approaches.

Mon, Sep 23, 5:28 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner closed T375181: Codex icons stopped getting inverted with Chrome Auto Dark Mode as Declined.

Hi @Bean49 – this is a Chrome bug; I've filed an upstream bug report here: https://issues.chromium.org/issues/369085363

Mon, Sep 23, 5:13 PM · Design-System-Team, Browser-Support-Google-Chrome, Codex, Desktop Improvements (Vector 2022)

Wed, Sep 18

egardner moved T309109: Add groups to Codex docs sidebar from Backlog to Needs Refinement on the Design-System-Team board.
Wed, Sep 18, 6:00 PM · Design, Design-System-Team, Documentation, Codex

Tue, Sep 17

egardner moved T374856: Release Codex v1.13.0 from Committed to In Progress on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Tue, Sep 17, 7:51 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner added a comment to T373989: Link-based buttons get a border radius even when unwanted.

I like the attribute selector solution, but would recommend we add it in Vector (and Minerva if applicable) where the mixin is applied rather than in the mixin itself. The additional specificity—the equivalent of adding a class—is not ideal, so I think we should only add it where it is needed: inside MediaWiki where there are many anchor elements styled as buttons. We don't recommend styling links as buttons, so I don't think it's worth the additional specificity to account for it in the mixin, which could be used outside of Vector/MW.

Tue, Sep 17, 4:41 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Codex, OOUI, VisualEditor, FY2023-24-WE 2.1 Typography and palette customizations, Regression
egardner moved T373989: Link-based buttons get a border radius even when unwanted from Committed to Code Review on the Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)) board.
Tue, Sep 17, 4:56 AM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Codex, OOUI, VisualEditor, FY2023-24-WE 2.1 Typography and palette customizations, Regression
egardner claimed T373989: Link-based buttons get a border radius even when unwanted.
Tue, Sep 17, 4:43 AM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Codex, OOUI, VisualEditor, FY2023-24-WE 2.1 Typography and palette customizations, Regression

Mon, Sep 16

egardner moved T365779: docs: Document CSS variables use in Codex usage documentation from Code Review to Pending Release on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Mon, Sep 16, 6:27 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Documentation, Codex
egardner moved T370493: Radio, Checkbox: CSS-only version of custom input from Code Review to Pending Release on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Mon, Sep 16, 6:26 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner added a comment to T373989: Link-based buttons get a border radius even when unwanted.

@Esanders @dchan I'd like to update the Codex link mixin (which gets applied by Vector and inadvertently targets OOUI link-buttons) to exlcude any elements with [role="button"].

Mon, Sep 16, 6:21 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Codex, OOUI, VisualEditor, FY2023-24-WE 2.1 Typography and palette customizations, Regression
egardner set the point value for T374873: Codex PHP: Define external i18n messages for the Intution Library to 2.
Mon, Sep 16, 5:02 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner created T374873: Codex PHP: Define external i18n messages for the Intution Library .
Mon, Sep 16, 5:02 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))

Thu, Sep 12

egardner moved T372928: Implement the redesign of the style guide color page on Codex docs site from Code Review to Pending Release on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Thu, Sep 12, 7:01 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner added a comment to T251790: Use Jest in MediaWiki CI to test Vue.js components and plugins.

Yes thank you all!

Should we do anything about coverage reports? It's be great to have them published on https://doc.wikimedia.org/cover/

I'm also working on the documentation. Please feel free to review/edit as you see fit! https://www.mediawiki.org/wiki/Jest

Thu, Sep 12, 2:30 AM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Community-Tech (Island Fox (Sept 9 - 20)), MediaWiki-Core-Tests, Design-Systems-team-20200324-20220422

Wed, Sep 11

egardner closed T251790: Use Jest in MediaWiki CI to test Vue.js components and plugins as Resolved.

We are finalizing language for RELEASE-NOTES but this task can be considered complete. Thanks to all the participants for helping to close out this 4+ year old task!

Wed, Sep 11, 10:34 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Community-Tech (Island Fox (Sept 9 - 20)), MediaWiki-Core-Tests, Design-Systems-team-20200324-20220422
egardner moved T374246: CdxLookup: update:selected event is triggered every time that the input value changes from Code Review to Pending Release on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Wed, Sep 11, 10:21 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
Jdlrobson awarded T251790: Use Jest in MediaWiki CI to test Vue.js components and plugins a Love token.
Wed, Sep 11, 9:52 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Community-Tech (Island Fox (Sept 9 - 20)), MediaWiki-Core-Tests, Design-Systems-team-20200324-20220422
egardner added a comment to T373940: Codex PHP: Create and configure a new repo.

Thanks to @Ladsgroup for shedding some light on our CI configuration process.

Wed, Sep 11, 7:36 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner added a comment to T373875: New default font size for logged out user causes some UI components to scale (VE, DiscussionTools, WikiEditor, ...).

@DLynch what do you call the pop-up widgets like "Edit Link" in VE? This was the element that was being rendered in #mw-teleport-target and being improperly sized right?

Wed, Sep 11, 6:53 PM · MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Design-System-Team, Editing-team (Kanban Board), GrowthExperiments, Regression, ContentTranslation, WikiEditor (2010), DiscussionTools, Growth-Team, FY2023-24-WE 2.1 Typography and palette customizations, VisualEditor
egardner moved T373940: Codex PHP: Create and configure a new repo from Committed to In Progress on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Wed, Sep 11, 6:34 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner claimed T373940: Codex PHP: Create and configure a new repo.
Wed, Sep 11, 6:34 PM · Patch-For-Review, Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner moved T373939: Codex PHP: Review initial contribution from In Progress to Code Review on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Wed, Sep 11, 6:24 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner added a comment to T373875: New default font size for logged out user causes some UI components to scale (VE, DiscussionTools, WikiEditor, ...).

I don't think there are upstream changes needed here. The fix is to not apply font scaling to interface components in the content area. Unless you plan to start scaling interface components?

Okay, I might be misunderstanding what happened here. You're right that the intention is not to scale the interface with the font size preference for now (that's open for discussion in T370549). I think there were still some concerns from DST around use of hardcoded font size values and mw-teleport-target styles. Maybe @egardner can provide some more info.

Wed, Sep 11, 6:13 PM · MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Design-System-Team, Editing-team (Kanban Board), GrowthExperiments, Regression, ContentTranslation, WikiEditor (2010), DiscussionTools, Growth-Team, FY2023-24-WE 2.1 Typography and palette customizations, VisualEditor
egardner added a comment to T251790: Use Jest in MediaWiki CI to test Vue.js components and plugins.

Thanks for resurrecting this task! So far all Vue code has lived in skins or extensions, but if we are going to put components into Core directly then we should have a test suite there as well.

Wed, Sep 11, 4:36 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Community-Tech (Island Fox (Sept 9 - 20)), MediaWiki-Core-Tests, Design-Systems-team-20200324-20220422

Mon, Sep 9

egardner added a comment to T373708: [EPIC] Create a PHP library for Codex markup generation.

We've fully transitioned to using Mustache templates for all components, replacing PHP-based markup generation entirely.

Mon, Sep 9, 11:44 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner moved T374402: TextInput: add support for native HTML validation API from Inbox to Needs Refinement on the Design-System-Team board.
Mon, Sep 9, 10:26 PM · Wikidata, User-ItamarWMDE, wmde-wikidata-tech, Codex, Design-System-Team
egardner created T374402: TextInput: add support for native HTML validation API.
Mon, Sep 9, 10:26 PM · Wikidata, User-ItamarWMDE, wmde-wikidata-tech, Codex, Design-System-Team
egardner moved T373872: Add support for native Constraint Validation API to form associated components from Needs Refinement to Triaging on the Design-System-Team board.
Mon, Sep 9, 9:57 PM · Wikidata, User-ItamarWMDE, Patch-For-Review, wmde-wikidata-tech, Codex, Design-System-Team
egardner moved T373872: Add support for native Constraint Validation API to form associated components from Triaging to Needs Refinement on the Design-System-Team board.
Mon, Sep 9, 9:55 PM · Wikidata, User-ItamarWMDE, Patch-For-Review, wmde-wikidata-tech, Codex, Design-System-Team
egardner added a comment to T373872: Add support for native Constraint Validation API to form associated components.

Hi @egardner, thanks for the prompt reply. The current use case is described and linked in the ticket itself. The idea is to not have to replicate logic that is already afforded to us by browsers and is part of the WHATWG standards. In particular, to be able to use constraint attributes on codex components and leverage the Constraint Validation API instead of fashion our own validation checks (or use 3rd party libraries). Each of the components can adhere to different constraints, of course, as described in the linked WHATWG HTML Standard: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constraints

Mon, Sep 9, 9:54 PM · Wikidata, User-ItamarWMDE, Patch-For-Review, wmde-wikidata-tech, Codex, Design-System-Team
egardner closed T373941: [Spike] Discuss Whether/How Codex form components should support the Constraint Validation API, a subtask of T373872: Add support for native Constraint Validation API to form associated components, as Resolved.
Mon, Sep 9, 9:51 PM · Wikidata, User-ItamarWMDE, Patch-For-Review, wmde-wikidata-tech, Codex, Design-System-Team
egardner closed T373941: [Spike] Discuss Whether/How Codex form components should support the Constraint Validation API as Resolved.
Mon, Sep 9, 9:51 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), wmde-wikidata-tech, Codex
egardner updated the task description for T373941: [Spike] Discuss Whether/How Codex form components should support the Constraint Validation API.
Mon, Sep 9, 9:51 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), wmde-wikidata-tech, Codex
egardner added a comment to T374389: [REQUEST] Assistance for proper implementation of Codex Dark Mode in Lexica.

Hi @Raisha_Abdillah and @HendryVarianto03 – thanks for reaching out and sorry that this feature has not been better documented yet. We developed the dark mode feature based on some work that was being done in the Vector skin, and we haven't fully fleshed-out the non-MediaWiki usage of this feature.

Mon, Sep 9, 9:39 PM · Patch-For-Review, Design-System-Team

Fri, Sep 6

egardner edited projects for T374246: CdxLookup: update:selected event is triggered every time that the input value changes, added: Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)); removed Design-System-Team.
Fri, Sep 6, 4:01 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex

Wed, Sep 4

egardner changed the status of T373939: Codex PHP: Review initial contribution, a subtask of T373708: [EPIC] Create a PHP library for Codex markup generation, from Open to In Progress.
Wed, Sep 4, 9:25 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner changed the status of T373939: Codex PHP: Review initial contribution from Open to In Progress.
Wed, Sep 4, 9:25 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner moved T373939: Codex PHP: Review initial contribution from Committed to In Progress on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Wed, Sep 4, 9:24 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27))
egardner closed T373899: Release Codex v1.12.0 as Resolved.
Wed, Sep 4, 9:07 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner updated the task description for T373899: Release Codex v1.12.0.
Wed, Sep 4, 9:07 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner updated the task description for T373899: Release Codex v1.12.0.
Wed, Sep 4, 9:03 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner closed T368022: MenuItem: improve the selection of menu items as Resolved.
Wed, Sep 4, 8:47 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Design, Codex
egardner closed T372420: Thumbnail placeholder icon styles are incorrect in Vector 2022 search as Resolved.
Wed, Sep 4, 8:47 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex, Desktop Improvements (Vector 2022), Web-Team-Backlog
egardner closed T370997: ChipInput: Add character counter mechanism as Resolved.
Wed, Sep 4, 8:47 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex
egardner closed T364441: ChipInput: Expose status message when Chip is added or removed to screen readers, a subtask of T355337: [EPIC] AFB Engagement, as Resolved.
Wed, Sep 4, 8:47 PM · Accessibility, Epic, Design-System-Team (Design-System-Product-Roadmap)
egardner closed T364441: ChipInput: Expose status message when Chip is added or removed to screen readers as Resolved.
Wed, Sep 4, 8:47 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex, Accessibility
egardner closed T366831: Table: Heading design improvements as Resolved.
Wed, Sep 4, 8:47 PM · Patch-For-Review, Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Design, Codex
egardner closed T367032: Figma spec template: test new version with one designer and update the contribution guidelines as Resolved.
Wed, Sep 4, 8:47 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex
egardner closed T362651: [Timebox] Lookup: Issues with props reactiveness as Resolved.
Wed, Sep 4, 8:47 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex
egardner closed T370504: [Timebox] CdxLookup with an initial value has unexpected behavior as Resolved.
Wed, Sep 4, 8:47 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex
egardner closed T363515: Include error state in Combobox, Lookup, and Radio components, a subtask of T362650: Lookup: address usability issues, as Resolved.
Wed, Sep 4, 8:47 PM · Design-System-Team (DST-Sprint-32 (2024-09-16 to 2024-09-27)), Design, Codex
egardner closed T363515: Include error state in Combobox, Lookup, and Radio components as Resolved.
Wed, Sep 4, 8:46 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner closed T372811: Discuss as a team how to approach PHP code generation, a subtask of T373708: [EPIC] Create a PHP library for Codex markup generation, as Resolved.
Wed, Sep 4, 8:46 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex
egardner closed T372811: Discuss as a team how to approach PHP code generation as Resolved.
Wed, Sep 4, 8:46 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex
egardner closed T372614: How can Codex bring proper RTL support to standalone Vue applications? as Resolved.
Wed, Sep 4, 8:46 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Vue.js, RTL, Codex, I18n
egardner added a comment to T372614: How can Codex bring proper RTL support to standalone Vue applications?.

Hey @simon04 – we've introduced a new CSS file, codex.style-bidi.css as of Codex v1.12.0. This file is not intended for use in MediaWiki but it could be loaded by a stand-alone app like yours if you want to support client-side direction switching.

Wed, Sep 4, 8:46 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Vue.js, RTL, Codex, I18n
egardner moved T372614: How can Codex bring proper RTL support to standalone Vue applications? from Code Review to Pending Release on the Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)) board.
Wed, Sep 4, 5:21 PM · Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Vue.js, RTL, Codex, I18n
egardner renamed T373899: Release Codex v1.12.0 from Release Codex v1.x.x to Release Codex v1.12.0.
Wed, Sep 4, 4:38 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner moved T373899: Release Codex v1.12.0 from Committed to In Progress on the Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)) board.
Wed, Sep 4, 4:38 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex

Tue, Sep 3

egardner moved T372811: Discuss as a team how to approach PHP code generation from Code Review to Pending Release on the Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)) board.
Tue, Sep 3, 10:53 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)), Codex
egardner moved T363515: Include error state in Combobox, Lookup, and Radio components from Code Review to Pending Release on the Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)) board.
Tue, Sep 3, 10:52 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner added a comment to T363515: Include error state in Combobox, Lookup, and Radio components.

I think a follow-up patch that makes these new demos a little more meaningful (for example, by including a status message that shows up when the components are in the "error" state) would be a good idea. But I agree that this is not blocking for now.

Tue, Sep 3, 10:51 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner added a comment to T371998: MenuItem: use check icon when multi-selection.

Hi @egardner, I would like to give this a shot. Can I go ahead and assign it to myself?

Tue, Sep 3, 10:07 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner claimed T373899: Release Codex v1.12.0.
Tue, Sep 3, 8:54 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), Codex
egardner moved T373941: [Spike] Discuss Whether/How Codex form components should support the Constraint Validation API from Inbox to DST-Sprint-31 (2024-09-03 to 2024-09-13) on the Design-System-Team board.
Tue, Sep 3, 8:54 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), wmde-wikidata-tech, Codex
egardner triaged T373941: [Spike] Discuss Whether/How Codex form components should support the Constraint Validation API as Medium priority.
Tue, Sep 3, 8:53 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), wmde-wikidata-tech, Codex
Restricted Application added a project to T373872: Add support for native Constraint Validation API to form associated components: User-ItamarWMDE.

Hi @ItamarWMDE, thanks for this task and the associated patches. I've filed T373941 to represent the fact that the DST engineering team will spend some time discussing and considering your suggestions over the next 1-2 weeks, and we'll get back to you.

Tue, Sep 3, 8:53 PM · Wikidata, User-ItamarWMDE, Patch-For-Review, wmde-wikidata-tech, Codex, Design-System-Team
egardner set the point value for T373941: [Spike] Discuss Whether/How Codex form components should support the Constraint Validation API to 2.
Tue, Sep 3, 8:49 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), wmde-wikidata-tech, Codex
egardner created T373941: [Spike] Discuss Whether/How Codex form components should support the Constraint Validation API.
Tue, Sep 3, 8:49 PM · Design-System-Team (DST-Sprint-31 (2024-09-03 to 2024-09-13)), wmde-wikidata-tech, Codex
egardner added a subtask for T373708: [EPIC] Create a PHP library for Codex markup generation: T373940: Codex PHP: Create and configure a new repo.
Tue, Sep 3, 8:37 PM · Epic, Design-System-Team (Design-System-Product-Roadmap), Codex