[go: up one dir, main page]

Page MenuHomePhabricator

iOS app does not show block messages
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. An editor is blocked with a message, e.g. "Disruptive editing. Please see your talk page"

Expected results

  1. The editor sees that they have been blocked from editing for "Disruptive editing. Please see your talk page", so they know how to get unblocked or what the problem is.

Actual results

  1. They only see "You have been blocked from editing." with no clarifications, block message, or ability to see more.

Environments observed

App version: 6.7.4
OS versions: iOS 14.4

Also see:

This is a serious issue, and makes it difficult to communicate with editors, especially those who have been blocked.

Designs

Figma link to designs

  • Block messages shows up on screen as a modal (with red exclamationmark.octagon.fill icon) alerting the editor that they are blocked and the reason they are blocked for.
  • Tapping 'OK' will dismiss the message.
  • Related task T201640, T169013
Example of an IP block
Blocked IP address.png (667×376 px, 55 KB)

Note for QA

As a part of this, please regression test page protection logic on our editor and article description editor, to be sure it still works as before. Our plan is to release blocked work, edit notices and abuse filter work before we pick up T313772.

Event Timeline

Confirmed for partial blocks as well.

Thanks for filing this @Proc.

@OTichonova , adding this for designs.

We want to make sure the full message is displayed using the appropriate iOS elements.

Engineers:
Check out the conversation for T276147 to avoid potential pitfalls and to see possible limitations https://phabricator.wikimedia.org/T276149#7144448.

Tsevener subscribed.
Aklapper changed the subtype of this task from "Task" to "Bug Report".Feb 17 2023, 8:21 AM
JTannerWMF claimed this task.

@Tsevener thanks for the patch! Does it support partial blocks as well?

Hi @EpicPupper! The app will now block the user on the editor with the custom block message located at https://{lang}.wikipedia.org/wiki/MediaWiki:Blockedtext, even for partial blocks. This should match Android's implementation of blocked messages. It was rather difficult to test blocks because we were limited to Test Wikipedia, so if you notice it isn't working as you expected, please file a bug task (or respond here) and we look into it. Thank you!