[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T164791

Add class mw-parser-output to Flow comment- or content- containing elements
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

This class was added to resolve T37247: content-holding <div> should only contain the page text to fix pending issues with TemplateStyles. For the styles added by TemplateStyles to be applied properly in Flow comments, those comments should be enclosed in an element with class mw-parser-output. Other parts of the Flow page should not be enclosed in this class.

If nothing else, chances are you can add it to the same div that already has class flow-post-content.

This should also be verified to be true when creating a Flow post; T164790: Add class mw-parser-output to VE's editing area may be relevant to that.

In addition to posts, should also include header/description and summary.

Details

SubjectRepoBranchLines +/-
Add mw-parser-output to summaries and board widgetmediawiki/extensions/Flowmaster+5 -5
Add mw-parser-output class to flow postsmediawiki/extensions/Flowmaster+10 -10
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
 ResolvedJdlrobsonT186627 Remove the MobileView API
 DeclinedNoneT173379 Remove mobileview API call for main page
 DuplicateNoneT172525 [EPIC] Deprecate MobileView API in MobileFrontend
 ResolvedJdlrobsonT32405 [EPIC] MobileFrontend extension should stop special-casing main page
 DuplicateNoneT138449 Throw warning when edits made to a main page which uses special casing
 DuplicateNoneT138622 Help community migrate away from legacy Main page special casing
 DeclinedNoneT125920 [EPIC] Future exciting reading web performance endeavours
 ResolvedJdlrobsonT131423 FOUC in section "Recently featured" on mobile Main Page
 DuplicateNoneT126137 FOUC for styles applied via MediaWiki:Mobile.css due to bottom-loading
 DuplicateNoneT130846 Hat-note FOUC on mobile skin
 OpenbwangT361737 [EPIC] With the current layout, some elements extend beyond the content area and overlap sticky page tools
 DuplicateovasilevaT66577 Large tables created by editors are not responsive
 ResolvedNoneT51440 MobileFrontend images shown double-sized in Retina desktop, iOS 7 beta
 OpenNoneT40848 Security: CSS positioning can be used to break out of the content area
 OpenNoneT37704 Drop support in wikitext for inline styles
 ResolvedTheDJT151170 Varying layouts for commons mobile main page
 DeclinedNoneT125257 Infoboxes should take the max. available width of the screen
 InvalidNoneT135857 Map points aligned to viewport on mobile
 OpenFeatureNoneT17075 Per book, category and/or template CSS and JavaScript
 InvalidNoneT109152 [EPIC] All templates on wiki should work in mobile
 ResolvedTheDJT94107 {{hat}} and similar templates on Wikipedia are invisible to mobile web view.
 ResolvedTheDJT118062 In the mobile frontend, in the list produced by Template:Notelist-ua, efn-ua footnotes appear with numeric labels instead of uppercase-alpha. They appear normal in the text, and in the desktop frontend.
 InvalidNoneT120238 Wrong display of certain English Wikipedia portal pages in mobile
 ResolvedIznoT127727 navigational sidebar on mobile, should float on wide screens.
 ResolvedTheDJT128095 Signpost is not readable on mobile devices
 OpenNoneT117950 Remove the need for `.noprint`
 ResolvedJdlrobsonT117951 Remove templaters' need for .nomobile and support authoring media queries for templates
 DeclinedNoneT66578 Migrate css rules in hacks.less into templates
 ResolvedTgrT133410 Deploy TemplateStyles to WMF production
 ResolvedEsandersT164791 Add class mw-parser-output to Flow comment- or content- containing elements
 ResolvedssastryT164792 Add class mw-parser-output to Parsoid's output

Event Timeline

Anomie created this task.May 8 2017, 8:12 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 8 2017, 8:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Anomie mentioned this in T37247: content-holding <div> should only contain the page text.May 8 2017, 8:15 PM
• Mattflaschen-WMF renamed this task from Add class mw-parser-output to Flow comment containing elements to Add class mw-parser-output to Flow comment- or content- containing elements.May 8 2017, 8:28 PM
• Mattflaschen-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed Collaboration-Team-Triage.
• Mattflaschen-WMF subscribed.

Should also include header/description and summary.

Jdforrester-WMF added a subtask: T164792: Add class mw-parser-output to Parsoid's output.May 8 2017, 8:36 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 9 2017, 8:35 PM
Anomie added a comment.May 10 2017, 3:06 PM

It may be that T164792: Add class mw-parser-output to Parsoid's output solves this.

ssastry closed subtask T164792: Add class mw-parser-output to Parsoid's output as Resolved.May 10 2017, 3:25 PM
Anomie added a comment.May 10 2017, 4:10 PM
In T164791#3251889, @Anomie wrote:

It may be that T164792: Add class mw-parser-output to Parsoid's output solves this.

Parsoid in Beta Labs is now outputting the class, but I'm not seeing it present in https://en.wikipedia.beta.wmflabs.org/wiki/Flow_test_talk:Foo even after adding a new comment just now.

Anomie added a parent task: T133410: Deploy TemplateStyles to WMF production.Jun 7 2017, 4:14 PM
dr0ptp4kt added subscribers: • jmatazzoni, • Nirzar, • JKatzWMF and 3 others.Jun 7 2017, 7:02 PM

@jmatazzoni TemplateStyles is coming to the beta cluster shortly. Would it be possible to get a patch into Flow along the lines in the Description shortly following it's introduction there?

I can't quite tell whether this task should block rollout to production, but it seems sensible to me that we would typically want to honor editor-provided template styles in case someone transcludes a template which as a corresponding template style in force.

CC @JKatzWMF @Nirzar @Pginer-WMF @Jdforrester-WMF

dr0ptp4kt added a subscriber: Tgr.Jun 7 2017, 8:03 PM
• Mattflaschen-WMF updated the task description. (Show Details)Jun 7 2017, 8:13 PM
• jmatazzoni added a subscriber: • Catrope.Jun 7 2017, 8:20 PM
In T164791#3329021, @dr0ptp4kt wrote:

@jmatazzoni TemplateStyles is coming to the beta cluster shortly. Would it be possible to get a patch into Flow along the lines in the Description shortly following it's introduction there?

Sounds good. Pinging @Catrope so he can assign someone.

• Mattflaschen-WMF added a comment.Jun 8 2017, 12:02 AM

This may be fine per T164792: Add class mw-parser-output to Parsoid's output, but I just wanted to note that the Flow UI uses the Parsoid DOM for user content. So the TemplateStyles will have to work with both DOMs to the extent they're still different.

Anomie added a comment.Jun 8 2017, 4:08 PM
In T164791#3330905, @Mattflaschen-WMF wrote:

This may be fine per T164792: Add class mw-parser-output to Parsoid's output,

It's not.

but I just wanted to note that the Flow UI uses the Parsoid DOM for user content. So the TemplateStyles will have to work with both DOMs to the extent they're still different.

The only thing TemplateStyles cares about is that the parser output is wrapped with a class mw-parser-output. Parsoid's output includes that class on the <body> tag since T164792, but it seems Flow doesn't keep the classes from that tag.

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 12 2017, 9:59 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 12 2017, 10:21 PM
Tgr mentioned this in T133410: Deploy TemplateStyles to WMF production.Jul 13 2017, 3:00 PM
Esanders subscribed.Jul 17 2017, 5:09 PM

This should also be verified to be true when creating a Flow post; T164790: Add class mw-parser-output to VE's editing area may be relevant to that.

The fix to T164790 also fixes the Flow VE instance because it inherits from ve.init.mw.Target.

gerritbot subscribed.Jul 17 2017, 5:17 PM

Change 365656 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Add mw-parser-output class to flow posts

https://gerrit.wikimedia.org/r/365656

gerritbot added a project: Patch-For-Review.Jul 17 2017, 5:17 PM
gerritbot added a comment.Jul 17 2017, 7:24 PM

Change 365656 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add mw-parser-output class to flow posts

https://gerrit.wikimedia.org/r/365656

Jdforrester-WMF assigned this task to Esanders.Jul 17 2017, 7:28 PM
Jdforrester-WMF moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jdforrester-WMF edited projects, added VisualEditor; removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Anomie added a comment.Jul 17 2017, 7:52 PM

I note https://gerrit.wikimedia.org/r/365656 seems to have missed the Flow page header/description and topic summary fields.

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 17 2017, 8:01 PM
Etonkovidova subscribed.EditedJul 17 2017, 10:43 PM

@Catrope , @Esanders
Checked in betalabs; as @Anomie commented: "flow-topic-summary-content" and "flow-component flow-board-page mw-content-ltr" do not have "mw-parser-output".

Etonkovidova moved this task from QA Review to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 17 2017, 10:45 PM
Anomie mentioned this in T168808: Find two suitable wikis to talk to template editors about TemplateStyles.Jul 18 2017, 2:29 PM
Trizek-WMF subscribed.Jul 19 2017, 1:52 PM
gerritbot added a comment.Jul 20 2017, 3:24 PM

Change 366574 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Flow@master] Add mw-parser-output to summaries and board widget

https://gerrit.wikimedia.org/r/366574

gerritbot added a project: Patch-For-Review.Jul 20 2017, 3:24 PM
gerritbot added a comment.Jul 20 2017, 6:08 PM

Change 366574 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Add mw-parser-output to summaries and board widget

https://gerrit.wikimedia.org/r/366574

Anomie added a comment.Jul 20 2017, 6:19 PM

Looks good on https://en.wikipedia.beta.wmflabs.org/wiki/Flow_test_talk:Foo

Jdforrester-WMF moved this task from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 20 2017, 6:20 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)); removed MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 20 2017, 7:00 PM
Etonkovidova added a comment.Jul 20 2017, 10:59 PM

Checked in betalabs mw-parser-output is added:

<div class="flow-ui-boardDescriptionWidget-content mw-parser-output"

<div class="flow-topic-summary-content mw-parser-output">

Etonkovidova closed this task as Resolved.Jul 20 2017, 10:59 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 20 2017, 10:59 PM
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 20 2017, 11:01 PM
• ggellerman moved this task from Backlog to Done on the TemplateStyles board.Nov 21 2017, 7:15 PM
Aklapper removed subscribers: • Nirzar, • jmatazzoni, • Mattflaschen-WMF, Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits