[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T134735

[Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases
Closed, ResolvedPublic
Actions

Description

This is an issue mostly in tests, but also in some production code, e.g. search handler hooks, history actions and so on. Code gets an Entity(Document) and calls getFingerprint without checking if the entity supports this.

Patch-For-Review:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 DuplicateNoneT66288 basic support for structured data on mediawiki files
 InvalidLydia_PintscherT76012 make use of new entity type for multimedia / structured data of media files
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 OpenNoneT67626 [Epic] Support for queries on-wiki (automated list generation)
 ResolvedAddshoreT76019 [Story] Support new types of Entities in Wikibase Client
 ResolvedthiemowmdeT135650 [Task] Migrate PropertySuggester away from assuming all entities are numeric
 ResolvedAddshoreT75496 [Epic] Support new types of Entities in Wikibase Repository
 ResolvedthiemowmdeT134735 [Task] Do not assume all entity types have fingerprints/labels/descriptions/aliases
 ResolvedthiemowmdeT135598 [Task] Do not use Fingerprint in HistoryEntityAction
 ResolvedthiemowmdeT150084 EntityParserOutputGenerator requires entities implement LabelsProvider and DescriptionProvider

Event Timeline

thiemowmde created this task.May 9 2016, 9:31 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptMay 9 2016, 9:31 AM
gerritbot subscribed.May 9 2016, 9:31 AM

Change 287580 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make use of Label/DescriptionProvider interfaces in history/search

https://gerrit.wikimedia.org/r/287580

gerritbot added a project: Patch-For-Review.May 9 2016, 9:31 AM
• adrianheine added a comment.May 9 2016, 9:33 AM

Can you create a subtask for each change you're doing on this thing? I'd call this tracking, not task, too.

Ricordisamoa subscribed.May 9 2016, 10:09 AM
Addshore subscribed.May 11 2016, 2:16 PM
In T134735#2275304, @adrianheine wrote:

Can you create a subtask for each change you're doing on this thing? I'd call this tracking, not task, too.

I imagine there are maaany places to touch for this :O

• adrianheine created subtask T135598: [Task] Do not use Fingerprint in HistoryEntityAction.May 18 2016, 9:30 AM
gerritbot added a comment.May 18 2016, 6:45 PM

Change 287580 merged by jenkins-bot:
Make use of Label/DescriptionProvider interfaces in history/search

https://gerrit.wikimedia.org/r/287580

• adrianheine closed subtask T135598: [Task] Do not use Fingerprint in HistoryEntityAction as Resolved.May 18 2016, 7:53 PM
gerritbot added a comment.May 24 2016, 1:52 PM

Change 290461 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make terms table compatible with MediaInfo

https://gerrit.wikimedia.org/r/290461

gerritbot added a comment.May 26 2016, 9:15 AM

Change 290900 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Runtime optimizations and more narrow interfaces in TermSqlIndex

https://gerrit.wikimedia.org/r/290900

gerritbot added a comment.May 27 2016, 12:56 PM

Change 290900 merged by jenkins-bot:
Runtime optimizations and more narrow interfaces in TermSqlIndex

https://gerrit.wikimedia.org/r/290900

gerritbot added a comment.May 30 2016, 5:47 PM

Change 290461 merged by jenkins-bot:
Make terms table compatible with MediaInfo

https://gerrit.wikimedia.org/r/290461

gerritbot added a comment.Feb 1 2017, 5:01 PM

Change 335463 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused interface from LabelUniquenessValidator

https://gerrit.wikimedia.org/r/335463

gerritbot added a comment.Feb 1 2017, 5:06 PM

Change 335464 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace unused CompositeFingerprintValidator with null implementation

https://gerrit.wikimedia.org/r/335464

thiemowmde claimed this task.Feb 1 2017, 5:06 PM
thiemowmde added a project: Wikidata-Former-Sprint-Board.
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Feb 2 2017, 7:33 AM

Change 335614 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove Fingerprint from FingerprintValidator interface

https://gerrit.wikimedia.org/r/335614

gerritbot added a comment.Feb 2 2017, 7:40 AM

Change 335615 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove Fingerprint interface from label & description ChangeOps

https://gerrit.wikimedia.org/r/335615

gerritbot added a comment.Feb 2 2017, 8:20 AM

Change 335617 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Simplify TermValidatorFactoryTest setup to not use Fingerprint

https://gerrit.wikimedia.org/r/335617

gerritbot added a comment.Feb 9 2017, 4:09 PM

Change 335463 merged by jenkins-bot:
Remove unused interface from LabelUniquenessValidator

https://gerrit.wikimedia.org/r/335463

gerritbot added a comment.Feb 9 2017, 4:15 PM

Change 335464 merged by jenkins-bot:
Replace unused CompositeFingerprintValidator with null implementation

https://gerrit.wikimedia.org/r/335464

gerritbot added a comment.Feb 9 2017, 4:15 PM

Change 335614 merged by jenkins-bot:
Remove Fingerprint from FingerprintValidator interface

https://gerrit.wikimedia.org/r/335614

gerritbot added a comment.Feb 10 2017, 12:35 PM

Change 335615 merged by jenkins-bot:
Remove Fingerprint interface from label & description ChangeOps

https://gerrit.wikimedia.org/r/335615

gerritbot added a comment.Feb 13 2017, 4:30 PM

Change 335617 merged by jenkins-bot:
Simplify TermValidatorFactoryTest setup to not use Fingerprint

https://gerrit.wikimedia.org/r/335617

gerritbot added a comment.Feb 15 2017, 2:26 PM

Change 337849 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix TermView components assuming all entities have labels/descriptions

https://gerrit.wikimedia.org/r/337849

thiemowmde moved this task from incoming to in progress on the Wikidata board.Feb 15 2017, 2:31 PM
thiemowmde added a subscriber: • Aleksey_WMDE.
gerritbot added a comment.Feb 26 2017, 1:10 AM

Change 339912 had a related patch set uploaded (by Ladsgroup):
Remove Fingerprint from the backend

https://gerrit.wikimedia.org/r/339912

Ladsgroup mentioned this in rEWLEac489dd790af: Remove Fingerprint from the backend.Feb 26 2017, 1:11 AM
thiemowmde added a comment.Feb 26 2017, 11:18 AM

I just checked again (as I already did dozens of times in the pasts months) and found that the biggest remaining issues are:

  • https://gerrit.wikimedia.org/r/337849 not merged after almost 2 weeks.
  • EntityRetrievingTermLookup still binds against FingerprintProvider instead of individual Labels/Descriptions/AliasesProvider.
thiemowmde updated the task description. (Show Details)Feb 26 2017, 11:23 AM
gerritbot added a comment.Feb 26 2017, 11:25 AM

Change 339912 merged by jenkins-bot:
Remove Fingerprint from the backend

https://gerrit.wikimedia.org/r/339912

thiemowmde updated the task description. (Show Details)Feb 27 2017, 9:07 AM
gerritbot added a comment.Feb 27 2017, 3:54 PM

Change 340135 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove unused code from TermView components and tests

https://gerrit.wikimedia.org/r/340135

gerritbot added a comment.Feb 27 2017, 3:54 PM

Change 337849 merged by jenkins-bot:
Fix TermView components assuming all entities have labels/descriptions

https://gerrit.wikimedia.org/r/337849

gerritbot added a comment.Feb 28 2017, 9:53 AM

Change 340135 merged by jenkins-bot:
Remove unused code from TermView components and tests

https://gerrit.wikimedia.org/r/340135

thiemowmde closed this task as Resolved.Feb 28 2017, 4:30 PM
thiemowmde removed a project: Patch-For-Review.
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
thiemowmde mentioned this in T150084: EntityParserOutputGenerator requires entities implement LabelsProvider and DescriptionProvider.Mar 20 2017, 4:56 PM
thiemowmde added a subtask: T150084: EntityParserOutputGenerator requires entities implement LabelsProvider and DescriptionProvider.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits