docs: add note about webtransport only supporting dial #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a note at the top of the WebTransport `README.md` to remind people of the fact that currently, the WebTransport implementation in js-libp2p only supports dialing out to other nodes and does not actually support listening for incoming dials because js-libp2p depends on Node JS and QUIC support has not landed in Node JS yet. Related: libp2p#2371
|
@achingbrain Re-created this pr according to your instructions. |
achingbrain
reviewed
Feb 19, 2024
achingbrain
approved these changes
Feb 19, 2024
|
Thanks! |
This was referenced Feb 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
docs: add note about webtransport only supporting dial
Description
This adds a note at the top of the WebTransport
README.mdto remind people of the fact that currently, the WebTransport implementation in js-libp2p only supports dialing out to other nodes and does not actually support listening for incoming dials because js-libp2p depends on Node JS and QUIC support has not landed in Node JS yet.Related: #2371
Change checklist