[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@libp2p/webtransport Correct multiaddr format #2371

Closed
sachaw opened this issue Jan 24, 2024 · 4 comments
Closed

@libp2p/webtransport Correct multiaddr format #2371

sachaw opened this issue Jan 24, 2024 · 4 comments
Labels
kind/support A question or request for support

Comments

@sachaw
Copy link
sachaw commented Jan 24, 2024

Hi, I have just started a project that requires the use of @libp2p/webtransport
However none of the documented multiaddr formats are working as a listen address.

I have seen the following formats:
/ip4/0.0.0.0/udp/0/quic/webtransport
/ip4/0.0.0.0/udp/0/quic-v1/webtransport

@sachaw sachaw added the need/triage Needs initial labeling and prioritization label Jan 24, 2024
@achingbrain
Copy link
Member

The WebTransport transport is dial-only at the moment. When QUIC lands in node.js we'll be able to add it but until then listening is not supported.

I did have a PR that added listener support via @fails-components/webtransport but it was never really production-grade.

@achingbrain achingbrain added kind/support A question or request for support need/triage Needs initial labeling and prioritization and removed need/triage Needs initial labeling and prioritization labels Jan 24, 2024
Download pushed a commit to Download/js-libp2p that referenced this issue Feb 11, 2024
This adds a note at the top of the WebTransport `README.md` to remind people of the fact that currently, the WebTransport implementation in js-libp2p only supports dialing out to other nodes and does not actually support listening for incoming dials because js-libp2p depends on Node JS and QUIC support has not landed in Node JS yet.

Related: libp2p#2371
@Download
Copy link
Contributor

@achingbrain I made a PR that adds a note to the Webtransport docs about them supporting dial only. I am currently in the process of learning libp2p and I find that although there is a lot of documentation, it often misses critical details such as these or is hard to find. So I am trying to contribute by making small PRs with small updates to the docs as I go. Hope you find it helpful.

Download pushed a commit to Download/js-libp2p that referenced this issue Feb 12, 2024
This adds a note at the top of the WebTransport `README.md` to remind people of the fact that currently, the WebTransport implementation in js-libp2p only supports dialing out to other nodes and does not actually support listening for incoming dials because js-libp2p depends on Node JS and QUIC support has not landed in Node JS yet.

Related: libp2p#2371
@achingbrain
Copy link
Member

@Download thanks, yes - it's very helpful!

achingbrain added a commit that referenced this issue Feb 19, 2024
* docs: add note about webtransport only supporting dial

This adds a note at the top of the WebTransport `README.md` to remind people of the fact that currently, the WebTransport implementation in js-libp2p only supports dialing out to other nodes and does not actually support listening for incoming dials because js-libp2p depends on Node JS and QUIC support has not landed in Node JS yet.

Related: #2371

* Apply suggestions from code review

---------

Co-authored-by: Stijn de Witt <stijndewitt@foodsy.eu>
Co-authored-by: Alex Potsides <alex@achingbrain.net>
@achingbrain
Copy link
Member

Fixed by #2411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support A question or request for support
Projects
None yet
Development

No branches or pull requests

3 participants