[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #169 #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix issue #169 #171

wants to merge 2 commits into from

Conversation

brunotl
Copy link
Contributor
@brunotl brunotl commented Sep 10, 2024

Remove reference to deprecated CURLOPT_CLOSEPOLICY and allow to build with CURL_NO_OLDIES defined

@LeSuisse LeSuisse mentioned this pull request Sep 15, 2024
13 tasks
@m5k8
Copy link
m5k8 commented Sep 19, 2024

CURLOPT_CLOSEPOLICY gives me compilation error:

curlpp/include/curlpp/Options.hpp:311:74: error: invalid conversion from ‘int’ to ‘CURLoption’ [-fpermissive]
  311 |         typedef curlpp::OptionTrait<curl_closepolicy, CURLOPT_CLOSEPOLICY> ClosePolicy;
      |                                                                          ^
      |                                                                          |
      |                                                                          int

So I added temporarily explicit cast, but maybe removing this option (this pull request) would be cleaner.

-       typedef curlpp::OptionTrait<curl_closepolicy, CURLOPT_CLOSEPOLICY> ClosePolicy;
+       typedef curlpp::OptionTrait<curl_closepolicy, (CURLoption)CURLOPT_CLOSEPOLICY> ClosePolicy;

@brunotl
Copy link
Contributor Author
brunotl commented Sep 19, 2024

CURLOPT_CLOSEPOLICY gives me compilation error:

curlpp/include/curlpp/Options.hpp:311:74: error: invalid conversion from ‘int’ to ‘CURLoption’ [-fpermissive]
  311 |         typedef curlpp::OptionTrait<curl_closepolicy, CURLOPT_CLOSEPOLICY> ClosePolicy;
      |                                                                          ^
      |                                                                          |
      |                                                                          int

So I added temporarily explicit cast, but maybe removing this option (this pull request) would be cleaner.

-       typedef curlpp::OptionTrait<curl_closepolicy, CURLOPT_CLOSEPOLICY> ClosePolicy;
+       typedef curlpp::OptionTrait<curl_closepolicy, (CURLoption)CURLOPT_CLOSEPOLICY> ClosePolicy;

this PR is made to fix that ....

@m5k8
Copy link
m5k8 commented Sep 19, 2024

Yes, I know, that's why I'm putting my comment under this PR. I just upvoted it.

@creekorful
Copy link

Hello there,

Debian maintainer of the curlpp package here. We have faced build issues too since the latest libcurl update. While I do have backported a patch to make sure the package is still building I would love to see that PR included into a new release.

@jpbarrette Any chance this could be done? This library is really helpful for many.

Thank you for your work!

Cheers

@sim590
Copy link
sim590 commented Nov 3, 2024

I will comment here to support the merge of this PR as my project doesn't build anymore since the change in libcurl. Hopefully, this will be merged soon!

Even though the CI check fails. It seems to be broken though as it fails during execution of some python script which is not related to this PR.

sim590 added a commit to sim590/dpaste that referenced this pull request Nov 3, 2024
…22)

A patched version of curlpp/Options.hpp has been added to the repositiory in which
the faulty `ClosePolicy` definition was removed. Some other definitions were also
removed in order to get a minimal list of deprecated definitions warnings.

See the following links for references about the issue worked around:

jpbarrette/curlpp#171
jpbarrette/curlpp#169
sim590 added a commit to sim590/dpaste that referenced this pull request Nov 26, 2024
* workaround current curlpp related errors. See:
  * jpbarrette/curlpp#171
  * jpbarrette/curlpp#169
* fix a few build toolchain issues
* fix wrong encryption scheme being displayed (CBC -> GCM)
* update and fix typos in manpage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants