[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 8.9.1 -> 8.10.1 #341259

Merged
merged 2 commits into from
Oct 14, 2024
Merged

curl: 8.9.1 -> 8.10.1 #341259

merged 2 commits into from
Oct 14, 2024

Conversation

LeSuisse
Copy link
Contributor
@LeSuisse LeSuisse commented Sep 11, 2024 •
edited
Loading

Description of changes

Changes:
https://curl.se/ch/8.10.0.html
https://curl.se/ch/8.10.1.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 11, 2024
@ofborg ofborg bot requested a review from lovek323 September 12, 2024 07:41
fabianhjr
fabianhjr requested changes Sep 13, 2024
View reviewed changes
Copy link
Member
@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: build of '/nix/store/8jrwjg17bvj2l5c2a9gcbqhj9pb9zck3-python3.12-pycurl-7.45.3.drv', '/nix/store/xsbzlq11jp522yq73n6mfyjb24bbxp8q-curlpp-0.8.1.drv' failed

Seems like pycurl / curlpp break after this upgrade as reported on

https://github.com/NixOS/nixpkgs/pull/341259/checks?check_run_id=30041473910

@LeSuisse
Copy link
Contributor Author

It is a curlpp issue, there is a pending PR for it: jpbarrette/curlpp#171

I'm going to fetch the patch for CVE-2024-8096 in another PR so we can wait a bit to see if some fixes get merged on the curlpp side.

@LeSuisse LeSuisse mentioned this pull request Sep 15, 2024
Merged
13 tasks
@risicle
Copy link
Contributor
risicle commented Sep 15, 2024

No failures other than curlpp and pycurl building curl.tests on macos 12 x86_64.

@risicle
Copy link
Contributor
risicle commented Sep 15, 2024

Built pkgsStatic.curl.tests.withCheck, pkgsMusl.curl.tests.withCheck, pkgsCross.aarch64-multiplatform.curl & pkgsi686Linux.curl.tests.withCheck on nixos x86_64.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 15, 2024
@LeSuisse LeSuisse marked this pull request as draft September 16, 2024 07:12
@LeSuisse LeSuisse removed the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 17, 2024
@LeSuisse
Copy link
Contributor Author

I reported the pycurl issue upstream pycurl/pycurl#856

@fabianhjr
Copy link
Member

pycurl/pycurl#856 (comment)

☠️ hypothesis being a bug in curl. :S

@LeSuisse LeSuisse changed the title curl: 8.9.1 -> 8.10.0 curl: 8.9.1 -> 8.10.1 Sep 20, 2024
fabianhjr
fabianhjr approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member
@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycurl/pycurl#856 (comment)

So, it seems to have been a curl bug. It appears fixed in curl 8.10.1.

@fabianhjr
Copy link
Member

Hi @LeSuisse, is this ok to merge into staging?

@LeSuisse
Copy link
Contributor Author

Nope it's not, curl.tests will still fail due to curlpp.

I did not got the time to go back to this PR, I take a deeper look later today/this weekend.

@LeSuisse
Copy link
Contributor Author

Should be good to go. I removed the problematic curl flag usage in curlpp.

@LeSuisse LeSuisse marked this pull request as ready for review September 27, 2024 18:01
@fabianhjr
Copy link
Member

Retrying due to some errors with ofborg

@fabianhjr
Copy link
Member

@ofborg build curl curl.passthru.tests

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 29, 2024
@vcunat vcunat merged commit 682d9ab into NixOS:staging Oct 14, 2024
30 of 31 checks passed
@LeSuisse LeSuisse deleted the curl-8.10.0 branch October 14, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeSuisse @risicle @fabianhjr @vcunat @wegank