[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge submodule updating strategy #986

Merged
merged 3 commits into from
Feb 23, 2019

Conversation

JustAMan
Copy link
Contributor

This is essentially a copy of #975, but for master branch.

@Bond-009 Bond-009 merged commit 4a3e42e into jellyfin:master Feb 23, 2019
@JustAMan JustAMan deleted the submodule-update branch February 28, 2020 11:41
BaronGreenback added a commit to BaronGreenback/jellyfin that referenced this pull request Apr 28, 2020
2. interfaces with no gateway were being excluded from SSDP blasts

3. filtered SSDP blasts from not LAN addresses as defined on the network page.

4. removed jellyfin#986 mod - as this was part of the issue of jellyfin#2986. Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg.  [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP

5. fixed a problem where an invalid LAN address causing the SSDP to crash

6. corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
@BaronGreenback BaronGreenback mentioned this pull request Apr 28, 2020
BaronGreenback added a commit to BaronGreenback/jellyfin that referenced this pull request Apr 28, 2020
… came across a design issue in the current code - namely interfaces without a gateway were ignored.

Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).

Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)

All these changes are related.

Changes

1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed jellyfin#986 mod - as this was part of the issue of jellyfin#2986. Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
BaronGreenback added a commit to BaronGreenback/jellyfin that referenced this pull request Apr 28, 2020
… came across a design issue in the current code - namely interfaces without a gateway were ignored.

Fixing this required the removal of the code that attempted to detect virtual interfaces. Not wanting to remove functionality, but not able to keep the code in place, I implemented a work around solution (see 4 below).

Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)

All these changes are related.

Changes

1 IsInPrivateAddressSpace - improved subnet code checking
2 interfaces with no gateway were being excluded from SSDP blasts
3 filtered SSDP blasts from not LAN addresses as defined on the network page.
4 removed jellyfin#986 mod - as this was part of the issue of jellyfin#2986. Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
5 fixed a problem where an invalid LAN address causing the SSDP to crash
6 corrected local link filter (FilterIPAddress) to filter on 169.254. addresses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants