[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #2986 - fixed issue with SSDP Blast #1

Closed
wants to merge 49 commits into from

Conversation

BaronGreenback
Copy link
Owner

Whilst fixing issues with SSDP on devices with multiple interfaces, i came across a design issue in the current code - namely interfaces without a gateway were ignored.

Removing this also removed the attempt to detect virtual interfaces - so i implemented a work around solution (see 4 below) to keep the functionality.

Whilst in the area, I also fixed a few minor bugs i encountered (1, 5, 6 below) and stopped SSDP messages from going out on non-LAN interfaces (3)

All these changes are related.

Changes

  1. IsInPrivateAddressSpace - improved subnet code checking
  2. interfaces with no gateway were being excluded from SSDP blasts
  3. filtered SSDP blasts from not LAN addresses as defined on the network page.
  4. removed Backmerge submodule updating strategy jellyfin/jellyfin#986 mod - as this was part of the issue of SSDP blasts and listen are on 'default' interface, needs to be smart or configurable jellyfin/jellyfin#2986. Interfaces can be excluded from the LAN by putting the LAN address in brackets. eg. [10.1.1.1] will exclude an interface with ip address 10.1.1.1 from SSDP
  5. fixed a problem where an invalid LAN address causing the SSDP to crash
  6. corrected local link filter (FilterIPAddress) to filter on 169.254. addresses

JustAMan and others added 30 commits April 7, 2020 18:41
some colons were missing from the default ProtocolInfo string
Adds annotation for content-type of ASP.NET Web API endpoints
Emby.Server.Implementations code cleanup and warning fixes (Part 1)
Co-Authored-By: Bond-009 <bond.009@outlook.com>
joshuaboniface and others added 19 commits April 26, 2020 14:57
Co-Authored-By: Bond-009 <bond.009@outlook.com>
Co-Authored-By: Bond-009 <bond.009@outlook.com>
Co-Authored-By: Bond-009 <bond.009@outlook.com>
Co-Authored-By: Bond-009 <bond.009@outlook.com>
Co-Authored-By: Bond-009 <bond.009@outlook.com>
Fix InvalidOperationException while browsing via DLNA client.
Make localhost LiveTV restreams always use plain HTTP port
Try harder to find ffmpeg in app directory.
Now parse date in header correctly as being in UTC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.