[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow subtitle extraction and conversion in direct streaming #636

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Allow subtitle extraction and conversion in direct streaming #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,8 @@ public IEnumerable<string> GetPrimaryPlaylistVobFiles(string path, IIsoMount iso

public bool CanExtractSubtitles(string codec)
{
return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess such case is when there is no embedded subtitles :)

Copy link
Member Author
@cvium cvium Jan 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but the way that the function is currently being used it's irrelevant as it just needs to know if a subtitle can be converted. External text-based subs can be converted.

Copy link
@alois-git alois-git Jan 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry but a function that return only false or true, is useless and should be removed (if at least it would look for some property of some sort to activate or deactivate) . Unless they wanted to do some kind of implementation later on but then you add the check and the condition when implementing the feature.

My 2 cents

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is defined in an interface, ITranscoderSupport.

Copy link
@alois-git alois-git Jan 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha ok sorry :P ignore my comment, I didn't read the whole code

// TODO is there ever a case when a subtitle can't be extracted??
return true;
}

private class ProcessWrapper : IDisposable
Expand Down