Allow subtitle extraction and conversion in direct streaming #636
Conversation
3eaec8e
to
7470c71
Compare
|
@MatMaul Any idea why? |
7470c71
to
4a33de8
Compare
| @@ -1018,7 +1018,8 @@ public IEnumerable<string> GetPrimaryPlaylistVobFiles(string path, IIsoMount iso | |||
|
|
|||
| public bool CanExtractSubtitles(string codec) | |||
| { | |||
| return false; | |||
There was a problem hiding this comment.
I guess such case is when there is no embedded subtitles :)
There was a problem hiding this comment.
That's true, but the way that the function is currently being used it's irrelevant as it just needs to know if a subtitle can be converted. External text-based subs can be converted.
There was a problem hiding this comment.
I am sorry but a function that return only false or true, is useless and should be removed (if at least it would look for some property of some sort to activate or deactivate) . Unless they wanted to do some kind of implementation later on but then you add the check and the condition when implementing the feature.
My 2 cents
There was a problem hiding this comment.
The function is defined in an interface, ITranscoderSupport.
There was a problem hiding this comment.
ha ok sorry :P ignore my comment, I didn't read the whole code
Changes
Changed CanExtractSubtitles to return true.
I don't really understand why it's even there. Is there ever a case when it can't be extracted? Maybe live streams?
This PR is really just to create some discussion
Issues
Related to #254
Related to #172