[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in integer divisions in latest movies category #501

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Fix regression in integer divisions in latest movies category #501

merged 2 commits into from
Jan 8, 2019

Conversation

hawken93
Copy link
Contributor
@hawken93 hawken93 commented Jan 7, 2019 •
edited
Loading

As discussed right now in the #jellyfin-dev chat, the GPL cleanup made a regression where double division turned into integer division

Fixes #489

@cvium
Copy link
Member
cvium commented Jan 7, 2019

For reference: As discussed, missing 2 more ;)

@cvium cvium mentioned this pull request Jan 7, 2019
Closed
@cvium
Copy link
Member
cvium commented Jan 7, 2019

LGTM

@hawken93
Copy link
Contributor Author
hawken93 commented Jan 7, 2019 •
edited
Loading

I believe this fixes #489 and that it covers #500
EDIT: #519 fixes #490

@hawken93
Copy link
Contributor Author
hawken93 commented Jan 7, 2019

Tested. Fixes #489

@bobberb
Copy link
Contributor
bobberb commented Jan 8, 2019

Confirming fix of #489 from @hawken93 @sparky8251 fixes :D

@joshuaboniface joshuaboniface changed the title Fix regression where it would do integer divisions, giving wrong result Fix regression in integer divisions in latest movies category Jan 8, 2019
JustAMan
JustAMan approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor
@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JustAMan JustAMan changed the base branch from master to dev January 8, 2019 14:30
@Bond-009
Copy link
Member
Bond-009 commented Jan 8, 2019

#519 is the actual fix for #490, at most this PR makes that code not execute.

@joshuaboniface joshuaboniface mentioned this pull request Jan 8, 2019
Closed
@hawken93
Copy link
Contributor Author
hawken93 commented Jan 8, 2019

#519 is the actual fix for #490, at most this PR makes that code not execute.

ok then I will not claim fix for 490 here :)

@joshuaboniface joshuaboniface merged commit f1280f1 into jellyfin:dev Jan 8, 2019
@joshuaboniface joshuaboniface mentioned this pull request Jan 9, 2019
Merged
@hawken93 hawken93 deleted the fix_division branch January 11, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hawken93 @cvium @bobberb @Bond-009 @JustAMan @joshuaboniface