[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to recognize image format #490

Closed
sauerj opened this issue Jan 7, 2019 · 7 comments
Closed

Fail to recognize image format #490

sauerj opened this issue Jan 7, 2019 · 7 comments
Labels
backend Related to the server backend bug Something isn't working

Comments

@sauerj
Copy link
sauerj commented Jan 7, 2019

Just saw a bunch of these errors in the log, not sure if there were there in a previous version.

[2019-01-07 16:43:34.377 +00:00] [INF] Getting image size for item "Movie" "/config/metadata/library/27/27ba816802def3965a7b625f384a1181/poster.jpg"
[2019-01-07 16:43:34.378 +00:00] [ERR] Failed to determine primary image aspect ratio for "/config/metadata/library/27/27ba816802def3965a7b625f384a1181/poster.jpg"
System.ArgumentException: Could not recognize image format.
   at Emby.Drawing.Common.ImageHeader.DecodeJfif(BinaryReader binaryReader) in /repo/Emby.Drawing/Common/ImageHeader.cs:line 214
   at Emby.Drawing.Common.ImageHeader.GetDimensions(BinaryReader binaryReader) in /repo/Emby.Drawing/Common/ImageHeader.cs:line 97
   at Emby.Drawing.Common.ImageHeader.GetDimensions(String path, ILogger logger, IFileSystem fileSystem) in /repo/Emby.Drawing/Common/ImageHeader.cs:line 68
   at Emby.Drawing.ImageProcessor.GetImageSize(String path, Boolean allowSlowMethod) in /repo/Emby.Drawing/ImageProcessor.cs:line 499
   at Emby.Drawing.ImageProcessor.GetImageSize(BaseItem item, ItemImageInfo info, Boolean allowSlowMethods, Boolean updateItem) in /repo/Emby.Drawing/ImageProcessor.cs:line 469
   at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item) in /repo/Emby.Server.Implementations/Dto/DtoService.cs:line 1445
@sparky8251
Copy link
Contributor

If you could confirm whether or not they are from an earlier version, that would be nice.

We did make changes to the library that manages images and if you use docker, it was flat out broken for a bit.

@anthonylavado anthonylavado added bug Something isn't working backend Related to the server backend labels Jan 7, 2019
@drago-96
Copy link
drago-96 commented Jan 7, 2019

I also get a lot of these with the latest docker image.

@cvium
Copy link
Member
cvium commented Jan 7, 2019 •
edited
Loading

Fixed in #500 and #501. Related to #489

@hawken93 hawken93 mentioned this issue Jan 7, 2019
Merged
@hawken93
Copy link
Contributor
hawken93 commented Jan 8, 2019

I could use help verifying the fix :)

@sparky8251
Copy link
Contributor

@hawken93 You would build the #501 PR and check the docker or systemd logs.

@sauerj
Copy link
Author
sauerj commented Jan 8, 2019

@hawken93 I can confirm your fix. Do not see the errors anymore.

@Bond-009 Bond-009 mentioned this issue Jan 8, 2019
Merged
@Bond-009
Copy link
Member
Bond-009 commented Jan 9, 2019

Fixed by #519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Related to the server backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@anthonylavado @cvium @hawken93 @sparky8251 @joshuaboniface @sauerj @Bond-009 @drago-96