adding gradient background component #1759
Conversation
|
I'm gonna need a pointer resolving this failed test - The failure is complaining about seemingly normal import syntax, and I don't want to go changing babel configs without discussion first |
|
Hi @JayPerfetto, thanks for the PR. I haven't looked through the changes yet, but I did pull it down and look at the failing tests. To fix them, you just need to add the expo-linear-gradient package to the |
|
This looks great! Just adding that Jest transformIgnorePatterns property and then we should be good to ship. Thanks @JayPerfetto ! |
|
Had some time to scan through the code. Looks good! |
|
Great! I just checked in that change and it looks like everything is passing now - thanks for the quick pointer there |
|
@JayPerfetto This is great, thanks. Now you're forever one of us. 💜 |
# [7.2.0](v7.1.1...v7.2.0) (2021-08-10) ### Bug Fixes * **boilerplate:** Adds gradient background component, replacing Wallpaper ([#1759](#1759) by @JayPerfetto) ([2efdf7e](2efdf7e)) ### Features * **navigation:** Upgrade React Navigation to V6 ([#1758](#1758) by [@harrisrobin](https://github.com/harrisrobin)) ([5dd10ee](5dd10ee))
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
Adding a component which can be used as a LinearGradient Background wallpaper. I have replaced the use of the Wallpaper component in the demo screens, since it was not loading quickly enough in development builds and causing the UI to "flash" white when performing a navigation event. The component takes in an array of hex strings as props, so a user can customize the appearance of the gradient.
It's worth noting that this component required adding the dependency
expo-linear-gradientand raising the minimum iOS deployment target from 10.0 to 11.0 as a result. I tried to look into a lower level implementation of this, but all roads seemed to point to either this or the library "react-native-linear-gradient".This is my first PR for this project, but I did my best to conform to existing code style + conventions! Feedback is welcome 😅