Upgrade React Navigation to V6 and simplify certain navigation utilities thanks to new API. #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const navigation = useNavigation() | ||
| const goBack = () => navigation.goBack() | ||
| export const DemoListScreen: FC<StackScreenProps<NavigatorParamList, "demoList">> = observer( | ||
| ({ navigation }) => { |
There was a problem hiding this comment.
I've merged this, but just as a question, why switch to using props to grab the navigation reference rather than using the useNavigation hook? I kinda prefer the hook from an aesthetic standpoint.
There was a problem hiding this comment.
@jamonholmgren it's because I wasn't sure how to type the useNavigation hook with the navigation route types. Maybe it takes a generic.
infinitered-circleci
pushed a commit
that referenced
this pull request
Aug 10, 2021
# [7.2.0](v7.1.1...v7.2.0) (2021-08-10) ### Bug Fixes * **boilerplate:** Adds gradient background component, replacing Wallpaper ([#1759](#1759) by @JayPerfetto) ([2efdf7e](2efdf7e)) ### Features * **navigation:** Upgrade React Navigation to V6 ([#1758](#1758) by [@harrisrobin](https://github.com/harrisrobin)) ([5dd10ee](5dd10ee))
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn ci:testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
✅ Upgrade React Navigation to the latest version
✅ several improvements to navigation-utilities based on new APIs
✅ use native-stack instead of the js-stack.