Vector2.angle() performance #18622

gonnavis · 2020-02-13T06:52:18Z

I'm not sure whether the performance is better.
But in glsl, I heard "the less conditional the better".
Test result can check http://glslsandbox.com/e#61015.59 .

src/math/Vector2.js

gonnavis · 2020-02-13T10:44:10Z

OK, I tested in my own chrome console with these code:
First define the two angle functions, angle for current, angle2 for new.

function angle(x,y){
    var angle = Math.atan2( y, x );

    if ( angle < 0 ) angle += 2 * Math.PI;

    return angle;
}
function angle2(x,y){
    var angle = Math.atan2( - y, - x ) + Math.PI;

    return angle;
}

And then run these two functions in console 1000000000 times seperately.

var start=performance.now()
for(let i=0;i<1000000000;i++){
	angle(1,1)
}
console.log(performance.now()-start)

var start=performance.now()
for(let i=0;i<1000000000;i++){
	angle2(1,1)
}
console.log(performance.now()-start)

With angle, I got an average time 1330ms.
With angle2, I got an average time 560ms.
So I think it's a big performance improvement.

mrdoob · 2020-02-13T19:42:33Z

Thanks!

gonnavis added 2 commits February 13, 2020 14:47

Vector2 function angle performance

7968ff9

Unary operator '-' must be followed by whitespace

4d6c9b7

Mugen87 reviewed Feb 13, 2020

View reviewed changes

src/math/Vector2.js Show resolved Hide resolved

gonnavis changed the title ~~Vector2 function angle performance~~ Vector2.angle() performance Feb 13, 2020

mrdoob added this to the r114 milestone Feb 13, 2020

mrdoob merged commit 56e662b into mrdoob:dev Feb 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vector2.angle() performance #18622

Vector2.angle() performance #18622

Vector2.angle() performance #18622

Vector2.angle() performance #18622

Conversation