[go: up one dir, main page]

Page MenuHomePhabricator

JavaScriptTag
ActivePublic

Members (9)

Watchers (11)

Details

Description

Tasks related to JavaScript in MediaWiki core or extensions.

See also Instrument-ClientError (Javascript error logging in Wikimedia production).

Recent Activity

Wed, Nov 20

Xeverything11 added a comment to T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).

Chrome and Firefox for Android can be updated through Play Store.

Wed, Nov 20, 9:34 PM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Xeverything11 updated the task description for T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).
Wed, Nov 20, 5:48 PM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Xeverything11 added a comment to T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).
  • Android 5, released in 2014, supports up to Chrome 95 (released in 2021) (3 years old) as well as the latest version of Firefox (2024)
  • iOS 14, released in 2020, supports only Safari 14, also released in 2020.
Wed, Nov 20, 3:22 PM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Jdforrester-WMF added a comment to T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).

Historically, we've raised the browser support requirements based on a feature we want to use that we think is worth the trade-off. GZWDer is correct that the auto-upgrade features of Chromium- and Firefox-based desktop browsers have meant that we've changed to a rolling three-(ish)-year window, and that doing this for mobile-based devices like iOS Safari and Android Chrome would be a more aggressive change.

Wed, Nov 20, 2:57 PM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Xeverything11 added a comment to T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).
  • Safari iOS 14: 0.38% of Safari iOS users (0.08% of all)
  • Safari iOS 12: 0.5% of Safari iOS users (0.1% of all)
  • Safari iOS 11, 13: <0.1% of Safari iOS users (<0.02% of all)
Wed, Nov 20, 10:10 AM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Bugreporter added a comment to T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).

However for Safari, we will drop support for version <14 completely once T367821: Discovery: Deprecation of TLS 1.2 is resolved.

Wed, Nov 20, 10:05 AM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Bugreporter added a comment to T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).

Note:

  • Chrome and Firefox use last 3 year version rule. Currently Safari does not use such rule, probably because Safari in iOS can not be upgraded individually.
  • The Grade A and Grade C defined are normative only.
    • It does not define which browser will get JavaScript (which is detected via feature check in startup module)
    • Non-JS features must work in all Grade C browsers, and JS features must work in Grade A browsers (but might work in some Grade C ones)
  • Using newer JS features is not only blocked by this requirement, but also blocked by T277675: Add native support for ES2016-ES2020 or higher versions. Currently, only features up to ES7 can be used in Wikimedia code, where all Grade A browsers at least supports ES8.
Wed, Nov 20, 10:00 AM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Aklapper updated the task description for T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).
Wed, Nov 20, 9:28 AM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Xeverything11 created T380344: Safari support for Modern (Grade A) (proposal for current + 3 previous major versions).
Wed, Nov 20, 8:54 AM · OOUI, JavaScript, CSS, Browser-Support-Apple-Safari
Od1n closed T378319: An OOUI infuse that is unused as Resolved.

Nope, everything has been taken care of here.

Wed, Nov 20, 3:03 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), OOUI, JavaScript, AbuseFilter
Pppery added a comment to T378319: An OOUI infuse that is unused.

Anything left to do here?

Wed, Nov 20, 2:45 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), OOUI, JavaScript, AbuseFilter

Mon, Nov 18

Nardog reassigned T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest from Jdlrobson to TheresNoTime.
Mon, Nov 18, 10:50 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Jdlrobson closed T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest as Resolved.

I can't replicate any more and the errors are now trailing off:

Screenshot 2024-11-18 at 10.25.30 AM.png (283×1 px, 33 KB)

Mon, Nov 18, 6:28 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
ReleaseTaggerBot added a project to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).
Mon, Nov 18, 4:00 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Maintenance_bot removed a project from T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest: Patch-For-Review.
Mon, Nov 18, 3:31 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Stashbot added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

Mentioned in SAL (#wikimedia-operations) [2024-11-18T15:11:45Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:1091605|Revert "Allow other input and changes to trigger searchsuggestions to update" (T379983)]] (duration: 08m 14s)

Mon, Nov 18, 3:11 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Stashbot added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

Mentioned in SAL (#wikimedia-operations) [2024-11-18T15:06:38Z] <lucaswerkmeister-wmde@deploy2002> samtar, lucaswerkmeister-wmde: Backport for [[gerrit:1091605|Revert "Allow other input and changes to trigger searchsuggestions to update" (T379983)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mon, Nov 18, 3:06 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Stashbot added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

Mentioned in SAL (#wikimedia-operations) [2024-11-18T15:03:30Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:1091605|Revert "Allow other input and changes to trigger searchsuggestions to update" (T379983)]]

Mon, Nov 18, 3:03 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
gerritbot added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

Change #1091605 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.3] Revert "Allow other input and changes to trigger searchsuggestions to update"

https://gerrit.wikimedia.org/r/1091605

Mon, Nov 18, 3:03 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Xaosflux added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

This is certainly still an issue in vector-2010, able to reproduce and still getting user stories raised in VRT.

Mon, Nov 18, 11:06 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
gerritbot added a project to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest: Patch-For-Review.
Mon, Nov 18, 11:05 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
gerritbot added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

Change #1091605 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Samtar):

[mediawiki/core@wmf/1.44.0-wmf.3] Revert "Allow other input and changes to trigger searchsuggestions to update"

https://gerrit.wikimedia.org/r/1091605

Mon, Nov 18, 11:05 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Ammarpad merged T380137: Search term completion arrow key navigation jumps erratically in Monobook and Vector into T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.
Mon, Nov 18, 4:06 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error

Sat, Nov 16

Ammarpad merged T380111: Erratic and inconsistent arrow key navgiation of search suggestions on Vector Legacy into T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.
Sat, Nov 16, 1:25 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error

Fri, Nov 15

stjn added a project to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest: Regression.

Made it impossible to use keyboard navigation in search. Please don't wait till Monday. Vector 2010 is still the default skin in multiple projects, too.

Fri, Nov 15, 10:46 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Jdlrobson added a subtask for T374314: Consider use of native URL API instead of mw.Uri: T380079: This page is using the deprecated ResourceLoader module "mediawiki.Uri" on page load.
Fri, Nov 15, 5:02 PM · MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, Technical-Debt, JavaScript, MediaWiki-General
Nardog added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

It is affecting end users, unless this is unrelated:

searching (Vector 2010) and using arrow keys to navigate the search results is not working as expected (gif below, I am just pressing the down arrow):

Screen Recording 2024-11-14 at 23.23.33.gif (630×574 px, 855 KB)

Fri, Nov 15, 4:41 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Jdlrobson added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

Thanks @matmarex and @TheresNoTime for confirming the fix. I think it's okay for this to wait until Monday.

Fri, Nov 15, 4:11 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Daimona merged T380058: Search results cannot be selected using arrow keys into T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.
Fri, Nov 15, 2:30 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
TheresNoTime added a comment to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest.

I've made a backport patch — I'm around to do this today if needed, but given it's a Friday can it wait until Monday?

Fri, Nov 15, 11:50 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
Umherirrender added a project to T379983: RangeError: Maximum call stack size exceeded in mediawiki.searchSuggest: JavaScript.
Fri, Nov 15, 11:46 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Regression, JavaScript, MediaWiki-Search, Discovery-Search, MediaWiki-User-Interface (autocomplete search), Wikimedia-production-error
matmarex reopened T177251: Dead keys prevent autocomplete in search box as "Open".

The change caused T379983, reverted.

Fri, Nov 15, 12:15 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search

Wed, Nov 13

Jdlrobson moved T323232: [Client Error] TypeError: Cannot read properties of null (reading 'classList') - Vector TOC from Product Backlog to Legacy backlog on the Web-Team board.
Wed, Nov 13, 11:48 PM · Web-Team, JavaScript, Desktop Improvements (Vector 2022), Wikimedia-production-error
Jdlrobson edited projects for T323232: [Client Error] TypeError: Cannot read properties of null (reading 'classList') - Vector TOC, added: Web-Team; removed Web-Team-Backlog.
Wed, Nov 13, 11:38 PM · Web-Team, JavaScript, Desktop Improvements (Vector 2022), Wikimedia-production-error

Tue, Nov 12

apaskulin closed T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases, a subtask of T334853: Clean up JS code now that we can use ES6 rather than ES5 across all Wikimedia deployed codebases, as Resolved.
Tue, Nov 12, 11:37 PM · MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Patch-For-Review, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Epic, JavaScript, WMF-General-or-Unknown, Code-Health
Maintenance_bot removed a project from T269952: Split up apisandbox.js: Patch-For-Review.
Tue, Nov 12, 5:32 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Action-API, JavaScript, User-DannyS712
matmarex closed T269952: Split up apisandbox.js as Resolved.

Looking at the current state of the files: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/9cdf8af39240b92258b78300bb8c6ff146626179/resources/src/mediawiki.special.apisandbox I think we can consider this done. The largest files are around 700 lines, which is maybe not great, but not too bad either.

Tue, Nov 12, 5:01 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Action-API, JavaScript, User-DannyS712
gerritbot added a comment to T269952: Split up apisandbox.js.

Change #675295 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] apisandbox.js - split TokenParamWidget to separate file

https://gerrit.wikimedia.org/r/675295

Tue, Nov 12, 4:52 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Action-API, JavaScript, User-DannyS712
gerritbot added a comment to T269952: Split up apisandbox.js.

Change #674677 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] apisandbox.js - add UtilMixin.setParamInfo

https://gerrit.wikimedia.org/r/674677

Tue, Nov 12, 4:52 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Action-API, JavaScript, User-DannyS712
gerritbot added a comment to T269952: Split up apisandbox.js.

Change #649917 abandoned by Bartosz Dziewoński:

[mediawiki/core@master] Split up a bunch more apisandbox classes

Reason:

These patches would need to be re-done from scratch now, as there have been many changes to this code in the meantime. Sorry about that. (Some splitting has also already happened in other patches, e.g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1089812 )

https://gerrit.wikimedia.org/r/649917

Tue, Nov 12, 4:52 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Action-API, JavaScript, User-DannyS712

Sun, Nov 10

Pppery added a parent task for T115947: Suppress redirects when moving js and css user pages: T71162: Allow "suppressredirect" when moving from user's own userspace; allow "move-subpages" within own userspace.
Sun, Nov 10, 8:49 PM · MediaWiki-Redirects, JavaScript
Od1n added a comment to T378314: "Switch editor" and "Check syntax" buttons are misaligned.

The patch currently fails tests.

Sun, Nov 10, 11:45 AM · Patch-For-Review, JavaScript, CSS, OOUI, AbuseFilter
matmarex closed T177251: Dead keys prevent autocomplete in search box as Resolved.
Sun, Nov 10, 12:00 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search

Sat, Nov 9

Maintenance_bot removed a project from T177251: Dead keys prevent autocomplete in search box: Patch-For-Review.
Sat, Nov 9, 10:31 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search
ReleaseTaggerBot added a project to T177251: Dead keys prevent autocomplete in search box: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).
Sat, Nov 9, 10:00 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search
gerritbot added a comment to T177251: Dead keys prevent autocomplete in search box.

Change #1088731 merged by jenkins-bot:

[mediawiki/core@master] Allow other input and changes to trigger searchsuggestions to update

https://gerrit.wikimedia.org/r/1088731

Sat, Nov 9, 9:53 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search
TheDJ moved T177251: Dead keys prevent autocomplete in search box from Inbox to For-review on the User-TheDJ board.
Sat, Nov 9, 6:45 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search
TheDJ added a project to T177251: Dead keys prevent autocomplete in search box: User-TheDJ.
Sat, Nov 9, 6:45 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search
gerritbot added a project to T177251: Dead keys prevent autocomplete in search box: Patch-For-Review.
Sat, Nov 9, 6:38 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search
gerritbot added a comment to T177251: Dead keys prevent autocomplete in search box.

Change #1088731 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Allow other input and changes to trigger searchsuggestions to update

https://gerrit.wikimedia.org/r/1088731

Sat, Nov 9, 6:38 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), User-TheDJ, JavaScript, MediaWiki-Search