| Ebrahim | |
| Sep 7 2024, 7:45 AM |
| F57573484: image.png | |
| Sep 30 2024, 9:16 PM |
| Restricted File | |
| Sep 16 2024, 5:49 PM |
| F57475153: image.png | |
| Sep 7 2024, 10:24 AM |
| F57475150: image.png | |
| Sep 7 2024, 10:24 AM |
| F57475145: image.png | |
| Sep 7 2024, 10:24 AM |
| F57475142: image.png | |
| Sep 7 2024, 10:24 AM |
| F57474577: image.png | |
| Sep 7 2024, 7:45 AM |
Steps to replicate the issue (include links if applicable):
Have patrol rights on fawiki
https://fa.wikipedia.org/wiki/Special:NewPages?safemode=1&useskin=vector-2022&vectornightmode=1
What happens?:
White text on yellow background
I guess that needs some right to be seen.
What should have happened instead?:
Something other than light yellow
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix Special:NewPages unpatrolled items color in dark mode | mediawiki/core | master | +1 -1 |
Change #1071291 had a related patch set uploaded (by Ebrahim; author: Ebrahim):
[mediawiki/core@master] Fix Special:NewPages unpatrolled items color in dark mode
The patch in it's current state https://gerrit.wikimedia.org/r/1071291 turns
To
As it uses the background-color-warning-subtle token, not sure if that is ideal, maybe we can just have some arbitrary code for the dark mode (if so let me know about your suggested color code for the dark mode fit), maybe it could be better if we had the non subtle version of warning background color or maybe it's fine.
Change #1071291 merged by jenkins-bot:
[mediawiki/core@master] Fix Special:NewPages unpatrolled items color in dark mode
The patch is now merged, if you got any feedback and have a request for a specific custom color code I'm here to upload a patch for that. Thanks
I don't think these changes are actually an improvement in light mode. I've heard and read from several people of the Dutch Wikipedia they find the new background color of unpatrolled new pages too light. Concerns about this background color were already raised in T370423, this task is a duplicate of that one.
Color change should be reconsidered. New color is too light, you can barely see it.
{F57515674}
No problem, as said give me the color code you want both for the light (perhaps the previous color) and the dark mode and I'll send a patch and a reviewer will decide (if you don't want to upload the patch yourself). All I did was going with one Codex color which apparently wasn't enough so a custom color is needed.
It has turned from
(unreadable white text on yellow background, which this file was about)
to this
so if it's not satisfying, both in the light and dark colors, please file the issue in a separate task with screenshot and your suggestions for the colors and add me as a CC to the task. Thanks