[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T370423

Unpatrolled new pages and edits lack proper styling in dark mode
Closed, DuplicatePublicBUG REPORT
Actions

Description

NOTE: Sysadmins can workaround this by adding the rule /* T370423 */ .not-patrolled { color: black; } to [[MediaWiki:Vector-2022.css]] (or if possible a more limited place such as MediaWiki:Group-sysop.css)

Steps to replicate the issue (include links if applicable):

  • Go to a a wiki where the core patrolling is used, eg. nlwiki and have the adjacent right that allows you to patrol edits
  • Go to Special:NewPages or Special:Contributions
  • Enable dark mode

What happens?:
The page is barely readable due to a hardcoded background-color.

image.png (606×1 px, 229 KB)

What should have happened instead?:

A Codex token should be used that converts the colour automatically to one that is readable in dark mode, background-color-warning-subtle is too light in light mode imo. Waiting for T360494?

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects

Event Timeline

Sjoerddebruin created this task.Jul 18 2024, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2024, 2:56 PM
Sjoerddebruin mentioned this in T369391: FlaggedRevisions highlights do not work in dark mode.Jul 18 2024, 2:56 PM
Jdlrobson added a project: patch-welcome.Jul 18 2024, 3:59 PM
Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.
Tacsipacsi added subscribers: Jdlrobson, Tacsipacsi.Jul 18 2024, 11:25 PM

How to reproduce locally:

In T369391#9957546, @Jdlrobson wrote:

https://gerrit.wikimedia.org/g/mediawiki/core/+/c86466f5dcf24c9ce51c482f1b7796bf511ad1d8/resources/src/mediawiki.special/newpages.less#13 likely also needs updating but I couldn't replicate how locally!

On a new pages patrolled ($wgUseNPPatrol) wiki, create a page with a user whose edits are not patrolled (e.g. an anon, but Translate’s FuzzyBot also works for me), and then look at Special:NewPages with a user who is User::useNPPatrol() (e.g. an admin).

Tacsipacsi attached a referenced file: F56226067: image.png. (Show Details)Jul 18 2024, 11:27 PM
ClaudineChionh subscribed.Jul 21 2024, 5:57 AM
Mbch331 subscribed.Jul 25 2024, 10:25 AM
Jdlrobson updated the task description. (Show Details)Jul 30 2024, 9:35 PM
Escargot_rouge subscribed.Jul 30 2024, 9:49 PM
Sjoerddebruin mentioned this in T374299: Special:NewPage has unreadable text in the dark mode.Sep 16 2024, 11:03 AM
SomeRandomDeveloper subscribed.Fri, Nov 15, 11:34 PM

image.png (66×970 px, 20 KB)

I cannot reproduce this anymore, it seems to have been changed to use the background-color-warning-subtle token.

Tacsipacsi closed this task as a duplicate of T374299: Special:NewPage has unreadable text in the dark mode.Sat, Nov 16, 10:57 AM

(This task is older than that one, but the Gerrit patch is connected there, so it makes more sense to keep that one.)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits