Extension:Babel doesn't support/not supported by dark mode
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Snowmanonahoe
	Jul 4 2024, 9:21 PM

Description

Steps to replicate the issue (include links if applicable):

Open a page using the babel extension, such as https://en.wikipedia.org/wiki/User:Snowmanonahoe/sandbox
Enable dark mode

What happens?:

The box looks bad

What should have happened instead?:

The box looks good

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] Add dark mode colors and use skin variables	mediawiki/extensions/Babel	master	+275 -197
	quickfix: make blocks readable in dark theme	mediawiki/extensions/Babel	master	+8 -8

Customize query in gerrit

Related Objects

Mentioned Here: T360494: Develop an expanded color palette for Codex

Event Timeline

Snowmanonahoe created this task.Jul 4 2024, 9:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2024, 9:21 PM

SummerKrut subscribed.Jul 4 2024, 9:25 PM

Pppery added a project: MediaWiki-extensions-Babel.Jul 4 2024, 9:28 PM

Pppery moved this task from Backlog to Visual design on the MediaWiki-extensions-Babel board.

Peachey88 added a project: dark-mode.Jul 4 2024, 9:50 PM

Sjoerddebruin subscribed.Jul 4 2024, 10:07 PM

Jdlrobson edited projects, added Language-Team; removed Web-Team-Backlog.Jul 5 2024, 3:25 PM

Adding notheme class to this element should make it readable.

Change #1052350 had a related patch set uploaded (by Iniquity; author: Iniquity):

[mediawiki/extensions/Babel@master] quickfix: make blocks readable in dark theme

https://gerrit.wikimedia.org/r/1052350

gerritbot added a project: Patch-For-Review.Jul 5 2024, 7:50 PM

I added a quick fix, as suggested by @Jdlrobson. But I think for the dark theme the colors need improvement.

For the latter, probably needs T360494 for colors that are close to the existing ones.

Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jul 5 2024, 8:29 PM

Change #1052350 merged by jenkins-bot:

[mediawiki/extensions/Babel@master] quickfix: make blocks readable in dark theme

https://gerrit.wikimedia.org/r/1052350

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 8 2024, 7:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:25 PM

hgzh subscribed.Sep 19 2024, 5:45 AM

Nikerabbit removed a project: Language-Team.Oct 16 2024, 7:47 AM

jhsoby subscribed.Fri, Nov 8, 1:19 PM

Change #1091344 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/Babel@master] [WIP] Add dark mode colors and use skin variables

https://gerrit.wikimedia.org/r/1091344

gerritbot added a project: Patch-For-Review.Thu, Nov 14, 8:22 PM

Extension:Babel doesn't support/not supported by dark modeOpen, Needs TriagePublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Extension:Babel doesn't support/not supported by dark mode
Open, Needs TriagePublicBUG REPORT
Actions