[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T363914

Discrepancy between Graphite & Prometheus editResponseTime counts
Open, HighPublic
Actions

Description

I saw that T354905: migrate MediaWiki.timing.editResponseTime to statslib had been resolved for some time now, so I looked at converting the "Successful wiki edits" panels on the Grafana front page & www.wikimediastatus.net to use the version from Prometheus.

The original Graphite metric used was MediaWiki.timing.editResponseTime.sample_rate.

As best I can tell this ought to correspond to a sum(rate(mediawiki_WikimediaEvents_editResponseTime_seconds_count[5m])) query against Thanos.

However, comparing the results, the Prometheus metric is approx half the expected value:
https://grafana.wikimedia.org/goto/sBKcZCBIg

Am I misunderstanding something or is there something wrong?

Related Objects
Search...

Event Timeline

CDanis created this task.May 1 2024, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2024, 3:08 PM
CDanis triaged this task as High priority.May 1 2024, 3:08 PM
CDanis added a parent task: T350592: EPIC: migrate in use metrics and dashboards to statslib.
Krinkle subscribed.May 1 2024, 3:39 PM
colewhite added a subscriber: fgiunchedi.May 3 2024, 1:43 AM

Thanks for the report!

I'd hypothesize this is because Prometheus stats ingestion is not yet enabled on k8s hosts. The per-pod deployment strategy is convenient, but we've been concerned about turning it on in light of T359640: mediawiki_resourceloader_build_seconds_bucket big metric on Prometheus ops

We're coordinating with ServiceOps to redesign the exporter deployment on k8s. How we do this should also take into account: T359497: StatsD Exporter: gracefully handle metric signature changes.

fgiunchedi added a comment.May 6 2024, 2:50 PM

Indeed I agree that would be the root cause @colewhite pointed out. In light of the fact that (as far as I'm aware) we don't have an ETA to tweak the statsd-exporter deployment on wikikube as described in T359640; I think we should go back to the graphite/statsd metric for edits, so numbers are accurate

larissagaulia moved this task from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.May 13 2024, 11:17 AM
andrea.denisse subscribed.May 15 2024, 2:29 PM
colewhite added a comment.Jun 28 2024, 8:03 PM

Now that T365265 is nearing completion, this may be worth another look, @CDanis?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits