[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T354436

1.42.0-wmf.18 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
brennen
Release Version
1.42.0-wmf.18
Release Date
Feb 12 2024, 12:00 AM

2024 week 07 1.42-wmf.18 Changes wmf/1.42.0-wmf.18

This MediaWiki Train Deployment is scheduled for the week of Monday, February 12th:

Monday February 12thTuesday, February 13thWednesday, February 14thThursday, February 15thFriday
Backports only.Branch wmf.18 and deploy to Group 0 Wikis.Deploy wmf.18 to Group 1 Wikis.Deploy wmf.18 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.18 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.42.0-wmf.17
Next: 1.42.0-wmf.19
SubjectRepoBranchLines +/-
group2 wikis to 1.42.0-wmf.18operations/mediawiki-configmaster+333 -333
group1 wikis to 1.42.0-wmf.18operations/mediawiki-configmaster+333 -333
group2 wikis to 1.42.0-wmf.18operations/mediawiki-configmaster+333 -333
group1 wikis to 1.42.0-wmf.18operations/mediawiki-configmaster+549 -549
group0 wikis to 1.42.0-wmf.18operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.42.0-wmf.18operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.42.0-wmf.18mediawiki/corewmf/1.42.0-wmf.18+991 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jan 5 2024, 6:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2024, 6:13 PM
• NoOnEtHeMaStA added a commit: rMEXTf658c3375869: Update git submodules.Jan 7 2024, 9:15 PM
Aklapper removed a commit: rMEXTf658c3375869: Update git submodules.Jan 7 2024, 9:25 PM
Jdlrobson mentioned this in T356225: Verify 1.42.0-wmf.18 deployment.Jan 30 2024, 10:30 PM
thcipriani assigned this task to jeena.Feb 2 2024, 11:08 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: brennen.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Tacsipacsi added a subtask: T356225: Verify 1.42.0-wmf.18 deployment.Feb 12 2024, 8:09 AM
Tacsipacsi edited subtasks, added: T356984: Stop sending change notification email if edit is done by a bot; removed: T356225: Verify 1.42.0-wmf.18 deployment.
Tacsipacsi subscribed.
Ladsgroup removed a subtask: T356984: Stop sending change notification email if edit is done by a bot.Feb 12 2024, 8:57 AM
Tacsipacsi added a subtask: T356984: Stop sending change notification email if edit is done by a bot.Feb 12 2024, 9:01 AM
Ladsgroup closed subtask T356984: Stop sending change notification email if edit is done by a bot as Resolved.Feb 12 2024, 1:26 PM
Lucas_Werkmeister_WMDE mentioned this in T352424: Create Portal and Draft namespaces in mywiki.Feb 12 2024, 2:35 PM
brennen claimed this task.Feb 12 2024, 11:15 PM
brennen added a project: User-brennen.
brennen moved this task from Backlog to Next on the User-brennen board.
brennen added a subscriber: jeena.
thcipriani mentioned this in T356183: CVE-2024-34504: IPInfo REST APIs are not safe from CSRF attacks.Feb 13 2024, 1:32 AM
gerritbot added a comment.Feb 13 2024, 3:07 AM

Change 1002421 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.42.0-wmf.18] Branch commit for wmf/1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1002421

gerritbot added a project: Patch-For-Review.Feb 13 2024, 3:07 AM
gerritbot added a comment.Feb 13 2024, 3:30 AM

Change 1002421 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.18] Branch commit for wmf/1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1002421

gerritbot added a comment.Feb 13 2024, 4:03 AM

Change 1002758 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1002758

gerritbot added a comment.Feb 13 2024, 4:04 AM

Change 1002758 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1002758

Stashbot added a comment.Feb 13 2024, 4:04 AM

Mentioned in SAL (#wikimedia-operations) [2024-02-13T04:04:39Z] <mwpresync@deploy2002> Started scap: testwikis wikis to 1.42.0-wmf.18 refs T354436

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2024, 4:30 AM
Stashbot added a comment.Feb 13 2024, 4:57 AM

Mentioned in SAL (#wikimedia-operations) [2024-02-13T04:57:15Z] <mwpresync@deploy2002> Finished scap: testwikis wikis to 1.42.0-wmf.18 refs T354436 (duration: 52m 36s)

Stashbot added a comment.Feb 13 2024, 5:00 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-13T17:00:49Z] <brennen@deploy2002> Started scap: testwikis wikis to 1.42.0-wmf.18 refs T354436

Stashbot added a comment.Feb 13 2024, 5:25 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-13T17:25:29Z] <brennen@deploy2002> Finished scap: testwikis wikis to 1.42.0-wmf.18 refs T354436 (duration: 24m 39s)

Ladsgroup subscribed.Feb 13 2024, 5:49 PM
Stashbot added a comment.Feb 13 2024, 7:01 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-13T19:01:38Z] <brennen> train 1.42.0-wmf.18 (T354436): no current blockers, rolling to group0.

gerritbot added a comment.Feb 13 2024, 7:02 PM

Change 1003082 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003082

gerritbot added a project: Patch-For-Review.Feb 13 2024, 7:02 PM

Change 1003082 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003082

Stashbot added a comment.Feb 13 2024, 7:11 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-13T19:11:50Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group0 wikis to 1.42.0-wmf.18 refs T354436

brennen mentioned this in T357459: labtestwikitech down - Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Connection refused (clouddb2002-dev).Feb 13 2024, 7:15 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 13 2024, 7:30 PM
brennen added a comment.Feb 13 2024, 8:32 PM

Stable on group0. Some sync timeouts encountered during scap train-presync logged at P56710.

brennen moved this task from Next to Doing/Involved on the User-brennen board.Feb 13 2024, 9:51 PM
Stashbot added a comment.Feb 14 2024, 7:14 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-14T19:14:25Z] <brennen> train 1.42.0-wmf.18 (T354436): logs chill, no current blockers, rolling to group1.

gerritbot added a comment.Feb 14 2024, 7:15 PM

Change 1003508 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003508

gerritbot added a project: Patch-For-Review.Feb 14 2024, 7:15 PM

Change 1003508 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003508

Stashbot added a comment.Feb 14 2024, 7:26 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-14T19:26:37Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.18 refs T354436

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 7:31 PM
Stashbot added a comment.Feb 14 2024, 7:34 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-14T19:34:13Z] <brennen@deploy2002> Synchronized php: group1 wikis to 1.42.0-wmf.18 refs T354436 (duration: 07m 35s)

brennen mentioned this in T357577: Burst of "InvalidArgumentException: The given page ([page]) does not belong to page ID [id] but actually belongs to [id]" after 1.42.0-wmf.18 to group1.Feb 14 2024, 7:47 PM
Msz2001 subscribed.Feb 14 2024, 10:06 PM

There's a potentially highly visible regression for wikitables on mobile: T357589: [Regression] Wikitables has unwanted border spacing on mobile

I didn't mark it as blocker but if it should be, please do accordingly.

brennen mentioned this in T357687: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\Hooks::onAlternateEditPreview].Feb 15 2024, 4:28 PM
brennen mentioned this in T357691: PHP Notice: Trying to get property 'Z7K1' of non-object.Feb 15 2024, 4:46 PM
brennen mentioned this in T357700: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from FRInclusionCache::{closure}].Feb 15 2024, 5:15 PM
brennen mentioned this in T357702: MediaWiki\Extension\WikiLambda\ZErrorException: Language code not found.Feb 15 2024, 5:20 PM
Stashbot added a comment.Feb 15 2024, 7:04 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T19:04:36Z] <brennen> train 1.42.0-wmf.18 (T354436): no current blockers, rolling to all wikis.

gerritbot added a comment.Feb 15 2024, 7:04 PM

Change 1003817 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003817

gerritbot added a project: Patch-For-Review.Feb 15 2024, 7:04 PM
gerritbot added a comment.Feb 15 2024, 7:13 PM

Change 1003817 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003817

Stashbot added a comment.Feb 15 2024, 7:22 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T19:22:41Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.42.0-wmf.18 refs T354436

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 7:30 PM
brennen mentioned this in T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81.Feb 15 2024, 7:32 PM
gerritbot added a comment.Feb 15 2024, 8:13 PM

Change 1003870 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003870

gerritbot added a project: Patch-For-Review.Feb 15 2024, 8:13 PM
brennen added a subtask: T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81.Feb 15 2024, 8:13 PM
gerritbot added a comment.Feb 15 2024, 8:14 PM

Change 1003870 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003870

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 8:31 PM
Stashbot added a comment.Feb 15 2024, 8:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T20:38:50Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.42.0-wmf.18 refs T354436

thcipriani added a subtask: T356368: Revision endpoint: InvalidArgumentException: ParserOutput does not have a render ID.Feb 15 2024, 8:43 PM
Stashbot added a comment.Feb 15 2024, 8:46 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T20:46:56Z] <brennen@deploy2002> Synchronized php: group1 wikis to 1.42.0-wmf.18 refs T354436 (duration: 08m 05s)

gerritbot added a comment.Feb 15 2024, 9:11 PM

Change 1003878 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003878

gerritbot added a project: Patch-For-Review.Feb 15 2024, 9:11 PM
Msz2001 unsubscribed.Feb 15 2024, 9:11 PM
gerritbot added a comment.Feb 15 2024, 9:12 PM

Change 1003878 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.42.0-wmf.18

https://gerrit.wikimedia.org/r/1003878

Stashbot added a comment.Feb 15 2024, 9:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T21:20:57Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.42.0-wmf.18 refs T354436

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 9:31 PM
brennen removed a subtask: T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81.Feb 15 2024, 10:12 PM
brennen removed a subtask: T356368: Revision endpoint: InvalidArgumentException: ParserOutput does not have a render ID.Feb 15 2024, 10:15 PM
brennen added a comment.Feb 15 2024, 10:21 PM

Noting here that there's a backcompat patch available for T356368: Revision endpoint: InvalidArgumentException: ParserOutput does not have a render ID if rolling wmf.18 back from group2 is necessary for any reason:

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1003833

I haven't yet deployed that.

cscott subscribed.Feb 15 2024, 10:22 PM

Yeah, just for clarity: 1003833 needs to be merged and deployed to wmf.17 before rolling back to wmf.17 or else we'll get a repeat of T356368 as the old ParserOutput code fails to cope with "new" ParserOutputs coming from ParserCache.

brennen closed this task as Resolved.Feb 16 2024, 5:03 AM

Optimistically marking resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits