[go: up one dir, main page]

Page MenuHomePhabricator

Stop showing IP warning on Item and Property pages for Wikibase instances that have temporary accounts enabled
Closed, ResolvedPublic

Description

Problem:
We are showing warnings when edits are made on Items and Properties and the user isn't logged in. This warning informs them that their IP will be shown. With IP Masking this will no longer be the case so we should remove the warning.
This applies for all edits to statements, terms or sitelinks on Items and Properties.

Example:

image.png (169×288 px, 15 KB)

BDD
GIVEN an Item or Property
WHEN making an edit
AND IP Masking is enabled
THEN do not show the IP leak warning

Acceptance criteria:

  • IP leak warning isn't shown when editing Items and Properties when IP Masking is enabled

Event Timeline

Change 984611 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Change anonymous edit pop-up warning to support TempUsers

https://gerrit.wikimedia.org/r/984611

Technically, this also covers the new/mobile/Vue Termbox, but we probably want a dedicated task for that, because as I understand it, this codebase is intended to be handled by the Wikibase Product Platform Team WPP.

Also, looking at the change attached here, and trying it out locally, I think this also changes this for editing on Lexeme pages and so should also be verified there. That is, it might already implement T351973: Stop showing create an account message on Lexeme editing UI for Wikibase instances that have temporary accounts enabled.

Change 984611 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Change anonymous edit pop-up warning to support TempUsers

https://gerrit.wikimedia.org/r/984611

Arian_Bozorg claimed this task.
Arian_Bozorg subscribed.

Looks good to me! Thanks so much :)