[go: up one dir, main page]

Page MenuHomePhabricator

Change PageTriage "refresh list" button to use Codex styling
Closed, ResolvedPublic

Assigned To
Authored By
Frostly
Oct 20 2023, 9:59 PM
Referenced Files
F39326974: image.png
Oct 21 2023, 8:45 PM
F39325985: image.png
Oct 21 2023, 8:41 PM
F39014467: Screenshot from 2023-10-21 00-51-09.png
Oct 20 2023, 10:52 PM
F38988124: image.png
Oct 20 2023, 10:04 PM
F38987856: image.png
Oct 20 2023, 9:59 PM
F38987850: image.png
Oct 20 2023, 9:59 PM

Description

image.png (48×134 px, 2 KB)

Event Timeline

Frostly renamed this task from Change PaageTriage " to Change PageTriage "refresh list" button to use Vue.js.Oct 20 2023, 9:59 PM
Frostly created this task.
Frostly updated the task description. (Show Details)

HTML inspecting the button shows that it is a Codex button. Codex is part of Vue. Can you elaborate?

image.png (143×1 px, 11 KB)

Soda renamed this task from Change PageTriage "refresh list" button to use Vue.js to Change PageTriage "refresh list" button to use Codex styling.Oct 20 2023, 10:47 PM

HTML inspecting the button shows that it is a Codex button. Codex is part of Vue. Can you elaborate?

image.png (143×1 px, 11 KB)

I think the proposal here is to remove the "ui-button" styling and bring it in line with the wikimedia style guide similar to the other buttons in the feed. This would require some subtle changes to the drop shadows and overall styling:

BeforeAfter
image.png (48×134 px, 2 KB)
Screenshot from 2023-10-21 00-51-09.png (50×105 px, 1 KB)

@Soda that's indeed my meaning, thanks for the clarification!

Ideally this would also be replaced with one of the Codex icons too (https://doc.wikimedia.org/codex/latest/icons/all-icons.html):

image.png (46×41 px, 1 KB)

Icons are probably out of scope for this ticket. May want to take a look at T347732: Mock up a 100% Codex front end for PageTriage.

Changing the button seems fine. Let's do that. Thanks for the ticket.

Change 967588 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Make the "refresh list" button use Codex styling

https://gerrit.wikimedia.org/r/967588

image.png (39×129 px, 2 KB)
Ideally this checkbox would use Codex too

I just wanted to note: even though Moderator Tools is wrapping up our effort on new PageTriage ui patches, we're happy to work in code review on this kind of work when desired. I'm happy to help walk you through setting up url parameters to use as feature flags if you want to be able to have users trial changes in production.

Change 967588 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Make the "refresh list" button use Codex styling

https://gerrit.wikimedia.org/r/967588

Test wiki on Patch demo by Frostly using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1a49854e2f/w/