| Novem_Linguae | |
| Jul 31 2023, 1:09 PM |
| F37640451: image.png | |
| Aug 29 2023, 12:58 PM |
| F37394515: Screenshot 2023-08-10 at 21.15.00.png | |
| Aug 11 2023, 3:21 AM |
| F37394513: Screenshot 2023-08-10 at 21.16.25.png | |
| Aug 11 2023, 3:21 AM |
| F37157035: image.png | |
| Jul 31 2023, 1:09 PM |
| F37157030: image.png | |
| Jul 31 2023, 1:09 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
What should have happened instead?:
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T335074 Rewrite PageTriage front-end in Vue.js | |||
| Resolved | Samwalton9-WMF | T334506 Improve Javascript testing coverage in PageTriage | |||
| Resolved | Samwalton9-WMF | T343329 Special:NewPagesFeed Vue UI: wrap up feedback period and make default experience | |||
| Resolved | BUG REPORT | jsn.sherman | T342434 Special:NewPagesFeed and Page Curation toolbar must share and persist state | ||
| Resolved | Spike | jsn.sherman | T324914 Add [[User:DannyS712/VueNPP.js]] to PageTriage repo | ||
| Resolved | BUG REPORT | Scardenasmolinar | T343126 Space missing between "Oldest" and "X pages in your filtered list" |
Change 947496 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/PageTriage@master] Add media query to mwe-vue-pt-control-label-right
Change 947981 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):
[mediawiki/extensions/PageTriage@master] Add space between radio buttons and label
Since I can't add screenshots to Gerrit, I'll do the review here.
@Novem_Linguae, the problem with your approach to solving the problem is that the elements floating to the right become misaligned when there is enough space in the header.
vs.
In the media query, elements are always aligned on the right except when some widths/high zooms are reached.
Change 947981 abandoned by Novem Linguae:
[mediawiki/extensions/PageTriage@master] Add space between radio buttons and label
Reason:
Other patch is better, solves the issue in https://phabricator.wikimedia.org/T343126#9085871
Change 947496 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Add media query to mwe-vue-pt-control-label-right
This bug is back. Steps to reproduce
Change 953355 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):
[mediawiki/extensions/PageTriage@master] Fix media query to solve spacing issue
Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/751ceeb2cb/w
Change 953355 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Refactor filter menu layout
Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted: