[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T338454

Update GrowthExperiments to use the new HookContainer/HookRunner system
Open, MediumPublic
Actions

Description

Implement the Hook system added in MediaWiki 1.35 in the extensions, see Hooks.md for documentation.

  • Create HookRunner class and the hook handler interfaces (no own hooks)
  • Use hook handlers
    • Handler for core hooks
      • GrowthExperiments\ConfirmEmailHooks
    • Handler for extensions hooks (depending on creation of hook interfaces in the extensions)

Details

SubjectRepoBranchLines +/-
Convert ConfirmEmailHooks to HookHandlersmediawiki/extensions/GrowthExperimentsmaster+11 -8
Create HookRunner classmediawiki/extensions/GrowthExperimentsmaster+51 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Jun 8 2023, 12:41 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 8 2023, 12:41 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Umherirrender added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system.Jun 8 2023, 12:41 PM
gerritbot added a comment.Jun 8 2023, 12:41 PM

Change 926824 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Create HookRunner class

https://gerrit.wikimedia.org/r/926824

gerritbot added a project: Patch-For-Review.Jun 8 2023, 12:41 PM
Umherirrender renamed this task from GrowthExperiments to Update GrowthExperiments to use the new HookContainer/HookRunner system.Jun 8 2023, 12:47 PM
Umherirrender updated the task description. (Show Details)
Tgr moved this task from Inbox to Current Maintenance Focus on the Growth-Team board.Jun 8 2023, 9:20 PM
Umherirrender added a project: Core Platform Team Initiatives (New Hook System).Jun 9 2023, 8:39 PM
gerritbot added a comment.Jun 24 2023, 8:54 PM

Change 926824 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Create HookRunner class

https://gerrit.wikimedia.org/r/926824

Umherirrender removed a project: Patch-For-Review.Jun 24 2023, 8:59 PM
Umherirrender updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 24 2023, 9:01 PM
gerritbot added a comment.Oct 1 2023, 9:20 AM

Change 962157 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GrowthExperiments@master] Convert ConfirmEmailHooks to HookHandlers

https://gerrit.wikimedia.org/r/962157

gerritbot added a project: Patch-For-Review.Oct 1 2023, 9:20 AM
gerritbot added a comment.Oct 2 2023, 8:12 AM

Change 962157 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Convert ConfirmEmailHooks to HookHandlers

https://gerrit.wikimedia.org/r/962157

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 8:31 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.29; 2023-10-03); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Oct 2 2023, 9:00 AM
Sgs triaged this task as Medium priority.Nov 20 2023, 4:17 PM
DMburugu added subscribers: Sgs, DMburugu.Jun 12 2024, 3:02 PM

@Sgs I think moving this to Triaged or marking it as closed for now would be okay since the ConfirmEmailHooks adhere to the new hook system and we're not maintaining CirrusSearch which is listed.

Umherirrender unsubscribed.Sep 3 2024, 7:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits