| Jdrewniak | |
| May 9 2023, 3:14 PM |
| F37001745: Screenshot 2023-05-16 at 2.46.54 PM.png | |
| May 16 2023, 9:47 PM |
| F36989914: screenshot_2023-05-09_at_10.22.25_am.png | |
| May 9 2023, 3:14 PM |
Steps to replicate the issue
What happens?:
What should have happened instead?:
The text should not overlap the close button
Other information
The close button only appears if the my_wikilimited-width-aware cookie is not set.
Change 917899 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@master] Add padding to limited-width toggle to account for close icon
Change 917899 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add padding to limited-width toggle to account for close icon
Change 917733 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@wmf/1.41.0-wmf.7] Add padding to limited-width toggle to account for close icon
Change 917734 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Add padding to limited-width toggle to account for close icon
Change 917733 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.41.0-wmf.7] Add padding to limited-width toggle to account for close icon
Change 917734 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.41.0-wmf.8] Add padding to limited-width toggle to account for close icon
Mentioned in SAL (#wikimedia-operations) [2023-05-09T20:22:52Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:917733|Add padding to limited-width toggle to account for close icon (T336274)]], [[gerrit:917734|Add padding to limited-width toggle to account for close icon (T336274)]]
Mentioned in SAL (#wikimedia-operations) [2023-05-09T20:24:24Z] <urbanecm@deploy1002> urbanecm and jdrewniak: Backport for [[gerrit:917733|Add padding to limited-width toggle to account for close icon (T336274)]], [[gerrit:917734|Add padding to limited-width toggle to account for close icon (T336274)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet
Mentioned in SAL (#wikimedia-operations) [2023-05-09T20:31:51Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:917733|Add padding to limited-width toggle to account for close icon (T336274)]], [[gerrit:917734|Add padding to limited-width toggle to account for close icon (T336274)]] (duration: 08m 59s)
Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Limited-width toggle close button should not overlap with text