Maniphest T332886

📚️ Adjust PropertyValuePairSerializer to serialize the new read model
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Mar 23 2023, 1:23 PM

Tags

Referenced Files

None

Subscribers

Muhammad_Yasser_Jazirahly_WMDE

• WMDE_Norman

Description

PropertyValuePairSerializer needs to serialize the new read model created via T332879, instead of the DataModel's Snak obejct.

rename the existing serialize( Snak $snak ) method to serializeSnak() (to be deleted later once the whole task is done)
create a new serialize( PropertyValuePair $propertyValuePair ) method

Details

	Subject	Repo	Branch	Lines +/-
	REST: Adjust serializer for PropertyValuePair	mediawiki/extensions/Wikibase	master	+94 -23

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T325354 📚️ Use read models instead of DataModel entities in all use case responses
		Resolved		Jakob_WMDE	T332886 📚️ Adjust PropertyValuePairSerializer to serialize the new read model

Event Timeline

Silvan_WMDE created this task.Mar 23 2023, 1:23 PM

Jakob_WMDE claimed this task.Mar 23 2023, 4:09 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 25) board.

Change 902699 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Adjust serializer for PropertyValuePair

https://gerrit.wikimedia.org/r/902699

gerritbot added a project: Patch-For-Review.Mar 24 2023, 12:29 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 25) board.Mar 24 2023, 2:45 PM

Change 902699 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Adjust serializer for PropertyValuePair

https://gerrit.wikimedia.org/r/902699

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2023, 2:30 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 27 2023, 3:00 PM

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 25) board.Mar 28 2023, 9:02 AM

WMDE-leszek closed this task as Resolved.Apr 19 2023, 2:38 PM