[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T330691

Table of mentees on the Mentor dashboard is not visible on Timeless
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Etonkovidova
Authored By
Trizek-WMF
Feb 27 2023, 7:08 PM
Tags
Referenced Files
F36890478: Screen Shot 2023-03-03 at 9.43.27 AM.png
Mar 3 2023, 5:47 PM
F36890476: Screen Shot 2023-03-03 at 9.43.00 AM.png
Mar 3 2023, 5:47 PM
F36885290: Screenshot 2023-02-28 at 4.52.20 PM.png
Mar 1 2023, 1:01 AM
F36885255: Screen Shot 2023-02-28 at 4.11.16 PM.png
Mar 1 2023, 12:15 AM
F36885249: Screen Shot 2023-02-28 at 4.10.53 PM.png
Mar 1 2023, 12:15 AM
Subscribers
Aklapper
Antimuonium
• Catrope
Etonkovidova
Jdforrester-WMF
kostajh
KStoller-WMF
View All 10 Subscribers

Description

Steps to replicate the issue (include links if applicable):

You have to be a registered mentor at one wiki when Growth mentorship is available.

You can do it at Beta Wikipedia:

  1. Register as a mentor on https://en.wikipedia.beta.wmflabs.org/wiki/Special:EnrollAsMentor
  2. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:MentorDashboard, where you get a table of mentees (wait for the table to be completed, which might take a few hours)
  3. Visit https://en.wikipedia.beta.wmflabs.org/wiki/Special:MentorDashboard?useskin=timeless, where you don't.

What happens?:
The table displaying the list of your assigned mentees is not visible.

What should have happened instead?:
The table displaying the list of your assigned mentees is displayed.

Other information (browser name/version, screenshots, etc.):
Reported at French Wikipedia, here and here.

Details

SubjectRepoBranchLines +/-
Vue: Fix import paths for theme-wikimedia-ui.lessmediawiki/extensions/GrowthExperimentsmaster+13 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.Feb 27 2023, 7:08 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 27 2023, 7:08 PM
Maintenance_bot added a project: GrowthExperiments-Mentorship.Feb 27 2023, 7:30 PM
Antimuonium subscribed.Feb 27 2023, 8:13 PM
Etonkovidova moved this task from Inbox to Needs Discussion on the Growth-Team board.Mar 1 2023, 12:15 AM
Etonkovidova subscribed.

Confirmed on testwiki wmf.25. All other skins are fine - Vector 2022, old Vector, MinevaNeue, and Monobook.
Special:MentorDashboard for the same user (no filters)

Timeless skinVector skin
Screen Shot 2023-02-28 at 4.10.53 PM.png (1×1 px, 279 KB)
Screen Shot 2023-02-28 at 4.11.16 PM.png (1×2 px, 418 KB)
Backtrace:
from /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Parser.php(2706)
#0 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Parser.php(433): Less_Parser->Error(string)
#1 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(272): Less_Parser->parseFile(string, string, boolean)
#2 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Tree/Import.php(196): Less_Tree_Import->ParseImport(string, string, Less_Environment)
#3 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(250): Less_Tree_Import->compile(Less_Environment)
#4 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(238): Less_Tree_Ruleset->evalImports(Less_Environment)
#5 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Tree/Ruleset.php(75): Less_Tree_Ruleset->PrepareRuleset(Less_Environment)
#6 /srv/mediawiki/php-1.40.0-wmf.25/vendor/wikimedia/less.php/lib/Less/Parser.php(181): Less_Tree_Ruleset->compile(Less_Environment)
#7 /srv/mediawiki/php-1.40.0-wmf.25/includes/ResourceLoader/FileModule.php(1115): Less_Parser->getCss()
#8 /srv/mediawiki/php-1.40.0-wmf.25/includes/ResourceLoader/FileModule.php(998): MediaWiki\ResourceLoader\FileModule->compileLessString(string, string, MediaWiki\ResourceLoader\Context)
#9 /srv/mediawiki/php-1.40.0-wmf.25/includes/ResourceLoader/FileModule.php(399): MediaWiki\ResourceLoader\FileModule->processStyle(string, string, string, MediaWiki\ResourceLoader\Context)
#10 /srv/mediawiki/php-1.40.0-wmf.25/includes/ResourceLoader/Module.php(834): MediaWiki\ResourceLoader\FileModule->getStyles(MediaWiki\ResourceLoader\Context)
#11 /srv/mediawiki/php-1.40.0-wmf.25/includes/ResourceLoader/Module.php(786): MediaWiki\ResourceLoader\Module->buildContent(MediaWiki\ResourceLoader\Context)
#12 /srv/mediawiki/php-1.40.0-wmf.25/includes/ResourceLoader/ResourceLoader.php(1110): MediaWiki\ResourceLoader\Module->getModuleContent(MediaWiki\ResourceLoader\Context)
#13 /srv/mediawiki/php-1.40.0-wmf.25/includes/ResourceLoader/ResourceLoader.php(806): MediaWiki\ResourceLoader\ResourceLoader->makeModuleResponse(MediaWiki\ResourceLoader\Context, array, array)
#14 /srv/mediawiki/php-1.40.0-wmf.25/load.php(53): MediaWiki\ResourceLoader\ResourceLoader->respond(MediaWiki\ResourceLoader\Context)
#15 /srv/mediawiki/php-1.40.0-wmf.25/load.php(39): wfLoadMain()
#16 /srv/mediawiki/w/load.php(3): require(string)
#17 {main}
Etonkovidova added a subscriber: Urbanecm_WMF.Mar 1 2023, 12:17 AM
KStoller-WMF added subscribers: kostajh, KStoller-WMF.Mar 1 2023, 1:01 AM

Interesting, it seems like we have a similar issue with the only other Growth Vue component: the new impact module:

Screenshot 2023-02-28 at 4.52.20 PM.png (1×3 px, 886 KB)

Tested on English Wikipedia: the skeleton loads, but the actual impact module data never loads.

@kostajh - should I log a separate bug for this, or do you think the underlying issue is likely the same?

kostajh added a comment.Mar 1 2023, 9:38 AM

The error message is

\Less_Exception_Parser: File `../../../../resources/lib/codex-design-tokens/theme-wikimedia-ui.less` not found. in NoEditsDisplay.vue

So I guess Timeless needs to load codex-design-tokens?

In T330691#8655092, @KStoller-WMF wrote:

Interesting, it seems like we have a similar issue with the only other Growth Vue component: the new impact module:

Screenshot 2023-02-28 at 4.52.20 PM.png (1×3 px, 886 KB)

Tested on English Wikipedia: the skeleton loads, but the actual impact module data never loads.

@kostajh - should I log a separate bug for this, or do you think the underlying issue is likely the same?

It's the same issue.

kostajh added a comment.EditedMar 1 2023, 12:37 PM

I think this will be solved by T325237: Enable and document use of Codex design tokens within MediaWiki and/or T328602: Enable use of Codex Less mixins inside of MediaWiki.

kostajh added a subtask: T328602: Enable use of Codex Less mixins inside of MediaWiki.Mar 1 2023, 12:38 PM
• Catrope subscribed.Mar 1 2023, 6:13 PM

I think this is happening because the import in NoEditsDisplay has one ../ to few. From mediawiki/extensions/GrowthExperiments/modules/ext.growthExperiments.Homepage.NewImpact/components/NoEditsDisplay.vue, the import path ../../../../resources/lib/codex-design-tokens/theme-wikimedia-ui.less resolves to mediawiki/extensions/resources/lib/codex-design-tokens/theme-wikimedia-ui.less , which doesn't exist. You need one more ../ to make it work.

The reason it works in Vector is because Vector's mediawiki.less directory (which is part of the import paths list) lives at mediawiki/skins/Vector/resources/mediawiki.less/, and NoEditsDisplay.vue happens to use the right number of ../s to get to the right file from there. Less probably shouldn't try using other import paths besides the current directory for imports that start with ../, but it does.

gerritbot added a comment.Mar 2 2023, 11:59 AM

Change 893694 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] Vue: Fix import paths for theme-wikimedia-ui.less

https://gerrit.wikimedia.org/r/893694

gerritbot added a project: Patch-For-Review.Mar 2 2023, 11:59 AM
kostajh added a comment.Mar 2 2023, 11:59 AM
In T330691#8657999, @Catrope wrote:

I think this is happening because the import in NoEditsDisplay has one ../ to few. From mediawiki/extensions/GrowthExperiments/modules/ext.growthExperiments.Homepage.NewImpact/components/NoEditsDisplay.vue, the import path ../../../../resources/lib/codex-design-tokens/theme-wikimedia-ui.less resolves to mediawiki/extensions/resources/lib/codex-design-tokens/theme-wikimedia-ui.less , which doesn't exist. You need one more ../ to make it work.

The reason it works in Vector is because Vector's mediawiki.less directory (which is part of the import paths list) lives at mediawiki/skins/Vector/resources/mediawiki.less/, and NoEditsDisplay.vue happens to use the right number of ../s to get to the right file from there. Less probably shouldn't try using other import paths besides the current directory for imports that start with ../, but it does.

Aha, indeed. Thank you.

kostajh triaged this task as Medium priority.Mar 2 2023, 12:00 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot moved this task from New Tasks to In Progress on the GrowthExperiments-Mentorship board.Mar 2 2023, 12:15 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 2 2023, 7:12 PM
gerritbot added a comment.Mar 2 2023, 7:29 PM

Change 893694 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Vue: Fix import paths for theme-wikimedia-ui.less

https://gerrit.wikimedia.org/r/893694

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2023, 7:29 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.26; 2023-03-06).Mar 2 2023, 8:00 PM
Urbanecm_WMF added a comment.Mar 2 2023, 8:30 PM

The fix should be deployed with the wmf.26 train (starting March 09 on Wikipedias). FYI @Trizek-WMF.

Urbanecm_WMF moved this task from In Progress to Ready for QA on the GrowthExperiments-Mentorship board.Mar 2 2023, 8:30 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.EditedMar 3 2023, 5:47 PM

Checked in betalabs (and wmf.26) - works as expected:

Screen Shot 2023-03-03 at 9.43.00 AM.png (840×578 px, 69 KB)
Screen Shot 2023-03-03 at 9.43.27 AM.png (1×2 px, 353 KB)
kostajh mentioned this in T331367: GrowthExperiments' CNumberInput triggering occasional "Generating module package failed: theme-wikimedia-ui.less not found" errors in prod.Mar 7 2023, 7:04 AM
kostajh merged a task: T331367: GrowthExperiments' CNumberInput triggering occasional "Generating module package failed: theme-wikimedia-ui.less not found" errors in prod.
kostajh added subscribers: Jdforrester-WMF, Aklapper.
Trizek-WMF added a project: Community Feedback (Growth).Mar 7 2023, 3:46 PM
Etonkovidova closed this task as Resolved.Mar 7 2023, 11:19 PM
Etonkovidova claimed this task.
Jdforrester-WMF mentioned this in T331645: Less_Exception_Parser: File `../../../../resources/lib/codex-design-tokens/theme-wikimedia-ui.less` not found. in NoEditsDisplay.vue.Mar 9 2023, 4:58 PM
kostajh merged a task: T331645: Less_Exception_Parser: File `../../../../resources/lib/codex-design-tokens/theme-wikimedia-ui.less` not found. in NoEditsDisplay.vue.Mar 10 2023, 1:57 PM
kostajh added a subscriber: thcipriani.
dduvall mentioned this in T333483: Less_Exception_Parser: File `resources/lib/codex-design-tokens/theme-wikimedia-ui-legacy.less` not found. in interface.less.Mar 29 2023, 6:39 PM
• Catrope closed subtask T328602: Enable use of Codex Less mixins inside of MediaWiki as Resolved.Apr 11 2023, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits