[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T329627

Optimize permalinks maintenance script to avoid listing non-discussion pages
Closed, ResolvedPublic
Actions

Description

In T315510#8552958, @Ladsgroup wrote:

The biggest reason it took this long was that the script checked every page before actually doing anything on talk pages, it could have been made much faster but we learned about this quite late in the run. It's fine. Given that wikidata and commons are done now, I assume it won't be a big issue in other runs but still better to be fixed.

Details

SubjectRepoBranchLines +/-
persistRevisionThreadItems: Avoid listing non-discussion pagesmediawiki/extensions/DiscussionToolswmf/1.40.0-wmf.23+17 -0
persistRevisionThreadItems: Avoid listing non-discussion pagesmediawiki/extensions/DiscussionToolswmf/1.40.0-wmf.22+17 -0
persistRevisionThreadItems: Avoid listing non-discussion pagesmediawiki/extensions/DiscussionToolsmaster+17 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Feb 14 2023, 2:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2023, 2:08 PM
matmarex claimed this task.Feb 14 2023, 2:08 PM
matmarex added a parent task: T315510: Start maintenance script to backfill talk page comment database.
matmarex added a project: Editing-team (Kanban Board).
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.
gerritbot added a comment.Feb 14 2023, 2:16 PM

Change 889140 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889140

gerritbot added a project: Patch-For-Review.Feb 14 2023, 2:16 PM
matmarex mentioned this in T315510: Start maintenance script to backfill talk page comment database.Feb 14 2023, 2:19 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Feb 14 2023, 5:42 PM
gerritbot added a comment.Feb 14 2023, 10:06 PM

Change 889140 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889140

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2023, 10:10 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 14 2023, 11:00 PM
gerritbot added a comment.Feb 14 2023, 11:33 PM

Change 889267 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.22] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889267

gerritbot added a project: Patch-For-Review.Feb 14 2023, 11:33 PM

Change 889268 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.23] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889268

gerritbot added a comment.Feb 15 2023, 2:07 PM

Change 889267 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.22] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889267

gerritbot added a comment.Feb 15 2023, 2:07 PM

Change 889268 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.40.0-wmf.23] persistRevisionThreadItems: Avoid listing non-discussion pages

https://gerrit.wikimedia.org/r/889268

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2023, 2:10 PM
Stashbot added a comment.Feb 15 2023, 2:11 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-15T14:11:53Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:889267|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]], [[gerrit:889268|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]]

Stashbot added a comment.Feb 15 2023, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-15T14:13:45Z] <samtar@deploy1002> matmarex and samtar: Backport for [[gerrit:889267|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]], [[gerrit:889268|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Feb 15 2023, 2:19 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-15T14:19:28Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:889267|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]], [[gerrit:889268|persistRevisionThreadItems: Avoid listing non-discussion pages (T329627)]] (duration: 07m 34s)

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Feb 15 2023, 2:21 PM
matmarex added a project: Skipped QA.
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 15 2023, 3:00 PM
ppelberg closed this task as Resolved.Feb 16 2023, 4:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits