Description
With function-schemata patch 876335 in place, the orchestrator's unit test 'Test that reify avoids infinite expansions' is still failing; needs diagnosis.
Background info: it was working prior to patch 862320. 862320 exposed bug T326357, which caused this test to fail for a different reason. Patch 876335 fixes T326357, but the test is still failing.
Patch 876335 also causes 3 WikiLambda integration tests to fail:
- Request specifies JSON for new implementation
- Request specifies JSON for edited version of existing implementation
- Request specifies non-implementation as implementation, by reference
as shown here: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81-noselenium-docker/3507/console
Steps to reproduce (step by step instructions, with links, commands and necessary data to reproduce the error)
- Unskip and run the unit test named 'Test that reify avoids infinite expansions' (which is in mswOrchestrateTest.js)
Observed behavior
- It returns the error below in Z22K2 (metadata value for "errors").
{
Z1K1: 'Z5',
Z5K1: 'Z518',
Z5K2: {
Z1K1: { Z1K1: 'Z7', Z7K1: 'Z885', Z885K1: 'Z518' },
Z518K1: 'Z20015',
Z518K2: { Z1K1: 'Z20015', Z20015K1: '1' },
Z518K3: { Z1K1: 'Z5', Z5K1: 'Z502', Z5K2: [Object] }
}
}The error for Z518 (object_type_mismatch) is constructed in execute.js.
Expected behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)
- It should pass.
Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task
Completion checklist
- Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist