[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T326466

Rework database setup in integration test to avoid dynamic properties under php8.2
Closed, ResolvedPublic
Actions

Description

MediaWikiIntegrationTestCase::setupDatabaseWithTestPrefix (declaring _originalTablePrefix) and MediaWikiIntegrationTestCase::oncePerClass (declaring $_hasDataForTestClass) needs another way to store information

PHP Deprecated:  Creation of dynamic property Wikimedia\Rdbms\DatabaseMysqli::$_originalTablePrefix is deprecated in /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php on line 1683
PHP Deprecated:  Creation of dynamic property Wikimedia\Rdbms\DatabaseMysqli::$_hasDataForTestClass is deprecated in /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php on line 533

Details

SubjectRepoBranchLines +/-
Introduce and use DynamicPropertyTestHelpermediawiki/coreREL1_40+104 -13
Introduce and use DynamicPropertyTestHelpermediawiki/coreREL1_39+105 -13
Introduce and use DynamicPropertyTestHelpermediawiki/coreREL1_41+104 -13
Introduce and use DynamicPropertyTestHelpermediawiki/coremaster+106 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Jan 7 2023, 10:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2023, 10:41 AM
Umherirrender added a parent task: T314099: PHP 8.2: Dynamic property creation is deprecated.Jan 7 2023, 10:41 AM
Umherirrender added a comment.Jan 7 2023, 11:17 AM

In MediaWikiIntegrationTestCase::setUpSchema is also property _schemaOverrides created dynamically

Umherirrender moved this task from Backlog to MediaWiki core on the PHP 8.2 support board.Jan 7 2023, 2:49 PM
Umherirrender merged a task: T329227: Deprecated: Creation of dynamic property Wikimedia\Rdbms\DatabaseMysqli.Feb 8 2023, 8:07 PM
Umherirrender added a subscriber: Ammarpad.
gerritbot added a comment.Feb 12 2023, 1:26 PM

Change 888315 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/core@master] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/888315

gerritbot added a project: Patch-For-Review.Feb 12 2023, 1:26 PM
Umherirrender unsubscribed.Jul 12 2023, 7:56 PM
Ammarpad merged a task: T351580: Creation of dynamic property Wikimedia\Rdbms\DatabaseMySQL::$_originalTablePrefix is deprecated.Nov 18 2023, 7:28 AM
Ammarpad added a subscriber: SD0001.
gerritbot added a comment.Nov 20 2023, 3:02 AM

Change 888315 merged by jenkins-bot:

[mediawiki/core@master] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/888315

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 3:10 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 20 2023, 4:00 AM
ArielGlenn subscribed.Nov 20 2023, 2:01 PM
Jdforrester-WMF closed this task as Resolved.Nov 20 2023, 2:32 PM
Jdforrester-WMF assigned this task to TK-999.
gerritbot added a comment.Apr 5 2024, 10:24 PM

Change #1017402 had a related patch set uploaded (by Reedy; author: TK-999):

[mediawiki/core@REL1_41] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/1017402

gerritbot added a project: Patch-For-Review.Apr 5 2024, 10:24 PM
gerritbot added a comment.Apr 5 2024, 11:03 PM

Change #1017402 merged by jenkins-bot:

[mediawiki/core@REL1_41] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/1017402

gerritbot added a comment.Apr 5 2024, 11:33 PM

Change #1017430 had a related patch set uploaded (by Reedy; author: TK-999):

[mediawiki/core@REL1_40] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/1017430

ReleaseTaggerBot added a project: MW-1.41-notes.Apr 6 2024, 12:00 AM
gerritbot added a comment.Apr 6 2024, 12:02 AM

Change #1017437 had a related patch set uploaded (by Reedy; author: TK-999):

[mediawiki/core@REL1_39] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/1017437

gerritbot added a comment.Apr 6 2024, 12:22 AM

Change #1017437 merged by jenkins-bot:

[mediawiki/core@REL1_39] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/1017437

gerritbot added a comment.Apr 6 2024, 12:38 AM

Change #1017430 merged by jenkins-bot:

[mediawiki/core@REL1_40] Introduce and use DynamicPropertyTestHelper

https://gerrit.wikimedia.org/r/1017430

ReleaseTaggerBot added projects: MW-1.40-notes, MW-1.39-notes.Apr 6 2024, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits